Re: Review Request 21407: Add JSHint to our build

2014-05-16 Thread David McLaughlin
On May 15, 2014, 5:06 p.m., Suman Karumuri wrote: build.gradle, line 246 https://reviews.apache.org/r/21407/diff/2/?file=581989#file581989line246 Should we be adding generated thrift sources here? 'ACTIVE_STATES' is not defined.

Re: Review Request 21407: Add JSHint to our build

2014-05-16 Thread Suman Karumuri
On May 15, 2014, 5:06 p.m., Suman Karumuri wrote: build.gradle, line 246 https://reviews.apache.org/r/21407/diff/2/?file=581989#file581989line246 Should we be adding generated thrift sources here? 'ACTIVE_STATES' is not defined.

Re: Review Request 21407: Add JSHint to our build

2014-05-16 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21407/#review43182 --- The code is pushed to master. Please close out this review and the

Re: Review Request 21407: Add JSHint to our build

2014-05-15 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21407/ --- (Updated May 14, 2014, 10:22 p.m.) Review request for Aurora, Suman Karumuri

Review Request 21407: Add JSHint to our build

2014-05-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21407/ --- Review request for Aurora, Suman Karumuri and Bill Farner. Bugs: AURORA-228