Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-21 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/#review43671 --- Pushed. Please close out this review. - Suman Karumuri On May 20,

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/ --- (Updated May 20, 2014, 11:19 p.m.) Review request for Aurora, Suman Karumuri an

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/ --- (Updated May 20, 2014, 7:24 p.m.) Review request for Aurora, Suman Karumuri and

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-20 Thread David McLaughlin
> On May 20, 2014, 6:08 p.m., Suman Karumuri wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line > > 98 > > > > > > s/if(/if (/ > > > > Can jsHint catch this? Good catch. Wi

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-20 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/#review43507 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/ --- (Updated May 16, 2014, 1:30 a.m.) Review request for Aurora, Suman Karumuri and

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/#review43264 --- Ship it! Ship It! - Mark Chu-Carroll On May 15, 2014, 9:30 p.m.,

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
> On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 17 > > > > > > Why? Good question. JavaScript in the browser doesn't have m

Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/ --- Review request for Aurora, Suman Karumuri and Mark Chu-Carroll. Repository: aur

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/#review43218 --- Ship it! Ship It! src/main/resources/org/apache/aurora/scheduler/

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
> On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 17 > > > > > > Why? > > David McLaughlin wrote: > Good question. >