Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/#review50900 --- Ship it! Ship It! - Bill Farner On Aug. 15, 2014, 11:57 p.m.,

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/#review50930 --- Ship it! Looks fine, but I don't really understand the reasoning.

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Maxim Khutornenko
On Aug. 18, 2014, 8:16 p.m., Mark Chu-Carroll wrote: Looks fine, but I don't really understand the reasoning. To me, it seems like expecting someone to have a lockid for a pause or a resume call is a good idea. It allows someone to pass responsibility for an ongoing update to

Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/ --- Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository:

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/#review50755 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Bill Farner
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly