Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65119 --- Ship it! Ship It! - Zameer Manji On Dec. 15, 2014, 12:54 p.m.,

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65120 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread Joshua Cohen
On Dec. 15, 2014, 9:18 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 73 https://reviews.apache.org/r/29058/diff/1/?file=792296#file792296line73 How about constraining the exceptions thrown here in the library? Better, why not just have the

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/ --- (Updated Dec. 15, 2014, 9:52 p.m.) Review request for Aurora, David

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65127 --- Ship it! Master (52efc93) is green with this patch.

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread Joshua Cohen
On Dec. 15, 2014, 9:54 p.m., Kevin Sweeney wrote: +1, please file a followup ticket to include the actual version in the version output. https://issues.apache.org/jira/browse/AURORA-970 - Joshua --- This is an automatically

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65131 --- Ship it! Ship It! - David McLaughlin On Dec. 15, 2014, 9:52

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

2014-12-15 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65151 --- This is on apache master. Feel free to close this review. - David