Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Maxim Khutornenko
> On March 4, 2015, 8:17 p.m., Bill Farner wrote: > > Is there a reason you did not opt to implement this behind the `Preemptor` > > interface? Seems like if you went with that approach, `TaskScheduler` can > > be oblivious to the background operations. > > Maxim Khutornenko wrote: > Tryi

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Maxim Khutornenko
> On March 4, 2015, 10:25 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 269 > > > > > > Is this the same single threaded scheduler used for ordinary > > scheduli

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31739/#review75247 --- src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Maxim Khutornenko
> On March 4, 2015, 8:17 p.m., Bill Farner wrote: > > Is there a reason you did not opt to implement this behind the `Preemptor` > > interface? Seems like if you went with that approach, `TaskScheduler` can > > be oblivious to the background operations. > > Maxim Khutornenko wrote: > Tryi

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Bill Farner
> On March 4, 2015, 8:17 p.m., Bill Farner wrote: > > Is there a reason you did not opt to implement this behind the `Preemptor` > > interface? Seems like if you went with that approach, `TaskScheduler` can > > be oblivious to the background operations. > > Maxim Khutornenko wrote: > Tryi

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Maxim Khutornenko
> On March 4, 2015, 8:17 p.m., Bill Farner wrote: > > Is there a reason you did not opt to implement this behind the `Preemptor` > > interface? Seems like if you went with that approach, `TaskScheduler` can > > be oblivious to the background operations. Trying to keep things simple. Moving it

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Maxim Khutornenko
> On March 4, 2015, 8:14 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 284 > > > > > > Can you explain the reason for the delay? We already wait for a task to >

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31739/#review75226 --- Is there a reason you did not opt to implement this behind the `Pree

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31739/#review75222 --- src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java

Re: Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31739/ --- (Updated March 4, 2015, 7:30 p.m.) Review request for Aurora, Bill Farner and Z

Review Request 31739: Making task preemption asynchronous.

2015-03-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31739/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1158