Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-809 h

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76410 --- src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecu

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
> On March 13, 2015, 12:59 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 95 > > > > > > I thought it's generally preferable when installing u

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76415 --- Master (128e554) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:18 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76424 --- Ship it! modulo missing license header picked up by review bot. -

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:26 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Joshua Cohen
> On March 13, 2015, 7:59 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 95 > > > > > > I thought it's generally preferable when installing us

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/ --- (Updated March 13, 2015, 1:31 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76421 --- Master (128e554) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76427 --- Ship it! Master (128e554) is green with this patch. ./build-suppo

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76450 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/api/securi

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-14 Thread Kevin Sweeney
> On March 13, 2015, 3:19 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java, > > line 28 > > > > > > Can you update SchedulerMain to take advantage of this? Fee