[GitHub] [helix] dasahcc commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

dasahcc commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r311819252 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

dasahcc commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r311818918 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311816737 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

dasahcc commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#discussion_r311811595 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

dasahcc commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311810414 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

dasahcc commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311810457 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

dasahcc commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311810280 ## File path:

[GitHub] [helix] dasahcc merged pull request #391: Improve ZK read with batch call for Helix REST

dasahcc merged pull request #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [helix] dasahcc commented on issue #391: Improve ZK read with batch call for Helix REST

dasahcc commented on issue #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#issuecomment-519310252 This PR is ready to be merged, approved by @i3wangyi This is an automated

[GitHub] [helix] i3wangyi commented on a change in pull request #391: Improve ZK read with batch call for Helix REST

i3wangyi commented on a change in pull request #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#discussion_r311806851 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java ##

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311806687 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311806789 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311806238 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #391: Improve ZK read with batch call for Helix REST

dasahcc commented on a change in pull request #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#discussion_r311803244 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java ##

[GitHub] [helix] i3wangyi commented on a change in pull request #391: Improve ZK read with batch call for Helix REST

i3wangyi commented on a change in pull request #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#discussion_r311800464 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java ##

[GitHub] [helix] narendly commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

narendly commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-519301768 Ideally, it would be great if this stuff could be resolved at the library level, but we could have a workaround for

[GitHub] [helix] dasahcc commented on a change in pull request #391: Improve ZK read with batch call for Helix REST

dasahcc commented on a change in pull request #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#discussion_r311796512 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java ##

[GitHub] [helix] narendly commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

narendly commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#discussion_r311796315 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

narendly commented on a change in pull request #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#discussion_r311795528 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311793740 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311792298 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311793469 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #391: Improve ZK read with batch call for Helix REST

i3wangyi commented on a change in pull request #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#discussion_r311789649 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java ##

[GitHub] [helix] dasahcc commented on issue #391: Improve ZK read with batch call for Helix REST

dasahcc commented on issue #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#issuecomment-519288181 > > > I've already had a PR pending with the same purpose, why is it? > > > > > > This is orthogonal with your change. It is an

[GitHub] [helix] i3wangyi commented on issue #391: Improve ZK read with batch call for Helix REST

i3wangyi commented on issue #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#issuecomment-519286180 > > I've already had a PR pending with the same purpose, why is it? > > This is orthogonal with your change. It is an improvement

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311768165 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311769997 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311771618 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311765021 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311770684 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311765937 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311764093 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311769087 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

jiajunwang commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311767067 ## File path:

[GitHub] [helix] dasahcc commented on issue #391: Improve ZK read with batch call for Helix REST

dasahcc commented on issue #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391#issuecomment-519277504 > I've already had a PR pending with the same purpose, why is it? This is orthogonal with your change. It is an improvement inside

[GitHub] [helix] dasahcc opened a new pull request #391: Improve ZK read with batch call for Helix REST

dasahcc opened a new pull request #391: Improve ZK read with batch call for Helix REST URL: https://github.com/apache/helix/pull/391 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR title: #390 ### Description - [ ]

[GitHub] [helix] i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#issuecomment-519274588 > Has this really been properly formatted using helix-style.xml? Why are there so many style changes? Could you please

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311760336 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311768634 ## File path:

[GitHub] [helix] i3wangyi opened a new pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi opened a new pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: (#366) ###

[GitHub] [helix] i3wangyi removed a comment on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi removed a comment on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#issuecomment-519273467 > Has this really been properly formatted using helix-style.xml? Why are there so many style changes? Could you

[GitHub] [helix] i3wangyi closed pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi closed pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#issuecomment-519273467 > Has this really been properly formatted using helix-style.xml? Why are there so many style changes? Could you please

[GitHub] [helix] dasahcc opened a new issue #390: Improve Helix REST partition level read operation

dasahcc opened a new issue #390: Improve Helix REST partition level read operation URL: https://github.com/apache/helix/issues/390 In REST partition read, we reads partition level health status one by one. It increased the call the ZK. We should improve it with batch call.

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311760336 ## File path:

[GitHub] [helix] dasahcc commented on issue #374: Stablize the REST tests in helix-rest

dasahcc commented on issue #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374#issuecomment-519270389 This PR is ready to be merged, approved by @narendly This is an automated message

[GitHub] [helix] dasahcc merged pull request #374: Stablize the REST tests in helix-rest

dasahcc merged pull request #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

i3wangyi commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311761834 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311729802 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311731548 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm

narendly commented on a change in pull request #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#discussion_r311737328 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311727216 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311723544 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311727727 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311721811 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311719298 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311721024 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#discussion_r311722269 ## File path:

[GitHub] [helix] narendly opened a new pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

narendly opened a new pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: See the design

[GitHub] [helix] narendly opened a new issue #387: TASK: Fix ZkClient's "Failure to delete..." for task contexts

narendly opened a new issue #387: TASK: Fix ZkClient's "Failure to delete..." for task contexts URL: https://github.com/apache/helix/issues/387 When we delete a workflow the following log was printed repeatedly (reproducible): `2019/08/06 23:46:58.152 WARN [ZkClient]

[GitHub] [helix] narendly opened a new issue #386: TASK: Use CurrentState as the source of truth instead of Workflow/JobContext

narendly opened a new issue #386: TASK: Use CurrentState as the source of truth instead of Workflow/JobContext URL: https://github.com/apache/helix/issues/386 When there are frequent disconnects to Participants, it is possible to have discrepancy between what's in CurrentState and what's

[GitHub] [helix] narendly opened a new issue #384: Make sure task states are updated after workflow/job reaches terminal states

narendly opened a new issue #384: Make sure task states are updated after workflow/job reaches terminal states URL: https://github.com/apache/helix/issues/384 Investigate the title. This is an automated message from the

[GitHub] [helix] narendly opened a new issue #383: Review RuntimeJobDag to prevent jobs that are not ready from being added to readyList

narendly opened a new issue #383: Review RuntimeJobDag to prevent jobs that are not ready from being added to readyList URL: https://github.com/apache/helix/issues/383 We observed some jobs whose start time (with an execution delay (DelayTime) set) is greater than the current time get