[GitHub] [helix] i3wangyi closed issue #366: Performance issues in `InstancesAccessor#getParallelStoppableInstances`

2019-08-13 Thread GitBox
i3wangyi closed issue #366: Performance issues in `InstancesAccessor#getParallelStoppableInstances` URL: https://github.com/apache/helix/issues/366 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] i3wangyi commented on issue #381: Implement the POC work greedy constraint based algorithm

2019-08-13 Thread GitBox
i3wangyi commented on issue #381: Implement the POC work greedy constraint based algorithm URL: https://github.com/apache/helix/pull/381#issuecomment-521073125 don't read, I've messed up the commits and will get it reverted

[GitHub] [helix] jiajunwang commented on issue #404: Release note for 0.9.1.

2019-08-13 Thread GitBox
jiajunwang commented on issue #404: Release note for 0.9.1. URL: https://github.com/apache/helix/pull/404#issuecomment-521056458 ![Screenshot from 2019-08-13 17-11-59](https://user-images.githubusercontent.com/1803880/62986007-9ddec800-bdee-11e9-83ac-60b5e2dcca16.png)

[GitHub] [helix] jiajunwang opened a new pull request #404: Release note for 0.9.1.

2019-08-13 Thread GitBox
jiajunwang opened a new pull request #404: Release note for 0.9.1. URL: https://github.com/apache/helix/pull/404 Release note for 0.9.1 Note: This is more like a bug fixing release. So no new features. This is an

[GitHub] [helix] dasahcc merged pull request #403: Bump up the snapshot version.

2019-08-13 Thread GitBox
dasahcc merged pull request #403: Bump up the snapshot version. URL: https://github.com/apache/helix/pull/403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [helix] jiajunwang opened a new pull request #403: Bump up the snapshot version.

2019-08-13 Thread GitBox
jiajunwang opened a new pull request #403: Bump up the snapshot version. URL: https://github.com/apache/helix/pull/403 Also fix the missing helix-agent snapshot update logic in the bump-up.comand. This is an automated message

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634821 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634758 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313636365 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634204 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313634598 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
narendly commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313637216 ## File path:

[GitHub] [helix] dasahcc merged pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

2019-08-13 Thread GitBox
dasahcc merged pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue

2019-08-13 Thread GitBox
i3wangyi commented on issue #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376#issuecomment-52034 The PR is approved by @dasahcc, ready to be merged This

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313600224 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] i3wangyi commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313598965 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313594282 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313593380 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313598334 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313592714 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation

2019-08-13 Thread GitBox
i3wangyi commented on a change in pull request #388: Add ChangeDetector interface and ResourceChangeDetector implementation URL: https://github.com/apache/helix/pull/388#discussion_r313596107 ## File path:

[GitHub] [helix] jiajunwang opened a new issue #402: Implement the WAGED rebalancer

2019-08-13 Thread GitBox
jiajunwang opened a new issue #402: Implement the WAGED rebalancer URL: https://github.com/apache/helix/issues/402 Based on the existing components (or the interfaces), we can now implement the initial version of the WAGED rebalancer. AC: - Implement the rebalancer with unit

[GitHub] [helix] jiajunwang closed issue #372: Implement the Cluster Model data provider for the WAGED rebalancer

2019-08-13 Thread GitBox
jiajunwang closed issue #372: Implement the Cluster Model data provider for the WAGED rebalancer URL: https://github.com/apache/helix/issues/372 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] jiajunwang merged pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang merged pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [helix] jiajunwang commented on issue #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on issue #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#issuecomment-520951227 Approved by @dasahcc and I will merge it to our working branch soon. This is an

[GitHub] [helix] jiajunwang commented on issue #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on issue #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#issuecomment-520947396 Addressed comments. For the format related issues, @pkuwm will be working on refining the format file. We can fix the style after that.

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313540444 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313526817 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313526888 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider.

2019-08-13 Thread GitBox
jiajunwang commented on a change in pull request #392: Implement Cluster Model Provider. URL: https://github.com/apache/helix/pull/392#discussion_r313526164 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java

[GitHub] [helix] jiajunwang commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

2019-08-13 Thread GitBox
jiajunwang commented on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable. URL: https://github.com/apache/helix/pull/378#issuecomment-520933866 One more thing, please also revisit the previous comments and resolve them if the problem has been fixed or no

[GitHub] [helix] brunnsbe commented on issue #401: Replace org.codehaus.jackson with FasterXML/jackson

2019-08-13 Thread GitBox
brunnsbe commented on issue #401: Replace org.codehaus.jackson with FasterXML/jackson URL: https://github.com/apache/helix/issues/401#issuecomment-520714421 I forked this repository and made a commit that replaces the old Jackson with the newer FasterXML/Jackson:

[GitHub] [helix] brunnsbe opened a new issue #401: Replace org.codehaus.jackson with FasterXML/jackson

2019-08-13 Thread GitBox
brunnsbe opened a new issue #401: Replace org.codehaus.jackson with FasterXML/jackson URL: https://github.com/apache/helix/issues/401 This issue is the same as https://issues.apache.org/jira/browse/HELIX-747 (it's a bit confusing which issue list should be used for this project as the