narendly merged pull request #899: Use Java Generics and inheritance to reduce
duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899
This is an automated message from the Apache Git Service.
To
jiajunwang merged pull request #904: Fix the concurrent modification error
happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904
This is an automated message from the Apache Git
jiajunwang commented on issue #904: Fix the concurrent modification error
happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904#issuecomment-601972438
This PR is ready to be merged, approved by @pkuwm
jiajunwang commented on a change in pull request #904: Fix the concurrent
modification error happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904#discussion_r395946837
##
File path:
pkuwm commented on a change in pull request #904: Fix the concurrent
modification error happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904#discussion_r395929866
##
File path:
pkuwm commented on a change in pull request #904: Fix the concurrent
modification error happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904#discussion_r395940851
##
File path:
pkuwm commented on a change in pull request #904: Fix the concurrent
modification error happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904#discussion_r395940379
##
File path:
pkuwm commented on a change in pull request #904: Fix the concurrent
modification error happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904#discussion_r395940156
##
File path:
pkuwm commented on a change in pull request #904: Fix the concurrent
modification error happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904#discussion_r395941462
##
File path:
alirezazamani closed issue #833: TODO: Add routing table provider for
customized view
URL: https://github.com/apache/helix/issues/833
This is an automated message from the Apache Git Service.
To respond to the message,
jiajunwang opened a new pull request #904: Fix the concurrent modification
error happens during the HelixManager initHandlers() call
URL: https://github.com/apache/helix/pull/904
### Issues
- [ ] My PR addresses the following Helix issues and references them in the
PR description:
jiajunwang opened a new issue #903: ConcurrentModificationException happens in
the initHandler() logic
URL: https://github.com/apache/helix/issues/903
Example of the Exception.
Note the version 0.9.1.507 is an internal minor version that has not been
published publicly yet. But the
zhangmeng916 commented on issue #851: Modify Helix generic controller to
include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#issuecomment-601939430
> One more thing, the added test cases are not enough. Please add tests for
the following
zhangmeng916 commented on a change in pull request #851: Modify Helix generic
controller to include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#discussion_r395884785
##
File path:
narendly commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395846744
##
File path:
jiajunwang merged pull request #834: Complete the Routing Table Provider for
CustomizedView
URL: https://github.com/apache/helix/pull/834
This is an automated message from the Apache Git Service.
To respond to the message,
jiajunwang commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395812800
##
File path:
narendly commented on issue #899: Use Java Generics and inheritance to reduce
duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#issuecomment-601842437
> > > Looks good in general.
> > > The only thing concerns me is the newly modified deprecated
narendly commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395809363
##
File path:
narendly commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395807333
##
File path:
jiajunwang commented on issue #899: Use Java Generics and inheritance to reduce
duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#issuecomment-601838962
> > Looks good in general.
> > The only thing concerns me is the newly modified deprecated
narendly commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395806370
##
File path:
narendly commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395734888
##
File path:
narendly commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395734207
##
File path:
alirezazamani commented on issue #834: Complete the Routing Table Provider for
CustomizedView
URL: https://github.com/apache/helix/pull/834#issuecomment-601773757
This PR is ready to be merged, approved by @zhangmeng916
Final commit message:
Complete the Routing Table Provider
jiajunwang commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395454217
##
File path:
jiajunwang commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395453530
##
File path:
jiajunwang commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395452606
##
File path:
jiajunwang commented on a change in pull request #899: Use Java Generics and
inheritance to reduce duplicate code in Helix API Builders
URL: https://github.com/apache/helix/pull/899#discussion_r395450703
##
File path:
29 matches
Mail list logo