[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1086061527 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,213 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1086002703 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,213 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1084648006 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,208 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1084458210 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,208 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1084429118 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,213 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1083109948 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,201 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1083108711 ## meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClient.java: ## @@ -39,8 +39,11 @@ import org.apache.commons.lang3.NotImplementedException;

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1083108511 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,201 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1083099275 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,201 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1083098562 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,201 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1083096507 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,201 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1083092347 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -391,34 +380,13 @@ public int hashCode() { } } - private static Me

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1082869761 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1082808508 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1082753521 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081995237 ## meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientKeeperException.java: ## @@ -0,0 +1,39 @@ +package org.apache.helix.metaclient.constants;

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081994436 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java: ## @@ -0,0 +1,156 @@ +package org.apache.helix.metaclient.impl.zk.util; +

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081974549 ## meta-client/src/main/java/org/apache/helix/metaclient/constants/MetaClientKeeperException.java: ## @@ -0,0 +1,39 @@ +package org.apache.helix.metaclient.constants;

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081842259 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,11 +51,15 @@ import org.apache.zookeeper.KeeperException; import org.ap

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081709850 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081684126 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081675851 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,11 +51,15 @@ import org.apache.zookeeper.KeeperException; import org.ap

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081640082 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +415,128 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081630325 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -50,11 +51,15 @@ import org.apache.zookeeper.KeeperException; import org.ap

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081455964 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081394971 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081380987 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081380987 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081380987 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081355091 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera

[GitHub] [helix] Marcosrico commented on a diff in pull request #2343: ZkMetaclient - implementation of TransactionOp

Marcosrico commented on code in PR #2343: URL: https://github.com/apache/helix/pull/2343#discussion_r1081355091 ## meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java: ## @@ -414,4 +414,130 @@ private static EntryMode convertZkEntryMode(long ephemera