[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8801 to look at the new patch set (#13). Change subject: IMPALA-5191: Standardize column alias behavior ...

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 12: (1 comment) Thanks! I filed IMPALA-6415 for docume

[Impala-ASF-CR] IMPALA-6416: extend Thread::Create to track instance id

2018-01-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9053 Change subject: IMPALA-6416: extend Thread::Create to track instance id .. IMPALA-6416: extend Thread::Create to track instance id T

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups"

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9054 Change subject: IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups" .. IMPALA-6419: Revert "IMPALA-6383: fr

[Impala-ASF-CR] IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups"

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9054 ) Change subject: IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups" .. Patch Set 1: Build started

[Impala-ASF-CR] IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups"

2018-01-18 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9054 ) Change subject: IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups" .. Patch Set 1: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9022 ) Change subject: IMPALA-6368: make test_chars parallel .. Patch Set 3: Filed IMPALA-6419 for the crash. -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups"

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9054 ) Change subject: IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups" .. Patch Set 1: The revert was clean.

[Impala-ASF-CR] Increment version to 2.12.0-SNAPSHOT

2018-01-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9001 ) Change subject: Increment version to 2.12.0-SNAPSHOT .. Patch Set 2: Code-Review+2 Rebased, carrying +2 forward -- To view,

[Impala-ASF-CR] Increment version to 2.12.0-SNAPSHOT

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9001 ) Change subject: Increment version to 2.12.0-SNAPSHOT .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify

[Impala-ASF-CR] IMPALA-2397: Use atomics for IntGauge and IntCounter

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for IntGauge and IntCounter .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: Code-Review+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-18 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. IMPALA-5990: End-to-end compression of metadata Currently the catalog da

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9058 Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. IMPALA-5528: Bump total thread cache size when KRPC is ena

[Impala-ASF-CR] Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC"

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9057 Change subject: Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC" .. Revert "IMPALA-5528: Upgrade GPerfTools to

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9022 ) Change subject: IMPALA-6368: make test_chars parallel .. Patch Set 4: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9022 ) Change subject: IMPALA-6368: make test_chars parallel .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verif

[Impala-ASF-CR] Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC"

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9057 ) Change subject: Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC" .. Patch Set 1: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 16: Ping? Anyone able to review this? -- To vie

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9059 Change subject: IMPALA-6383: free memory after skipping parquet row groups .. IMPALA-6383: free memory after skipping parquet row groups

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9059 To

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9059 to look at the new patch set (#2). Change subject: IMPALA-6383: free memory after skipping parquet row groups .. IMPALA

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has restored this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Restored -- To view, visit http://gerrit.cloudera.org:8080/9059 To un

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9060 Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. IMPALA-6418: Find a reliable way to detect supporte

[Impala-ASF-CR] Bumping version to 3.0.

2018-01-18 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9044 to look at the new patch set (#3). Change subject: Bumping version to 3.0. .. Bumping version to 3.0. This cha

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-18 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9045 to look at the new patch set (#4). Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9045 ) Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .. Patch Set 2: (25 comments) Thanks for the detailed revie

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Pranay Singh (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8949 to look at the new patch set (#3). Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. ..

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 9: (2 comments) Thanks. Ple

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#10). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .

[Impala-ASF-CR] IMPALA-6382: Cap spillable buffer size and max row size query options

2018-01-18 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9023 to look at the new patch set (#3). Change subject: IMPALA-6382: Cap spillable buffer size and max row size query options ...

[Impala-ASF-CR] IMPALA-6382: Cap spillable buffer size and max row size query options

2018-01-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9023 ) Change subject: IMPALA-6382: Cap spillable buffer size and max row size query options .. Patch Set 3: Code-Review+2 Fixed the broken

[Impala-ASF-CR] IMPALA-6382: Cap spillable buffer size and max row size query options

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9023 ) Change subject: IMPALA-6382: Cap spillable buffer size and max row size query options .. Patch Set 3: Build started: https://j

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (1 comment) Just one question about t

[Impala-ASF-CR] Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC"

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9057 ) Change subject: Revert "IMPALA-5528: Upgrade GPerfTools to 2.6.3 and tune TCMalloc for KRPC" .. Patch Set 1: Build started: ht

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-2397: Use atomics for IntGauge and IntCounter

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9012 ) Change subject: IMPALA-2397: Use atomics for IntGauge and IntCounter .. Patch Set 3: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: Is there a convenient place where

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 3: (11 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 3: I hit a DCHECK after running th

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 10: Code-Review+1 (2 comments) +1. Alex,

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 10: Please see my previous comment and th

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 16: Sorry. Will start on it today. -- To view, vis

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-18 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9062 Change subject: IMPALA-4924: Enable Decimal V2 by default .. IMPALA-4924: Enable Decimal V2 by default In this commit we enable Deci

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 16: NP, just wanted to see what the state of it w

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9062/1//CO

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-18 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#11). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT ..

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 11: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] Increment version to 2.12.0-SNAPSHOT

2018-01-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9001 ) Change subject: Increment version to 2.12.0-SNAPSHOT .. Patch Set 2: Code-Review-1 I don't think we want this anymore. We're going to 3

[Impala-ASF-CR] Increment version to 2.12.0-SNAPSHOT

2018-01-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9001 ) Change subject: Increment version to 2.12.0-SNAPSHOT .. Patch Set 2: Code-Review-2 -- To view, visit http://gerrit.cloudera.org:8080/9

[Impala-ASF-CR] Increment version to 2.12.0-SNAPSHOT

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9001 ) Change subject: Increment version to 2.12.0-SNAPSHOT .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/ger

[Impala-ASF-CR] Increment version to 2.12.0-SNAPSHOT

2018-01-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/9001 ) Change subject: Increment version to 2.12.0-SNAPSHOT .. Abandoned Superseded by https://gerrit.cloudera.org/#/c/9044/ -- To view, visit

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9063 Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. IMPALA-5801: [draft] Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: (1 comment) > Is there a convenient

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. Patch Set 1: (3 comments) The declarations of the new/r

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread John Russell (Code Review)
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9064 Change subject: [DOCS] Minor editorial change .. [DOCS] Minor editorial change Turn "royal we" into imperative statement. Change-Id: Ib7

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: This is a small review for arodoni to practice with gerrit. -- To view,

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 3: (4 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 4: Code-Review+1 +2 for the backe

[Impala-ASF-CR] IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups"

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9054 ) Change subject: IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups" .. Patch Set 1: Verified+1 -

[Impala-ASF-CR] IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups"

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9054 ) Change subject: IMPALA-6419: Revert "IMPALA-6383: free memory after skipping parquet row groups" .. IMPALA-6419: Revert

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9064/1/docs/topics/impala_

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9064/1/docs/topics/impala

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9064 To un

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: Code-Review+2 Full steam ahead! -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/1

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 4: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-18 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#5). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-18 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#5). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr ..

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 4: Code-Review+2 Rebase, carr

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9006 ) Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. Patch Set 4: Build started: htt

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: > ... returns an internal represen

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 10: Build started:

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/906

[Impala-ASF-CR] [DOCS] Minor editorial change

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. [DOCS] Minor editorial change Turn "royal we" into imperative statemen

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 1: (1 comment) Are the corresponding test

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-18 Thread Anonymous Coward (Code Review)
xyutin...@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9065 Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. IMPALA-5440 Add planner tests with extreme stati

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 1: (1 comment) missing test file? http://ge

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-18 Thread Anonymous Coward (Code Review)
xyutin...@cloudera.com has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. IMPALA-5440 Add planner tests with extreme statis

[Impala-ASF-CR] [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause

2018-01-18 Thread John Russell (Code Review)
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9066 Change subject: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause .. [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause

[Impala-ASF-CR] IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause

2018-01-18 Thread John Russell (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9066 to look at the new patch set (#2). Change subject: IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause ...

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9022 ) Change subject: IMPALA-6368: make test_chars parallel .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 6: (8 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-18 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#7). Change subject: IMPALA-6193: Track memory of incoming data streams ..

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8914

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9022 ) Change subject: IMPALA-6368: make test_chars parallel .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9022 ) Change subject: IMPALA-6368: make test_chars parallel .. Patch Set 4: Hit IMPALA-6215 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6368: make test chars parallel

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9022 ) Change subject: IMPALA-6368: make test_chars parallel .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verif

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9059 to look at the new patch set (#3). Change subject: IMPALA-6383: free memory after skipping parquet row groups .

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 3: (6 comments) impala-server.cc has 3

[Impala-ASF-CR] IMPALA-6382: Cap spillable buffer size and max row size query options

2018-01-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9023 ) Change subject: IMPALA-6382: Cap spillable buffer size and max row size query options .. Patch Set 3: Verified+1 -- To view,

  1   2   >