[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. IMPALA-6822: Add a query opt

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 2: Verified+1 -- To view

[Impala-ASF-CR] IMPALA-6867: [DOCS] SHUFFLE DISTINCT EXPRS Query option added

2018-04-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10094 ) Change subject: IMPALA-6867: [DOCS] SHUFFLE_DISTINCT_EXPRS Query option added .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 10: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 9: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-2195: Improper handling of comments in queries

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9933 ) Change subject: IMPALA-2195: Improper handling of comments in queries .. IMPALA-2195: Improper handling of comments in queries This patch

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Patch Set 4: I'll abandon this PR then. -- To view, visit h

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has abandoned this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/10085 To un

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Patch Set 4: I agree with some comments but not with others. I d

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. Patch Set 5: Build started: https://je

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. Patch Set 5: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. Patch Set 5: GVO failed because of the PyPI red

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. IMPALA-6862: Privilege.java needs to support Sentr

[Impala-ASF-CR] IMPALA-6867: [DOCS] SHUFFLE DISTINCT EXPRS Query option added

2018-04-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10094 ) Change subject: IMPALA-6867: [DOCS] SHUFFLE_DISTINCT_EXPRS Query option added .. IMPALA-6867: [DOCS] SHUFFLE_DISTINCT_EXPRS Query option ad

[Impala-ASF-CR] IMPALA-6867: [DOCS] SHUFFLE DISTINCT EXPRS Query option added

2018-04-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10094 Change subject: IMPALA-6867: [DOCS] SHUFFLE_DISTINCT_EXPRS Query option added .. IMPALA-6867: [DOCS] SHUFFLE_DISTINCT_EXPRS Query option a

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 2: Build started: https:/

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 2: Code-Review+2 Rebased to get P

[Impala-ASF-CR](2.x) IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10093 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR](2.x) IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10093 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. IMPALA-6863: Make pip_download.py honor redirects

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-04-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/9300/11

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-04-17 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 11: (4 comments) Sailesh, can you have a look at the TLS be

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. IMPALA-6847: work around high memory estimates

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 14: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] Add new queries to targeted-perf workload

2018-04-17 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9979 ) Change subject: Add new queries to targeted-perf workload .. Patch Set 3: Please add a description to the change describing the high

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. IMPALA-6790: Upgrade sqlparse to 0.1.19 Some remote cluster

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-6679,IMPALA-6678: reduce scan reservation

2018-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 ) Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation .. Patch Set 6: (17 comments) Will send backend comments separately. htt

[Impala-ASF-CR](2.x) IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10093 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 1: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR](2.x) IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10093 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 9: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-17 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 9: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR](2.x) IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Philip Zeyliger, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10093 to review the following change. Change subject: IMPALA-6863: Make pip_download.py honor redirects. ..

[Impala-ASF-CR](2.x) IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10093 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 1: Clean cherry-pick. 2.x is hitting the same PyPi iss

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 1: Job failed on pypi stuff. Reba

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 1: Verified-1 Build faile

[Impala-ASF-CR] Add new queries to targeted-perf workload

2018-04-17 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9979 Change subject: Add new queries to targeted-perf workload .. Add new queries to targeted-perf workload Change-Id: I5c415924d0bb6da1

[Impala-ASF-CR] IMPALA-6733: [DOCS] Impala 3.0 Release Notes

2018-04-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10090 ) Change subject: IMPALA-6733: [DOCS] Impala 3.0 Release Notes .. Patch Set 3: > (1 comment) Done. However, there is a separate review fo

[Impala-ASF-CR] IMPALA-6733: [DOCS] Impala 3.0 Release Notes

2018-04-17 Thread Alex Rodoni (Code Review)
Hello Sailesh Mukil, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10090 to look at the new patch set (#3). Change subject: IMPALA-6733: [DOCS] Impala 3.0 Release Notes .

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 14: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 13: Code-Review+2 Looks good to me. Carrying over

[Impala-ASF-CR] IMPALA-6733: [DOCS] Impala 3.0 Release Notes

2018-04-17 Thread Alex Rodoni (Code Review)
Hello Sailesh Mukil, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10090 to look at the new patch set (#2). Change subject: IMPALA-6733: [DOCS] Impala 3.0 Release Notes .

[Impala-ASF-CR] IMPALA-6733: [DOCS] Impala 3.0 Release Notes

2018-04-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10090 ) Change subject: IMPALA-6733: [DOCS] Impala 3.0 Release Notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10090/1/

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Sailesh Mukil (Code Review)
Hello Fredy Wijaya, Jim Apple, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10068 to look at the new patch set (#4). Change subject: Allow bootstrap_system.sh to work on existing impala/ repo ..

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 13: Code-Review+2 Please wait for Bikram's sign off as

[Impala-ASF-CR] IMPALA-6733: [DOCS] Impala 3.0 Release Notes

2018-04-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10090 Change subject: IMPALA-6733: [DOCS] Impala 3.0 Release Notes .. IMPALA-6733: [DOCS] Impala 3.0 Release Notes Change-Id: I971323993aa6dced

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Tim Armstrong (Code Review)
Hello Philip Zeyliger, Bikramjeet Vig, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10058 to look at the new patch set (#13). Change subject: IMPALA-6847: work around high memory estimates for AC

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 12: (7 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-ve

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 3: Code-Review+2 Rebased. Carrying +2. -- To view, visit http:/

[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges

2018-04-17 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Alex Behm, Impala Public Jenkins, Adam Holley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10079 to look at the new patch set (#2). Change subject: IMPALA-6651: [DOCS] Fine grained privileges ..

[Impala-ASF-CR] Add new performance test workload - tpcds-unmodified

2018-04-17 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9973 Change subject: Add new performance test workload - tpcds-unmodified .. Add new performance test workload - tpcds-unmodified Descri

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Patch Set 4: I'm happy to be overridden, but I think "Hive

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-17 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-17 Thread Alex Rodoni (Code Review)
Hello Vincent Tran, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10052 to look at the new patch set (#4). Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP ...

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. IMPALA-6863: Make pip_download.py honor redirects. As

[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3

2018-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9941/4/be/

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. Patch Set 4: Build started: https://je

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. Patch Set 4: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] Allow bootstrap system.sh to work on existing impala/ repo

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10068 ) Change subject: Allow bootstrap_system.sh to work on existing impala/ repo .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Patch Set 4: > Patch Set 4: > > Why are we exposing this? I'm

[Impala-ASF-CR] IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0

2018-04-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10082 ) Change subject: IMPALA-6862: Privilege.java needs to support Sentry 1.5.1 and 2.0.0 .. Patch Set 4: Code-Review+1 The core change LGT

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 1: Build started: https:/

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10087 ) Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs .. Patch Set 1: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10085 ) Change subject: IMPALA-6749: Implement ALTER DATABASE SET DBPROPERTIES .. Patch Set 4: Why are we exposing this? I'm worried that we

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 12: > > (3 comments) > > > I also really like th

[Impala-ASF-CR](2.x) IMPALA-6822: Add a query option to control shuffling by distinct exprs

2018-04-17 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10087 to review the following change. Change subject: IMPALA-6822: Add a query option to control shuffling by distinct exprs

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 3: Verified+1 Code-Review+2 Whoops; thanks. Jenkins

[Impala-ASF-CR] IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP

2018-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10052 ) Change subject: IMPALA-6748: [DOCS] Separators when casting STRING to TIMESTAMP .. Patch Set 3: (1 comment) LGTM except for one minor

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6847: work around high memory estimates for AC

2018-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10058 ) Change subject: IMPALA-6847: work around high memory estimates for AC .. Patch Set 12: > (3 comments) > I also really like the ideas in

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges

2018-04-17 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 ) Change subject: IMPALA-6651: [DOCS] Fine grained privileges .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10079/1/d

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-04-17 Thread Gabor Kaszab (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9943 to look at the new patch set (#3). Change subject: IMPALA-5706: Parallelise read I/O in sorter .. IMPALA-5706: Para

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. Patch Set 3: Code-Review-2 Updated the commit message, thanks for

[Impala-ASF-CR] IMPALA-6863: Make pip download.py honor redirects.

2018-04-17 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3) to the change originally created by Philip Zeyliger. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-6863: Make pip_download.py honor redirects. .. IMPALA-6863: Make

[Impala-ASF-CR] IMPALA-6651: [DOCS] Fine grained privileges

2018-04-17 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10079 ) Change subject: IMPALA-6651: [DOCS] Fine grained privileges .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10079/1/do

[Impala-ASF-CR] IMPALA-6790: Upgrade sqlparse to 0.1.19

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10044 ) Change subject: IMPALA-6790: Upgrade sqlparse to 0.1.19 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-ve

[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.

2018-04-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-686: Make pip_download.py honor redirects. .. Patch Set 2: (1 comment) Thanks for the quick fix! http://gerrit.

[Impala-ASF-CR] IMPALA-686: Make pip download.py honor redirects.

2018-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10083 ) Change subject: IMPALA-686: Make pip_download.py honor redirects. .. Patch Set 2: Build started: https://jenkins.impala.io/job