[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 4: Build Successful https:/

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 5: Build started: https://je

[Impala-ASF-CR] IMPALA-7805: Emit zero as "0" in toSql()

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11878 ) Change subject: IMPALA-7805: Emit zero as "0" in toSql() .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-v

[Impala-ASF-CR] IMPALA-7805: Emit zero as "0" in toSql()

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11878 ) Change subject: IMPALA-7805: Emit zero as "0" in toSql() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 4: Code-Review+2 (2 comments) Carry

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 5: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. IMPALA-941: Fix support for an identifier that sta

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 1: (4 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 3: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 3: Build Successful https:/

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 1: Build Successfu

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 3: (5 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. IMPALA-941: Fix support for an identifier that sta

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 2: (5 comments) just a bunch

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11928 Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. IMPALA-7839: Remove code duplication fo

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 7: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 8: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. IMPALA-7764: Improve SentryProxy test coverage This patch refactors the

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 7: Code-Review+2 (1 comment) Carry Vuk's +2. http://gerri

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11925 ) Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11925 ) Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. IMPALA-7848: Enable ParserTest.TestAdminFns This patch

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 3: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7805: Emit zero as "0" in toSql()

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11878 ) Change subject: IMPALA-7805: Emit zero as "0" in toSql() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 3: (9 comments) Looking good, mainly had minor c

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 ) Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option .. Patch Set 3: Verified+1 Build Successful https:

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots Th

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 3: > Patch Set 2: > > > Patch Set 2: > > > > >

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11925 ) Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. Patch Set 2: Code-Review+1 Thanks for fixing. -- To view, visit http:

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 ) Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Alex Rodoni (Code Review)
Hello Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11914 to look at the new patch set (#3). Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 ) Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option .. Patch Set 3: Build Started https://jenkins.impal

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 ) Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 ) Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7764: Improve SentryProxy test coverage

2018-11-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11880 ) Change subject: IMPALA-7764: Improve SentryProxy test coverage .. Patch Set 6: Code-Review+2 (2 comments) just minor suggestions from

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 ) Change subject: Add a handy tool to collapse threads in pstacks .. Patch Set 1: Yes. I couldn't track down Domas' email. But I'

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 ) Change subject: Add a handy tool to collapse threads in pstacks .. Patch Set 1: Unfortunately we probably need to clarify the license

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 ) Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7836: [DOCS] Document TOPN BYTES LIMIT query option

2018-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11914 ) Change subject: IMPALA-7836: [DOCS] Document TOPN_BYTES_LIMIT query option .. Patch Set 2: Code-Review+1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed Vuk Ercegovac from this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Removed reviewer Vuk Ercegovac. -- To view, visit htt

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed Vuk Ercegovac from this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Removed reviewer Vuk Ercegovac. -- To v

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11927 ) Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. Patch Set 2: Build Successful https:/

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test .. Patch Set 4: Verified+1 -- To view, v

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test .. IMPALA-7761: Add multiple DISTI

[Impala-ASF-CR] IMPALA-941: Fix support for an identifier that starts with a number

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11927 Change subject: IMPALA-941: Fix support for an identifier that starts with a number .. IMPALA-941: Fix support for an identifier that st

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11925 ) Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11925 ) Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11925 ) Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 2: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 4: Verified+1 Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11922/3/docs

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 ) Change subject: Add a handy tool to collapse threads in pstacks .. Patch Set 1: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-d

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11922 to look at the new patch set (#4). Change subject: IMPALA-7815: [DOCS] Release notes for 3.1

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11925 ) Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. Patch Set 1: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 ) Change subject: Add a handy tool to collapse threads in pstacks .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11922/3/doc

[Impala-ASF-CR] IMPALA-7841: Refactor QueryStmt, etc. for easier debugging

2018-11-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841: Refactor QueryStmt, etc. for easier debugging .. Patch Set 1: Dry-run tests passed: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-d

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 2: (2 comments) Thanks, Phil, for the review.

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#2). Change subject: IMPALA-7842: Make query fragments available for unit testing ..

[Impala-ASF-CR] IMPALA-7819: add per-node storage wait time to profile

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11894 ) Change subject: IMPALA-7819: add per-node storage wait time to profile .. IMPALA-7819: add per-node storage wait time t

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Alex Rodoni (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11922 to look at the new patch set (#3). Change subject: IMPALA-7815: [DOCS] Release notes for 3.1

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-7819: add per-node storage wait time to profile

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11894 ) Change subject: IMPALA-7819: add per-node storage wait time to profile .. Patch Set 4: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11926 Change subject: Add a handy tool to collapse threads in pstacks .. Add a handy tool to collapse threads in pstacks This commit i

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11922 ) Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-d

[Impala-ASF-CR] IMPALA-7815: [DOCS] Release notes for 3.1

2018-11-13 Thread Alex Rodoni (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11922 to look at the new patch set (#2). Change subject: IMPALA-7815: [DOCS] Release notes for 3.1 .. IMPALA-781

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 2: > Patch Set 2: > > > Patch Set 2: > > > > Build

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 2: > Patch Set 2: > > Build Failed > > https:/

[Impala-ASF-CR] IMPALA-7848: Enable ParserTest.TestAdminFns

2018-11-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11925 Change subject: IMPALA-7848: Enable ParserTest.TestAdminFns .. IMPALA-7848: Enable ParserTest.TestAdminFns This patch enables ParserTest

[Impala-ASF-CR] IMPALA-7790: Skip some Kudu tests if use hybrid clock�

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11851 ) Change subject: IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false .. Patch Set 3: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 2: Build Failed https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 10: (7 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-7790: Skip some Kudu tests if use hybrid clock�

2018-11-13 Thread Thomas Marshall (Code Review)
Hello David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11851 to look at the new patch set (#3). Change subject: IMPALA-7790: Skip some Kudu tests if use_hybrid_clock=false ...

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11599 Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots T

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 10: Verified-1 Build fail

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test .. Patch Set 4: Build started: https://je

[Impala-ASF-CR] IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11805 ) Change subject: IMPALA-7761: Add multiple DISTINCT to targeted perf and stress test .. Patch Set 4: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-7819: add per-node storage wait time to profile

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11894 ) Change subject: IMPALA-7819: add per-node storage wait time to profile .. Patch Set 4: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7819: add per-node storage wait time to profile

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11894 ) Change subject: IMPALA-7819: add per-node storage wait time to profile .. Patch Set 4: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-7819: add per-node storage wait time to profile

2018-11-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11894 ) Change subject: IMPALA-7819: add per-node storage wait time to profile .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 10: Build Successful htt

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 10: Build started: https:

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-13 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11575 to look at the new patch set (#10). Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ..