[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 5: (5 comments) Thanks for the reviews; addressed commen

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-code-review-

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1208

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 3: Code-Review+2 --

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/12086

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-19 Thread Bikramjeet Vig (Code Review)
Hello Lars Volker, Michael Brown, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12086 to look at the new patch set (#2). Change subject: Added timeout to run-all-tests

[Impala-ASF-CR] Added timeout to run-all-tests

2018-12-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12086 ) Change subject: Added timeout to run-all-tests .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/12086/1/bin/run-all-

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. IMPALA-7213: Use separate network

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Add "network_plane" as part of ConnectionId The motivation for doi

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 1: Verified by https://jenkins.impala.io/job/gerrit-verify-dryru

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Verified+1 -- To

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. IMPALA-6521: Patch gflags to have

[Impala-ASF-CR] IMPALA-7265: Add parameter to cache remote HDFS file handles

2018-12-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12111 ) Change subject: IMPALA-7265: Add parameter to cache remote HDFS file handles .. Patch Set 1: (1 comment) Thanks! Do we want to hav

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 2: (1 comment) http

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 2: (1 comment) http:

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. IMPALA-6521: Patch gflags to have

[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12110 ) Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues .. IMPALA-7994: Prevent test_ins

[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 ) Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues .. Patch Set 2: Verified+1 -- To view,

[native-toolchain-CR] IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12108 ) Change subject: IMPALA-6521: Patch gflags to have an option to show all flags including hidden flags .. Patch Set 1: Code-Review+2 (1 c

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 11: Code-Review+1 (2 comments) Looks like a test failed, t

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 11: Verified-1 Build failed: https://jenkins.impa

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Lars Volker (Code Review)
Lars Volker has removed a vote on this change. Change subject: IMPALA-7889: Write new logical types in Parquet .. Removed Code-Review+2 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/12004 To unsubs

[Impala-ASF-CR] IMPALA-7265: Add parameter to cache remote HDFS file handles

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12111 ) Change subject: IMPALA-7265: Add parameter to cache remote HDFS file handles .. Patch Set 1: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Build started: ht

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 1: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Code-Review+2 Carry Thomas'

[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services

2018-12-19 Thread Michael Ho (Code Review)
Hello Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12107 to look at the new patch set (#2). Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services ..

[Impala-ASF-CR] IMPALA-7265: Add parameter to cache remote HDFS file handles

2018-12-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12111 Change subject: IMPALA-7265: Add parameter to cache remote HDFS file handles .. IMPALA-7265: Add parameter to cache remote HDFS file han

[Impala-ASF-CR] Add "network plane" as part of ConnectionId

2018-12-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12106 ) Change subject: Add "network_plane" as part of ConnectionId .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5200: Count child time for parent's total time

2018-12-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11791 ) Change subject: IMPALA-5200: Count child time for parent's total time .. IMPALA-5200: Count child time for parent's total time

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-19 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 4: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 ) Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues .. Patch Set 1: Build Successful https

[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 ) Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues .. Patch Set 2: Code-Review+2 -- To vi

[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 ) Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues .. Patch Set 2: Build started: https://

[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues

2018-12-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12110 Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues .. IMPALA-7994: Prevent test_insert_large_string

[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues

2018-12-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 ) Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues .. Patch Set 1: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 10: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 11: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 11: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Anonymous Coward (Code Review)
Anonymous Coward (359) has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 10: Code-Review+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Anonymous Coward (359), Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12004 to look at the new patch set (#10). Change subject: IMPALA-7889: Write new logical types in Parquet ...

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 10: Code-Review+1 LGTM, thanks! -- To view, visit http:

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 8: (1 comment) Patch set 9 is only rebase + conflict r

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 9: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Anonymous Coward (359), Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12004 to look at the new patch set (#9). Change subject: IMPALA-7889: Write new logical types in Parquet

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7889: Write new logical types in Parquet

2018-12-19 Thread Anonymous Coward (Code Review)
Anonymous Coward (359) has posted comments on this change. ( http://gerrit.cloudera.org:8080/12004 ) Change subject: IMPALA-7889: Write new logical types in Parquet .. Patch Set 8: Code-Review+1 -- To view, visit http://gerri