[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

2019-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12426 ) Change subject: IMPALA-5031: signed overflow is undefined behavior .. Patch Set 1: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5031: signed overflow is undefined behavior

2019-02-09 Thread Jim Apple (Code Review)
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12426 Change subject: IMPALA-5031: signed overflow is undefined behavior .. IMPALA-5031: signed overflow is undefined behavior Tis patch fixes a

[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2019-02-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11919/1/be

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. IMPALA-5031: `uint8_t & int` type is int UBSAN finds the f

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR](2.x) IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2019-02-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12345 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-v

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. Patch Set 2: Code-Review+2 (1 comment) carry Tim's +2 http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-09 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12346 ) Change subject: IMPALA-5031: `uint8_t & int` type is int .. Patch Set 3: Code-Review+2 rebase carry Tim's +2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5031: `uint8 t & int` type is int

2019-02-09 Thread Jim Apple (Code Review)
Hello Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12346 to look at the new patch set (#2). Change subject: IMPALA-5031: `uint8_t & int` type is int ...