[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12247 to look at the new patch set (#14). Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet ..

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 13: (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 14: Build Failed https://jenkins.impal

[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh

2019-04-02 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12910 Change subject: Don't build with shared objects in bootstrap_build.sh .. Don't build with shared objects in bootstrap_build.sh Building w

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-02 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12911 Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. IMPALA-6216: Make PYTHON_EGG_CACHE configurable User can set environm

[Impala-ASF-CR] IMPALA-6216: Make PYTHON EGG CACHE configurable

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12911 ) Change subject: IMPALA-6216: Make PYTHON_EGG_CACHE configurable .. Patch Set 1: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 1: Build Failed https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 14: > Build Failed > > https://jenkins.impa

[Impala-ASF-CR](2.x) IMPALA-7211: Fix the between predicate for decimals

2019-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12902 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 14: Build Failed https://jenkins.impal

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 2: Code-Review+1 (2 comments) LGT

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 16: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRetr

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 5: (3 comments) Thanks Michael. Please see the upcoming Patch Se

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 4: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR](2.x) IMPALA-7211: Fix the between predicate for decimals

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12902 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 3: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 8: Build Successful https://jenkins.impala.io/job/gerrit-

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 14: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-7368: Add initial support for DATE type

2019-04-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 ) Change subject: IMPALA-7368: Add initial support for DATE type .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/12481/

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. IMPALA-7971: Add support for insert events in ev

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 5: (24 comments) Thanks for the co

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-04-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 8: Reviewers please wait for a future Patch Ste with a simplified

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 5: Build Successful https://jenki

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-02 Thread Bharath Krishna (Code Review)
Bharath Krishna has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 5: (5 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-02 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 5: Code-Review+1 The code here is OK. Discus

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 2: Code-Review+2 -- To view

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 2: Build started: https://je

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 2: (2 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 3: Code-Review+1 Carry +1 -- To v

[Impala-ASF-CR](2.x) IMPALA-7211: Fix the between predicate for decimals

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12902 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. IMPALA-7211: Fix the between predicate for decim

[Impala-ASF-CR](2.x) IMPALA-7211: Fix the between predicate for decimals

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12902 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 3: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12885 to look at the new patch set (#3). Change subject: IMPALA-8371: Return appropriate error code for unified backend tests ..

[Impala-ASF-CR] IMPALA-8360: Fix race conditions in thread-pool-test

2019-04-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12916 Change subject: IMPALA-8360: Fix race conditions in thread-pool-test .. IMPALA-8360: Fix race conditions in thread-pool-test There are

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-02 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12914 Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. IMPALA-8226: Add grant/revoke to/from group for Ranger This pa

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 2: (4 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-02 Thread Austin Nobis (Code Review)
Austin Nobis has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. IMPALA-8226: Add grant/revoke to/from group for Ranger This pat

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 3: Build Successful https:

[Impala-ASF-CR] IMPALA-8360: Fix race conditions in thread-pool-test

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12916 ) Change subject: IMPALA-8360: Fix race conditions in thread-pool-test .. Patch Set 1: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 2: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-8226: Add grant/revoke to/from group for Ranger

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12914 ) Change subject: IMPALA-8226: Add grant/revoke to/from group for Ranger .. Patch Set 3: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-8014: Revise FK/PK cardinality estimation

2019-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Revise FK/PK cardinality estimation .. Patch Set 5: I've been meaning to make some time to look at this.

[native-toolchain-CR] Check for thirft.protocol.fastbinary in both lib and lib64

2019-04-02 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12915 Change subject: Check for thirft.protocol.fastbinary in both lib and lib64 .. Check for thirft.protocol.fastbinary in both lib and lib64

[native-toolchain-CR] Check for thirft.protocol.fastbinary in both lib and lib64

2019-04-02 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12915 ) Change subject: Check for thirft.protocol.fastbinary in both lib and lib64 .. Check for thirft.protocol.fastbinary in both li

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 5: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 5: Build started: https://jenkins.imp

[Impala-ASF-CR] Don't build with shared objects in bootstrap build.sh

2019-04-02 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12910 ) Change subject: Don't build with shared objects in bootstrap_build.sh .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/129

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Improve error handling for vali

[Impala-ASF-CR] Improve error handling for validation of unified backend executable

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12895 ) Change subject: Improve error handling for validation of unified backend executable .. Patch Set 2: Verified+1 -- To view, v

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Patch Set 5: Verified+1 -- To view, visit http

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

2019-04-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12900 ) Change subject: Give each config change in bootstrap_system.sh its own line .. Give each config change in bootstrap_sys