[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. IMPALA-8459. LocalCatalog:

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 3: Build

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#3). Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: (1 comment) I'm

[Impala-ASF-CR] IMPALA-8599: Create a Maven module for query event hook API

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 ) Change subject: IMPALA-8599: Create a Maven module for query event hook API .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 4: Build Successful

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: Build

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: I was missing an

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: (1 comment) This

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 13: (32 comments) Mostly "dotting

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: (3 comments)

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 5: Build started:

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-14 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13463 to look at the new patch set (#4). Change subject: fe: improve logging for metadata loading

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13545 to look at the new patch set (#2). Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-8583: Add metrics for Basic auth

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13640 ) Change subject: IMPALA-8583: Add metrics for Basic auth .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8583: Add metrics for Basic auth

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13640 ) Change subject: IMPALA-8583: Add metrics for Basic auth .. IMPALA-8583: Add metrics for Basic auth The patch adds two

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13425 to look at the new patch set (#7). Change subject: IMPALA-8542. Add an access trace for the data cache

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. Patch Set 3: Ran a build locally with

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-8599: Create a Maven module for query event hook API

2019-06-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 ) Change subject: IMPALA-8599: Create a Maven module for query event hook API .. Patch Set 2: Code-Review+1 (1 comment) I'm not

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Remove "Could not transfer" exclusion in

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 22: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-14 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. IMPALA-8617: Add support for lz4 in parquet A new enum value

[Impala-ASF-CR] IMPALA-8599: Create a Maven module for query event hook API

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 ) Change subject: IMPALA-8599: Create a Maven module for query event hook API .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-8599: Create a Maven module for query event hook API

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 ) Change subject: IMPALA-8599: Create a Maven module for query event hook API .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-8599: Create a Maven module for query event hook API

2019-06-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13653 Change subject: IMPALA-8599: Create a Maven module for query event hook API .. IMPALA-8599: Create a Maven module for query event hook

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 1: (5 comments) Took another quick look in light

[Impala-ASF-CR] IMPALA-7802: Close connections of idle client sessions

2019-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13607 ) Change subject: IMPALA-7802: Close connections of idle client sessions .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-14 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 22: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8583: Add metrics for Basic auth

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13640 ) Change subject: IMPALA-8583: Add metrics for Basic auth .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-8583: Add metrics for Basic auth

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13640 ) Change subject: IMPALA-8583: Add metrics for Basic auth .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8636: Implement INSERT for insert-only ACID tables

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13559 ) Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8636: Implement INSERT for insert-only ACID tables

2019-06-14 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13559 to look at the new patch set (#5). Change subject: IMPALA-8636: Implement INSERT for insert-only ACID tables

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: > Patch Set 1: > > We could also consider

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 2: Build started:

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6590: Disable expr rewrites and codegen for VALUES() statements

2019-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13645 ) Change subject: IMPALA-6590: Disable expr rewrites and codegen for VALUES() statements .. Patch Set 1: (7 comments) The approach

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 1: (7 comments) The

[Impala-ASF-CR] IMPALA-7290: part 2: Add HS2 support to Impala shell

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 ) Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell .. Patch Set 22: Build started:

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: We could also consider removing the whole error

[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13634 ) Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase .. IMPALA-8436: Do not create

[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 ) Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] Remove "Could not transfer" exclusion in mvn-quiet.sh

2019-06-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13647 ) Change subject: Remove "Could not transfer" exclusion in mvn-quiet.sh .. Patch Set 1: Code-Review+2 Seems reasonable to me,

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13648 ) Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE

2019-06-14 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13648 Change subject: IMPALA-7369: part 2: Add INTERVAL expr support and built-in functions for DATE .. IMPALA-7369: part 2: Add INTERVAL

[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase

2019-06-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 ) Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase .. Patch Set 2: The cause of the build failure is an

[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 ) Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8436: Do not create materialized view in Kudu/HBase

2019-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13634 ) Change subject: IMPALA-8436: Do not create materialized_view in Kudu/HBase .. Patch Set 3: Build started: