[Impala-ASF-CR] IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns

2021-01-19 Thread liuyao (Code Review)
Hello Aman Sinha, Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16947 to look at the new patch set (#3). Change subject: IMPALA-10435: Extend 'compute incremental stats' synta

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 30: (10 comments) I think I'm pretty close to a

[Impala-ASF-CR] IMPALA-10434: Fix impala-shell's unicode regressions on Python2

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16960 ) Change subject: IMPALA-10434: Fix impala-shell's unicode regressions on Python2 .. Patch Set 2: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-10434: Fix impala-shell's unicode regressions on Python2

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16960 ) Change subject: IMPALA-10434: Fix impala-shell's unicode regressions on Python2 .. Patch Set 3: Build started: https://jenkins

[Impala-ASF-CR] IMPALA-10434: Fix impala-shell's unicode regressions on Python2

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16960 ) Change subject: IMPALA-10434: Fix impala-shell's unicode regressions on Python2 .. Patch Set 3: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-10434: Fix impala-shell's unicode regressions on Python2

2021-01-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16960 ) Change subject: IMPALA-10434: Fix impala-shell's unicode regressions on Python2 .. Patch Set 2: Code-Review+2 (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-10434: Fix impala-shell's unicode regressions on Python2

2021-01-19 Thread Quanlong Huang (Code Review)
Hello Laszlo Gaal, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16960 to look at the new patch set (#2). Change subject: IMPALA-10434: Fix impala-shell's unicode regressions on Python2

[Impala-ASF-CR] IMPALA-10259: Fixed DCHECK error for backend in terminal state

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16900 ) Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state .. Patch Set 4: Verified+1 -- To view, visit h

[Impala-ASF-CR] IMPALA-10259: Fixed DCHECK error for backend in terminal state

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16900 ) Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state .. IMPALA-10259: Fixed DCHECK error for

[Impala-ASF-CR] IMPALA-10434: Fix impala-shell's unicode regressions on Python2

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16960 ) Change subject: IMPALA-10434: Fix impala-shell's unicode regressions on Python2 .. Patch Set 1: Code-Review+2 (1 comment) http://gerr

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 15: Build Failed https://jenkins.impala.io/job/gerrit-code-r

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 14: Build Failed https://jenkins.impala.io/job/gerrit-code-r

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 15: (11 comments) Sorry for the many small patchsets, I missed som

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 15: (26 comments) http://gerrit.cloudera.org:8080/#/c/16833/

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#15). Change subject: [WiP] SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10421: [DOCS] Documented the JOIN ROWS PRODUCED LIMIT query option

2021-01-19 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16922 ) Change subject: IMPALA-10421: [DOCS] Documented the JOIN_ROWS_PRODUCED_LIMIT query option .. Patch Set 2: Code-Review+1 Doing a +1 and a

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 13: Build Failed https://jenkins.impala.io/job/gerrit-code-r

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 12: Build Failed https://jenkins.impala.io/job/gerrit-code-r

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 14: (26 comments) http://gerrit.cloudera.org:8080/#/c/16833/

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#14). Change subject: [WiP] SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16947 ) Change subject: IMPALA-10435: Extend 'compute incremental stats' syntax to support a list of columns .. Patch Set 2: How does this wo

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 13: (27 comments) http://gerrit.cloudera.org:8080/#/c/16833/

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#13). Change subject: [WiP] SAML implementation in Impala ..

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 12: (27 comments) http://gerrit.cloudera.org:8080/#/c/16833/

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-01-19 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#12). Change subject: [WiP] SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10259: Fixed DCHECK error for backend in terminal state

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16900 ) Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state .. Patch Set 4: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-10259: Fixed DCHECK error for backend in terminal state

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16900 ) Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state .. Patch Set 4: Build started: https://jenkins.

[Impala-ASF-CR] IMPALA-10259: Fixed DCHECK error for backend in terminal state

2021-01-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16900 ) Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state .. Patch Set 3: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16942 ) Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present .. Patch Set 14: Build Successful http

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16942 ) Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present .. Patch Set 11: (11 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-10296: Fix analytic limit pushdown when predicates are present

2021-01-19 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16942 to look at the new patch set (#14). Change subject: IMPALA-10296: Fix analytic limit pushdown when predicates are present

[Impala-ASF-CR] IMPALA-10259: Fixed DCHECK error for backend in terminal state

2021-01-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16900 ) Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-10259: Fixed DCHECK error for backend in terminal state

2021-01-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16900 ) Change subject: IMPALA-10259: Fixed DCHECK error for backend in terminal state .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. Patch Set 4: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. IMPALA-9224 (part 1): Blacklist nodes with faulty disks This pa

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch S

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. Patch Set 1: Build Failed https://jenkins.im

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-19 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 27: (18 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-19 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#49). ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. IMPALA-10325: Parqu

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-19 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16963 Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. IMPALA-10147: Avoid getting a file handle for data cache

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 30: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-01-19 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#30). ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. IMPALA-9867: Add Support for Spilling to S3: Milestone 1 Major Fe