[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17011 ) Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441 .. IMPALA-10459: Remove workarounds for MAPREDUCE-6

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 ) Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441 .. Patch Set 3: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17023 ) Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch S

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch S

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-04 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#60). ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. IMPALA-10325: Parqu

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17023 ) Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17023 ) Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. Patch Set 3: Build Successfu

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17023 ) Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. Patch Set 2: (5 comments) Thanks f

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Quanlong Huang (Code Review)
Hello Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17023 to look at the new patch set (#3). Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 2: Code-Review+2 This looks good to me -- To view, visit ht

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 17: Build Failed https://jenkins.impala.io/job/gerrit-code-r

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 17: (7 comments) http://gerrit.cloudera.org:8080/#/c/16833/15/be/s

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 17: (20 comments) http://gerrit.cloudera.org:8080/#/c/16833/

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-04 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#17). Change subject: [WiP] SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 2: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 16: (20 comments) http://gerrit.cloudera.org:8080/#/c/16833/

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 ) Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441 .. Patch Set 3: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 ) Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441 .. Patch Set 3: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 16: Build Failed https://jenkins.impala.io/job/gerrit-code-r

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-04 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#16). Change subject: [WiP] SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/17015/1/

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17015 to look at the new patch set (#2). Change subject: IMPALA-10389: impala-profile-tool container .

[Impala-ASF-CR] IMPALA-8545 (part 2): Add tests for JDBC + LDAP + SSL

2021-02-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/13338 ) Change subject: IMPALA-8545 (part 2): Add tests for JDBC + LDAP + SSL .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13

[Impala-ASF-CR] IMPALA-10459: Remove workarounds for MAPREDUCE-6441

2021-02-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17011 ) Change subject: IMPALA-10459: Remove workarounds for MAPREDUCE-6441 .. Patch Set 2: Code-Review+2 This makes sense to me, thanks for t

[Impala-ASF-CR] IMPALA-10389: impala-profile-tool container

2021-02-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17015 ) Change subject: IMPALA-10389: impala-profile-tool container .. Patch Set 1: (4 comments) Overall, this makes sense to me. http://ger

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-04 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: > Patch Set 30: Code-Review+1 > > BE part and tests look good to

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17023 ) Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. Patch Set 2: (5 comments) Code changes

[Impala-ASF-CR] IMPALA-10274: Initialize impala-python as part of the CMake build

2021-02-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16607 ) Change subject: IMPALA-10274: Initialize impala-python as part of the CMake build .. IMPALA-10274: Initialize impala-python as

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 3: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 3: (3 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17012 to look at the new patch set (#3). Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables ..

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 2: Code-Review+1 (3 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-10274: Initialize impala-python as part of the CMake build

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16607 ) Change subject: IMPALA-10274: Initialize impala-python as part of the CMake build .. Patch Set 5: Verified+1 -- To view, vis

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17023 ) Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. Patch Set 2: Build Successfu

[Impala-ASF-CR] IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables

2021-02-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17012 ) Change subject: IMPALA-10223: Implement INSERT OVERWRITE for Iceberg tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17023 ) Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. Patch Set 1: Build Successfu

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17023 to look at the new patch set (#2). Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .

[Impala-ASF-CR] IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs

2021-02-04 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17023 Change subject: IMPALA-10473: Fix wrong analytic results on constant partition/order by exprs .. IMPALA-10473: Fix wrong analytic resu