[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-21 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 9: Build Successful https://jen

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 3: Code-Review+1 This makes se

[Impala-ASF-CR] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-04-21 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/17295 ) Change subject: IMPALA-10650: Bailout min/max filters in hash join builder early .. IMPALA-10650: Bailout min/max filters in hash join build

[Impala-ASF-CR] IMPALA-10669: Limit memory during dataload in Docker-based tests

2021-04-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17331 ) Change subject: IMPALA-10669: Limit memory during dataload in Docker-based tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-21 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 6: Code-Review+1 Looks good! -- To vi

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table cache for HMS DDL apis which modify tables and partitions.

2021-04-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table cache for HMS DDL apis which modify tables and partitions. .. Patch Set

[Impala-ASF-CR] IMPALA-10669: Limit memory during dataload in Docker-based tests

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17331 ) Change subject: IMPALA-10669: Limit memory during dataload in Docker-based tests .. Patch Set 1: Build Successful https://jen

[Impala-ASF-CR] IMPALA-10669: Limit memory during dataload in Docker-based tests

2021-04-21 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17331 ) Change subject: IMPALA-10669: Limit memory during dataload in Docker-based tests .. Patch Set 1: Ran this on an m5.12xlarge with three d

[Impala-ASF-CR] IMPALA-10669: Limit memory during dataload in Docker-based tests

2021-04-21 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17331 Change subject: IMPALA-10669: Limit memory during dataload in Docker-based tests .. IMPALA-10669: Limit memory during dataload in Docker-b

[Impala-ASF-CR] IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17330 ) Change subject: IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata .. Patch Set 1: Build started: http

[Impala-ASF-CR] IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata

2021-04-21 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17330 ) Change subject: IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata .. Patch Set 1: Code-Review+2 -- To view, vis

[Impala-ASF-CR] IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata

2021-04-21 Thread Anonymous Coward (Code Review)
Anonymous Coward (646) has posted comments on this change. ( http://gerrit.cloudera.org:8080/17330 ) Change subject: IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata .. Patch Set 1: Code-Review+1 --

[Impala-ASF-CR] IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17330 ) Change subject: IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata .. Patch Set 1: Build Successful h

[Impala-ASF-CR] IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata

2021-04-21 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17330 Change subject: IMPALA-10613: (Addendum) Change isSetGetFileMetadata to isGetFileMetadata .. IMPALA-10613: (Addendum) Change isSe

[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types

2021-04-21 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types .. Patch Set 27: The problem seems to be with

[Impala-ASF-CR] IMPALA-7825: Upgrade Thrift version to 0.11.0

2021-04-21 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 ) Change subject: IMPALA-7825: Upgrade Thrift version to 0.11.0 .. Patch Set 13: Code-Review+1 (4 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-21 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row

2021-04-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17324 ) Change subject: IMPALA-10611: Fix flakiness in test_wide_row .. Patch Set 1: Code-Review+2 I'm OK with this fix but maybe we shoul

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 3: Build Successful h

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-21 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 ) Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS .. Patch Set 3: (1 comment) http://ger

[Impala-ASF-CR] IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS

2021-04-21 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17316 to look at the new patch set (#3). Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS ..

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 17: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query optio