Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 )
Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode ...................................................................... Patch Set 4: Code-Review+2 (1 comment) I did another pass and this lgtm. For the writeId, I am ok to defer that to another patch (if the investigation shows further optimization can be done). http://gerrit.cloudera.org:8080/#/c/17505/3/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/17505/3/common/thrift/CatalogObjects.thrift@325 PS3, Line 325: // These are Literal expressions > I think we keep the conversion that when removing thrift fields, only comme Yes, since this is an internal structure only used between catalogd and coordinator, it should be ok to remove them. -- To view, visit http://gerrit.cloudera.org:8080/17505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I307e7a8193b54a7b3ab93d9ebd194766bbdbd977 Gerrit-Change-Number: 17505 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Sun, 30 May 2021 06:54:21 +0000 Gerrit-HasComments: Yes
