[Impala-ASF-CR] IMPALA-10677: Set selectivity of Not-equal

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17344 ) Change subject: IMPALA-10677: Set selectivity of Not-equal .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis .. Patch Set 21: Build failed:

[Impala-ASF-CR] IMPALA-10677: Set selectivity of Not-equal

2021-06-03 Thread liuyao (Code Review)
liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17344 ) Change subject: IMPALA-10677: Set selectivity of Not-equal .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10677: Set selectivity of Not-equal

2021-06-03 Thread liuyao (Code Review)
liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17344 ) Change subject: IMPALA-10677: Set selectivity of Not-equal .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-10677: Set selectivity of Not-equal

2021-06-03 Thread liuyao (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17344 to look at the new patch set (#4). Change subject: IMPALA-10677: Set selectivity of Not-equal

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 8: LocalIcebergTable doesn't populate

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Quanlong Huang (Code Review)
Hello Aman Sinha, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17505 to look at the new patch set (#8). Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis .. Patch Set 21: Build started:

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

2021-06-03 Thread Sourabh Goyal (Code Review)
Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis .. Patch Set 21: The failure does not seem

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 7: Build failed:

[Impala-ASF-CR] IMPALA-10677: Set selectivity of Not-equal

2021-06-03 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17344 ) Change subject: IMPALA-10677: Set selectivity of Not-equal .. Patch Set 3: Code-Review+1 (3 comments) Looks great!

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-06-03 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 6: (4 comments) It is great

[Impala-ASF-CR] IMPALA-10709: Min/max filters should be enabled for joins on sorted columns in Parquet tables

2021-06-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17478 ) Change subject: IMPALA-10709: Min/max filters should be enabled for joins on sorted columns in Parquet tables .. Patch Set 30:

[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES

2021-06-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 ) Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES .. Patch Set 2: (15 comments) The

[Impala-ASF-CR] IMPALA-10709: Min/max filters should be enabled for joins on sorted columns in Parquet tables

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17478 ) Change subject: IMPALA-10709: Min/max filters should be enabled for joins on sorted columns in Parquet tables .. Patch Set

[Impala-ASF-CR] IMPALA-10689: Implement ds cpc union f() function.

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17440 ) Change subject: IMPALA-10689: Implement ds_cpc_union_f() function. .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. IMPALA-7556: Decouple

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 11: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10709: Min/max filters should be enabled for joins on sorted columns in Parquet tables

2021-06-03 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#30). ( http://gerrit.cloudera.org:8080/17478 ) Change subject: IMPALA-10709: Min/max filters should be enabled for joins on sorted columns in Parquet tables .. IMPALA-10709: Min/max

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 7: > Patch Set 7: Verified-1 > > Build

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis .. Patch Set 21: Verified-1 Build

[Impala-ASF-CR] IMPALA-10680: Replace StringToFloatInternal using fast double parser library

2021-06-03 Thread Amogh Margoor (Code Review)
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 ) Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library .. Patch Set 6: > I think it would be

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 11: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr

2021-06-03 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17413 ) Change subject: IMPALA-7556: Decouple BufferManagement from the ScanRange and IoMgr .. Patch Set 10: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10689: Implement ds cpc union f() function.

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17440 ) Change subject: IMPALA-10689: Implement ds_cpc_union_f() function. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10689: Implement ds cpc union f() function.

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17440 ) Change subject: IMPALA-10689: Implement ds_cpc_union_f() function. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10689: Implement ds cpc union f() function.

2021-06-03 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17440 ) Change subject: IMPALA-10689: Implement ds_cpc_union_f() function. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10724: Add mutable validWriteIdList

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17538 ) Change subject: IMPALA-10724: Add mutable validWriteIdList .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7501: Slim down partition metadata in LocalCatalog mode

2021-06-03 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17505 ) Change subject: IMPALA-7501: Slim down partition metadata in LocalCatalog mode .. Patch Set 6: (1 comment) Thank Aman and Vihang!

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis .. Patch Set 21: Build Successful

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

2021-06-03 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 ) Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis .. Patch Set 21: Build started:

[Impala-ASF-CR] IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

2021-06-03 Thread Sourabh Goyal (Code Review)
Hello Quanlong Huang, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17298 to look at the new patch set (#21). Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis

[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types

2021-06-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types .. IMPALA-10640: Support reading

[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types

2021-06-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types .. Patch Set 40: Submitting manually. --

[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types

2021-06-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types .. Patch Set 40: Verified+1 Code-Review+2

[Impala-ASF-CR] IMPALA-10640: Support reading Parquet Bloom filters - most common types

2021-06-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 ) Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types .. Patch Set 39: The only failed test is