[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: Code-Review+1 (3 comments) lgtm I have some

[Impala-ASF-CR] IMPALA-10956: datasketches UDFs: memory leak and merge overhead

2021-10-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17869 ) Change subject: IMPALA-10956: datasketches UDFs: memory leak and merge overhead .. Patch Set 3: (2 comments) lgtm in general, I wil

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-29 Thread Sourabh Goyal (Code Review)
Hello Vihang Karajgaonkar, kis...@cloudera.com, Yu-Wen Lai, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17859 to look at the new patch set (#24). Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints ...

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints ...

[Impala-ASF-CR] IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations

2021-10-29 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17933 ) Change subject: IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations .. Patch Set 10: My own jenkins job

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-29 Thread Sourabh Goyal (Code Review)
Hello Vihang Karajgaonkar, kis...@cloudera.com, Yu-Wen Lai, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17859 to look at the new patch set (#25). Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints ...

[Impala-ASF-CR] IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations

2021-10-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17933 ) Change subject: IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations .. IMPALA-10836: Add

[Impala-ASF-CR] IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations

2021-10-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17933 ) Change subject: IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations .. Patch Set 10: Code-Review

[Impala-ASF-CR] IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations

2021-10-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17933 ) Change subject: IMPALA-10836: Add 'SimplifyCastExprRule' rule to rewrite cast expr in some situations .. Patch Set 11: Thanks for

[Impala-ASF-CR] IMPALA-10995: Allow remote submit time to be in the past

2021-10-29 Thread Kurt Deschler (Code Review)
Kurt Deschler has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17985 Change subject: IMPALA-10995: Allow remote submit time to be in the past .. IMPALA-10995: Allow remote submit time to be in the past Th

[Impala-ASF-CR] IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17859 ) Change subject: IMPALA-10926: Sync db/table in catalog cache to latest HMS event id when performing DDL operations via catalog HMS endpoints ...

[Impala-ASF-CR] IMPALA-10995: Allow remote submit time to be in the past

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17985 ) Change subject: IMPALA-10995: Allow remote submit time to be in the past .. Patch Set 1: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-10791 Add batching reading for remote temporary files

2021-10-29 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17979 ) Change subject: IMPALA-10791 Add batching reading for remote temporary files .. Patch Set 3: (16 comments) Looks great and thanks a lot

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (12 comments) Just have some very minor comments.

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#

[native-toolchain-CR] IMPALA-10931 (part 1): Upgrade library protobuf for toolchain

2021-10-29 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17946 Change subject: IMPALA-10931 (part 1): Upgrade library protobuf for toolchain .. IMPALA-10931 (part 1): Upgrade library protobuf for toolc

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (4 comments) Thank you everyone for the feedbac

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (1 comment) Thanks for the quick answer of my que

[Impala-ASF-CR] IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables

2021-10-29 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17858 ) Change subject: IMPALA-10923: Fine grained table refreshing at partition level events for transactional tables .. Patch Set 11:

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 1: Code-Review+2 LGTM

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Bikramjeet Vig (Code Review)
Hello Andrew Sherman, Abhishek Rawat, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17891 to look at the new patch set (#2). Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 2: Code-Review+2 (4 c

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 3: Build start

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 3: Code-Review+

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 2: Build Succe

[Impala-ASF-CR] IMPALA-10995: Allow remote submit time to be in the past

2021-10-29 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17985 ) Change subject: IMPALA-10995: Allow remote submit time to be in the past .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-10943: Add test to verify support for multiple resource and executor pools

2021-10-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17891 ) Change subject: IMPALA-10943: Add test to verify support for multiple resource and executor pools .. Patch Set 3: Verified-1