[Impala-ASF-CR] IMPALA-10865: Fix initialize SelectStmt's groupingExprs in analyzeGroupingExprs

2022-05-11 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17781 ) Change subject: IMPALA-10865: Fix initialize SelectStmt's groupingExprs_ in analyzeGroupingExprs .. Patch Set 5: Failed because of IMPAL

[Impala-ASF-CR] IMPALA-10865: Fix initialize SelectStmt's groupingExprs in analyzeGroupingExprs

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17781 ) Change subject: IMPALA-10865: Fix initialize SelectStmt's groupingExprs_ in analyzeGroupingExprs .. Patch Set 5: Build starte

[Impala-ASF-CR] IMPALA-11275: log thread info during minidump

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18508 ) Change subject: IMPALA-11275: log thread info during minidump .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.clou

[native-toolchain-CR] IMPALA-10199: Add a toolchain build for Ubuntu 20

2022-05-11 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18505 ) Change subject: IMPALA-10199: Add a toolchain build for Ubuntu 20 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-11275: log thread info during minidump

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18508 ) Change subject: IMPALA-11275: log thread info during minidump .. Patch Set 3: Build Successful https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-11275: log thread info during minidump

2022-05-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18508 ) Change subject: IMPALA-11275: log thread info during minidump .. Patch Set 3: (2 comments) Addressed comments and added tests. http:

[Impala-ASF-CR] IMPALA-11275: log thread info during minidump

2022-05-11 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18508 to look at the new patch set (#3). Change subject: IMPALA-11275: log thread info during minidump ...

[Impala-ASF-CR] IMPALA-11275: log thread info during minidump

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18508 ) Change subject: IMPALA-11275: log thread info during minidump .. Patch Set 3: Build started: https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-10436: Require lower privilege for external Kudu table creation

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 ) Change subject: IMPALA-10436: Require lower privilege for external Kudu table creation .. Patch Set 6: Build Successful http

[Impala-ASF-CR] IMPALA-10436: Require lower privilege for external Kudu table creation

2022-05-11 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17640 ) Change subject: IMPALA-10436: Require lower privilege for external Kudu table creation .. IMPALA-10436: Require lower privilege for extern

[Impala-ASF-CR] [tools] fix set-classpath for other POSIX shells

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18519 ) Change subject: [tools] fix set-classpath for other POSIX shells .. Patch Set 1: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. Patch Set 6: Verified-1 Build failed: https://jenkins

[Impala-ASF-CR] [tools] fix set-classpath for other POSIX shells

2022-05-11 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18519 Change subject: [tools] fix set-classpath for other POSIX shells .. [tools] fix set-classpath for other POSIX shells Updates comparison

[Impala-ASF-CR] refactor DumpCallback to make it more readable

2022-05-11 Thread Michael Smith (Code Review)
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/18507 ) Change subject: refactor DumpCallback to make it more readable .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18507 To unsubscri

[Impala-ASF-CR] refactor DumpCallback to make it more readable

2022-05-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18507 ) Change subject: refactor DumpCallback to make it more readable .. Patch Set 1: I'll fold it into the other change then. I think I'll p

[native-toolchain-CR] IMPALA-10199: Add a toolchain build for Ubuntu 20

2022-05-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18505 ) Change subject: IMPALA-10199: Add a toolchain build for Ubuntu 20 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 3: Verified-1 Build

[Impala-ASF-CR] IMPALA-10436: Require lower privilege for external Kudu table creation

2022-05-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 ) Change subject: IMPALA-10436: Require lower privilege for external Kudu table creation .. Patch Set 5: (4 comments) Some high leve

[Impala-ASF-CR] POC: Changing AVRO dependency Apache 0.11.0

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18502 ) Change subject: POC: Changing AVRO dependency Apache 0.11.0 .. Patch Set 3: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18517 ) Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. Patch Set 1: Build Successf

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. Patch Set 5: Code-Review+2 LGTM! Great work! -- To view

[Impala-ASF-CR] POC: Changing AVRO dependency Apache 0.11.0

2022-05-11 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18502 to look at the new patch set (#3). Change subject: POC: Changing AVRO dependency Apache 0.11.0 .. POC: Cha

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. Patch Set 6: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. Patch Set 6: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables

2022-05-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18517 Change subject: IMPALA-11287 (part 1): Disable CREATE TABLE LIKE statements for Iceberg tables .. IMPALA-11287 (part 1): Disable CR

[Impala-ASF-CR] IMPALA-11275: write thread info to log during minidump

2022-05-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18508 ) Change subject: IMPALA-11275: write thread info to log during minidump .. Patch Set 1: (2 comments) Couple initial comments http://g

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. Patch Set 5: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. IMPALA-11286: Writes value_counts to Iceberg metadata

[Impala-ASF-CR] IMPALA-11162: Support GenericUDFs for Hive

2022-05-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18295 ) Change subject: IMPALA-11162: Support GenericUDFs for Hive .. IMPALA-11162: Support GenericUDFs for Hive Hive has 2 types of

[Impala-ASF-CR] IMPALA-10865: Fix initialize SelectStmt's groupingExprs in analyzeGroupingExprs

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17781 ) Change subject: IMPALA-10865: Fix initialize SelectStmt's groupingExprs_ in analyzeGroupingExprs .. Patch Set 5: Verified-1 B

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. Patch Set 3: (1 comment) Thanks for working on this! ht

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-05-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Tamas Mate, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18514 to look at the new patch set (#3). Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-05-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Quanlong Huang, Tamas Mate, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18514 to look at the new patch set (#2). Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name

[Impala-ASF-CR] IMPALA-801, IMPALA-8011: Add INPUT FILE NAME virtual column for file name

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18514 ) Change subject: IMPALA-801, IMPALA-8011: Add INPUT__FILE__NAME virtual column for file name .. Patch Set 3: Build started: ht

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 12: Build

[Impala-ASF-CR] IMPALA-10865: Fix initialize SelectStmt's groupingExprs in analyzeGroupingExprs

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17781 ) Change subject: IMPALA-10865: Fix initialize SelectStmt's groupingExprs_ in analyzeGroupingExprs .. Patch Set 5: Build starte

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-11 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. Patch Set 12: (7

[Impala-ASF-CR] IMPALA-11205: Implement Statistical functions : CORR(), COVAR SAMP() and COVAR POP()

2022-05-11 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/18413 ) Change subject: IMPALA-11205: Implement Statistical functions : CORR(), COVAR_SAMP() and COVAR_POP() .. IMPALA-11205: Impl

[Impala-ASF-CR] IMPALA-11286: Writes value counts to Iceberg metadata

2022-05-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18513 ) Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata .. Patch Set 3: Build Successful https://jenkins.impala