[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. IMPALA-11505: Fix flaky test test_ku

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. Patch Set 2: Build Successful https://jenk

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. Patch Set 2: Build started: https://jenkins

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. Patch Set 2: Code-Review+2 Thanks, that makes sense

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. IMPALA-11505: Fix flaky test test_kudu_txn_abort_partiti

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-11505: Fix flaky test test kudu txn abort partition lock

2022-08-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18911 ) Change subject: IMPALA-11505: Fix flaky test test_kudu_txn_abort_partition_lock .. Patch Set 1: (1 comment) This makes sense. I have

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-08-26 Thread Omid Shahidi (Code Review)
Omid Shahidi has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 13: > Patch Set 13: > > (2 comments) I will investigate the mem

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11226: Add script to simplify resolving minidumps

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18918 ) Change subject: IMPALA-11226: Add script to simplify resolving minidumps .. Patch Set 1: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-11226: Add script to simplify resolving minidumps

2022-08-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18918 Change subject: IMPALA-11226: Add script to simplify resolving minidumps .. IMPALA-11226: Add script to simplify resolving minidumps Th

[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries

2022-08-26 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 ) Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries .. Patch Set 2: Thanks for putting thi

[Impala-ASF-CR] IMPALA-11507: Use absolute path when Iceberg data files outside of the table location

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18894 ) Change subject: IMPALA-11507: Use absolute_path when Iceberg data files outside of the table location .. Patch Set 4: Verified

[Impala-ASF-CR] IMPALA-11529: FILE POSITION virtual column for ORC tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 ) Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables .. Patch Set 2: (3 comments) Looks good! http://gerri

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: Build Successful https:

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 6: Build Successful https:

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: PS7 is only a rebase. -- T

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#7). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: Build started: https://j

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 7: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (21 comments) Thanks for th

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18847 to look at the new patch set (#6). Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 positi

[Impala-ASF-CR] IMPALA-9499: Display support for all complex types in a SELECT * query

2022-08-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18863 ) Change subject: IMPALA-9499: Display support for all complex types in a SELECT * query .. Patch Set 5: (15 comments) Thanks! http:/

[Impala-ASF-CR] IMPALA-9499: Display support for all complex types in a SELECT * query

2022-08-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18863 ) Change subject: IMPALA-9499: Display support for all complex types in a SELECT * query .. Patch Set 5: (3 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (3 comments) http://gerrit.clouder

[Impala-ASF-CR](branch-4.1.1) IMPALA-11464: Skip listing staging dirs to avoid failures on them

2022-08-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18915 ) Change subject: IMPALA-11464: Skip listing staging dirs to avoid failures on them .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](branch-4.1.1) IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs

2022-08-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18916 ) Change subject: IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs .. Patch Set 1: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-11507: Use absolute path when Iceberg data files outside of the table location

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18894 ) Change subject: IMPALA-11507: Use absolute_path when Iceberg data files outside of the table location .. Patch Set 4: Build s

[Impala-ASF-CR] IMPALA-11507: Use absolute path when Iceberg data files outside of the table location

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18894 ) Change subject: IMPALA-11507: Use absolute_path when Iceberg data files outside of the table location .. Patch Set 4: Build S

[Impala-ASF-CR] IMPALA-11507: Use absolute path when Iceberg data files outside of the table location

2022-08-26 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18894 Change subject: IMPALA-11507: Use absolute_path when Iceberg data files outside of the table location .. IMPALA-11507: Use a

[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries

2022-08-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 ) Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries .. Patch Set 2: Code-Review+1 lgtm,

[Impala-ASF-CR] IMPALA-9499: Display support for all complex types in a SELECT * query

2022-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18863 ) Change subject: IMPALA-9499: Display support for all complex types in a SELECT * query .. Patch Set 5: Build Successful http

[Impala-ASF-CR] IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables

2022-08-26 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 ) Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables .. Patch Set 5: (17 comments) Great change! Added

[Impala-ASF-CR] IMPALA-9499: Display support for all complex types in a SELECT * query

2022-08-26 Thread Peter Rozsa (Code Review)
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18863 to look at the new patch set (#5). Change subject: IMPALA-9499: Display support for all complex types in a SELECT * query

[Impala-ASF-CR] IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries

2022-08-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 ) Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries .. Patch Set 2: Code-Review+1 Looks go