[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch S

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch Set

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch S

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ..

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ..

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-08 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 3: Got it! Thanks for your explanation.

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 10: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 10: Build started: https

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 9: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 9: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch S

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch Set

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 13: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#3). Change subject: IMPALA-11780: Wrong FILE__POSITION values for mul

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#4). Change subject: IMPALA-11780: Wrong FILE__POSITION values for mul

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch S

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#6). Change subject: IMPALA-11780: Wrong FILE__POSITION values for mul

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#7). Change subject: IMPALA-11780: Wrong FILE__POSITION values for mul

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch S

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch S

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, lipeng...@sensorsdata.cn, Gergely Fürnstáhl, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19328 to look at the new patch set (#8). Change subject: IMPALA-11780: Wrong FILE__POSITION values for mul

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-08 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. IMPALA-11717: Use rapidjson for printing collections We have bee

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch S

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Patch Set

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-11717: Use rapidjson for printing collections

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19309 ) Change subject: IMPALA-11717: Use rapidjson for printing collections .. Patch Set 4: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-08 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list Currently

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-08 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. IMPALA-9551: Allow mixed complex types in select list Currently

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 3: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-9551: Allow mixed complex types in select list

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19322 ) Change subject: IMPALA-9551: Allow mixed complex types in select list .. Patch Set 4: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-12-08 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. IMPALA-11730: Add support for spilling to Ozone Adds suppor

[Impala-ASF-CR] IMPALA-10871: (Addendum) use variable substitution for Hive 3 profile

2022-12-08 Thread Michael Smith (Code Review)
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/19313 ) Change subject: IMPALA-10871: (Addendum) use variable substitution for Hive 3 profile .. Abandoned Code probably needs to get cleaned up, but

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. Patch Set 10: Verified+1 -- To vi

[Impala-ASF-CR] IMPALA-11549: Support Hive GenericUdfs that return primitive java types

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19304 ) Change subject: IMPALA-11549: Support Hive GenericUdfs that return primitive java types .. IMPALA-11549: Support Hive

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-12-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19330 ) Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19330 ) Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19330 Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. IMPALA-11751: (Addendum) fix test for Ozone Use FILESYSTEM_PREFIX to mak

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19330 to look at the new patch set (#2). Change subject: IMPALA-11751: (Addendum) fix test for Ozone .

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19330 ) Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. Patch Set 2: Code-Review+2 Thanks for fixing this! -- To view, vi

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19330 ) Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. Patch Set 1: Build Successful https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 13: Verified-1 Build failed: https://

[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19331 Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498 .. IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498 With

[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 ) Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498 .. Patch Set 1: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used .. Pat

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19330 ) Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-11751: (Addendum) fix test for Ozone

2022-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19330 ) Change subject: IMPALA-11751: (Addendum) fix test for Ozone .. IMPALA-11751: (Addendum) fix test for Ozone Use FILESYS

[Impala-ASF-CR] IMPALA-11780: Wrong FILE POSITION values for multi row group Parquet files when page filtering is used

2022-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19328 ) Change subject: IMPALA-11780: Wrong FILE__POSITION values for multi row group Parquet files when page filtering is used ..