[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-20 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 3: (2 comments) H

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-20 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19373 to look at the new patch set (#3). Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in

[Impala-ASF-CR] IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19373 ) Change subject: IMPALA-10399, IMPALA-11060, IMPALA-11788: Reset Ranger policy repository in an E2E test .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-11786: Preserve memory for codegen cache

2022-12-20 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 ) Change subject: IMPALA-11786: Preserve memory for codegen cache .. Patch Set 2: (6 comments) Thanks Qifan and Michael. I think the change c

[Impala-ASF-CR] IMPALA-11786: Preserve memory for codegen cache

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 ) Change subject: IMPALA-11786: Preserve memory for codegen cache .. Patch Set 2: Build Successful https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-11786: Preserve memory for codegen cache

2022-12-20 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19377 ) Change subject: IMPALA-11786: Preserve memory for codegen cache .. IMPALA-11786: Preserve memory for codegen cache IMPALA-11470 adds support f

[Impala-ASF-CR] IMPALA-11713: Switch to C++17

2022-12-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19183 ) Change subject: IMPALA-11713: Switch to C++17 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19183/4/be/CMakeLists.t

[Impala-ASF-CR] IMPALA-11713: Switch to C++17

2022-12-20 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19183 ) Change subject: IMPALA-11713: Switch to C++17 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19183/4/be/CMakeLists.t

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 2: Build Failed https://jenkins.impala

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2022-12-20 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. WIP IMPALA-11809: Support non unique primary key for Kudu Kud

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 1: Build Failed https://jenkins.impala

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2022-12-20 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19383 Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. WIP IMPALA-11809: Support non unique primary key for Kudu Ku

[Impala-ASF-CR] WIP IMPALA-11809: Support non unique primary key for Kudu

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: WIP IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 1: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 2: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Andrew Sherman (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19380 to look at the new patch set (#2). Change subject: IMPALA-10893: Use old schema during iceberg time travel. ...

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19381 ) Change subject: IMPALA-10803: Change default cache eviction policy to LIRS .. Patch Set 1: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

2022-12-20 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19381 ) Change subject: IMPALA-10803: Change default cache eviction policy to LIRS .. Patch Set 1: What have you done to evaluate the performa

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

2022-12-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19381 Change subject: IMPALA-10803: Change default cache eviction policy to LIRS .. IMPALA-10803: Change default cache eviction policy to LIRS

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 1: Build Successful https://jenkins.imp

[Impala-ASF-CR] IMPALA-11713: Switch to C++17

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19183 ) Change subject: IMPALA-11713: Switch to C++17 .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-revi

[Impala-ASF-CR] IMPALA-11713: Switch to C++17

2022-12-20 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19183 ) Change subject: IMPALA-11713: Switch to C++17 .. Patch Set 4: Code-Review+1 lgtm -- To view, visit http://gerrit.cloudera.org:8080/1

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19380 Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. IMPALA-10893: Use old schema during iceberg time travel. B

[Impala-ASF-CR] IMPALA-10893: Use old schema during iceberg time travel.

2022-12-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19380 ) Change subject: IMPALA-10893: Use old schema during iceberg time travel. .. Patch Set 1: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-11713: Switch to C++17

2022-12-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19183 Change subject: IMPALA-11713: Switch to C++17 .. IMPALA-11713: Switch to C++17 This switches from C++14 to C++17, which allows Impala c

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2022-12-20 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7942 (part 1): Add query hints for table cardinalities

2022-12-20 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18829 ) Change subject: IMPALA-7942 (part 1): Add query hints for table cardinalities .. Patch Set 9: Code-Review+1 Hi Wangsheng, Sure. To separ

[Impala-ASF-CR] IMPALA-11786: Preserve memory for codegen cache

2022-12-20 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 ) Change subject: IMPALA-11786: Preserve memory for codegen cache .. Patch Set 1: (6 comments) Looks good to me! http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7942 (part 1): Add query hints for table cardinalities

2022-12-20 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18829 ) Change subject: IMPALA-7942 (part 1): Add query hints for table cardinalities .. Patch Set 9: > (1 comment) Hi Qifan, sorry for taking so

[Impala-ASF-CR] IMPALA:11808: Added support for reload event in catalogD

2022-12-20 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19378 ) Change subject: IMPALA:11808: Added support for reload event in catalogD .. Patch Set 2: (20 comments) The solution looks good to me

[Impala-ASF-CR] IMPALA-11626: Handled COMMIT COMPACTION EVENT from HMS

2022-12-20 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19155 ) Change subject: IMPALA-11626: Handled COMMIT_COMPACTION_EVENT from HMS .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080