Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 )
Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits ...................................................................... Patch Set 1: (4 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/20379/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20379/1//COMMIT_MSG@11 PS1, Line 11: For : example nit. As a result, http://gerrit.cloudera.org:8080/#/c/20379/1//COMMIT_MSG@12 PS1, Line 12: would incorrectly return http://gerrit.cloudera.org:8080/#/c/20379/1//COMMIT_MSG@17 PS1, Line 17: Identifies nit. This fix identifies http://gerrit.cloudera.org:8080/#/c/20379/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/20379/1/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@85 PS1, Line 85: hasStreamingPreagg_ I wonder if this new variable is logically equivalent to the following needsFinalize_ && useStreamingPreagg_ -- To view, visit http://gerrit.cloudera.org:8080/20379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 Gerrit-Change-Number: 20379 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 19 Aug 2023 16:23:49 +0000 Gerrit-HasComments: Yes
