[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. IMPALA-12595: Allow automatic

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. Patch Set 8: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 11: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. IMPALA-12313: (part 2) Limited

[Impala-ASF-CR] IMPALA-12465: Unicode column name support

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 ) Change subject: IMPALA-12465: Unicode column name support .. Patch Set 14: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12426: Adds the backend InternalServer class.

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20524 ) Change subject: IMPALA-12426: Adds the backend InternalServer class. .. Patch Set 24: Build Successful

[Impala-ASF-CR] IMPALA-12426: Adds the backend InternalServer class.

2023-12-08 Thread Jason Fehr (Code Review)
Jason Fehr has uploaded a new patch set (#24). ( http://gerrit.cloudera.org:8080/20524 ) Change subject: IMPALA-12426: Adds the backend InternalServer class. .. IMPALA-12426: Adds the backend InternalServer class. This class

[Impala-ASF-CR] IMPALA-12426: Adds the backend InternalServer class.

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20524 ) Change subject: IMPALA-12426: Adds the backend InternalServer class. .. Patch Set 24: (1 comment)

[Impala-ASF-CR] IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20648 ) Change subject: IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. Patch Set 8: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing

2023-12-08 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20648 ) Change subject: IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing .. Patch Set 4: (3

[Impala-ASF-CR] IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing

2023-12-08 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20648 to look at the new patch set (#5). Change subject: IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Joe McDonnell, Wenzhe Zhou, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20754 to look at the new patch set (#7). Change subject: IMPALA-12595: Allow automatic removal of old logs from previous

[Impala-ASF-CR] IMPALA-12595: Allow automatic removal of old logs from previous PID

2023-12-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20754 ) Change subject: IMPALA-12595: Allow automatic removal of old logs from previous PID .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

2023-12-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 ) Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12465: Unicode column name support

2023-12-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 ) Change subject: IMPALA-12465: Unicode column name support .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 11: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12465: Unicode column name support

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 ) Change subject: IMPALA-12465: Unicode column name support .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-10949: Improve batching logic of partition events

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20485 ) Change subject: IMPALA-10949: Improve batching logic of partition events .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-12465: Unicode column name support

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 ) Change subject: IMPALA-12465: Unicode column name support .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-12465: Unicode column name support

2023-12-08 Thread Anonymous Coward (Code Review)
pranav.lo...@cloudera.com has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/20506 ) Change subject: IMPALA-12465: Unicode column name support .. IMPALA-12465: Unicode column name support Impala depends on

[Impala-ASF-CR] IMPALA-10949: Improve batching logic of partition events

2023-12-08 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20485 ) Change subject: IMPALA-10949: Improve batching logic of partition events .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10949: Improve batching logic of partition events

2023-12-08 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, k.venureddy2...@gmail.com, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20485 to look at the new patch set (#4). Change subject: IMPALA-10949: Improve batching logic of partition events

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20763 ) Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04

2023-12-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20763 Change subject: IMPALA-12590: Fix dmesg call during precommit for Ubuntu 20.04 .. IMPALA-12590: Fix dmesg call during precommit for

[Impala-ASF-CR] IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 ) Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender .. Patch Set 8: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 10: Code-Review+2 Fantastic change,

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 11: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20760 ) Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables. .. Patch Set 3: (19 comments) Thanks Zoltán, great

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 10: Code-Review+1 Thanks, LGTM --

[Impala-ASF-CR] IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

2023-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20760 to look at the new patch set (#4). Change subject: IMPALA-12313: (part 3) Add UPDATE support for Iceberg tables.

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 10: (15 comments) Thanks for the

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Zoltan Borok-Nagy (Code Review)
Hello Andrew Sherman, Tamas Mate, Daniel Becker, Gabor Kaszab, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20677 to look at the new patch set (#10). Change subject: IMPALA-12313: (part 2) Limited UPDATE support

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20759 ) Change subject: IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns

2023-12-08 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20759 ) Change subject: IMPALA-12205: Add support to STRUCT type Iceberg Metadata table columns .. IMPALA-12205: Add support to STRUCT type

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Gabor Kaszab (Code Review)
Hello Andrew Sherman, Tamas Mate, Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20753 to look at the new patch set (#4). Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Gabor Kaszab (Code Review)
Hello Andrew Sherman, Tamas Mate, Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20753 to look at the new patch set (#3). Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 3: (22 comments) Thanks for taking

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 ) Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

2023-12-08 Thread Csaba Ringhofer (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20719 to look at the new patch set (#8). Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

[Impala-ASF-CR] IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 ) Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 ) Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 2: (4 comments) Looks great, found a

[Impala-ASF-CR] IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables

2023-12-08 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20677 ) Change subject: IMPALA-12313: (part 2) Limited UPDATE support for Iceberg tables .. Patch Set 9: (1 comment) Looks good to me! I can

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing

2023-12-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20648 ) Change subject: IMPALA-10987: Changing impala.disableHmsSync in Hive should not break event processing .. Patch Set 4: (3

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 2: PS2 is a rebase with master and

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20753 ) Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg tables .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-12597: Basic Equality delete read support for Iceberg tables

2023-12-08 Thread Gabor Kaszab (Code Review)
Hello Andrew Sherman, Tamas Mate, Daniel Becker, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20753 to look at the new patch set (#2). Change subject: IMPALA-12597: Basic Equality delete read support for Iceberg