[Impala-ASF-CR] IMPALA-12260: Crash if '--asm module dir' is set

2023-07-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20155 ) Change subject: IMPALA-12260: Crash if '--asm_module_dir' is set .. Patch Set 4: I ran a perf a-b benchmark: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-10173: Fix substitution for unsafe expressions, column-level compatibility check

2023-07-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20184 ) Change subject: IMPALA-10173: Fix substitution for unsafe expressions, column-level compatibility check .. Patch Set 2: (12 comments)

[Impala-ASF-CR] IMPALA-12239: BitWidthZeroRepeated seems to be flaky

2023-07-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20187 ) Change subject: IMPALA-12239: BitWidthZeroRepeated seems to be flaky .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-12260: Crash if '--asm module dir' is set

2023-07-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20155 ) Change subject: IMPALA-12260: Crash if '--asm_module_dir' is set .. IMPALA-12260: Crash if '--asm_module_dir' is set If Impala is starte

[Impala-ASF-CR] IMPALA-12239: BitWidthZeroRepeated seems to be flaky

2023-07-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20187 Change subject: IMPALA-12239: BitWidthZeroRepeated seems to be flaky .. IMPALA-12239: BitWidthZeroRepeated seems to be flaky RleTest.Bi

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-07-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multipl

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-07-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multipl

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-07-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multipl

[Impala-ASF-CR] IMPALA-12269: Codegen cache false negative because of function names hash

2023-07-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20168 ) Change subject: IMPALA-12269: Codegen cache false negative because of function names hash .. Patch Set 3: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-12269: Codegen cache false negative because of function names hash

2023-07-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20168 ) Change subject: IMPALA-12269: Codegen cache false negative because of function names hash .. IMPALA-12269: Codegen cache false negative

[Impala-ASF-CR] IMPALA-12260: Crash if '--asm module dir' is set

2023-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20155 ) Change subject: IMPALA-12260: Crash if '--asm_module_dir' is set .. Patch Set 3: (5 comments) Thanks for the reviews. http://gerrit.

[Impala-ASF-CR] IMPALA-12260: Crash if '--asm module dir' is set

2023-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20155 ) Change subject: IMPALA-12260: Crash if '--asm_module_dir' is set .. IMPALA-12260: Crash if '--asm_module_dir' is set If Impala is starte

[Impala-ASF-CR] IMPALA-12260: Crash if '--asm module dir' is set

2023-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20155 ) Change subject: IMPALA-12260: Crash if '--asm_module_dir' is set .. IMPALA-12260: Crash if '--asm_module_dir' is set If Impala is starte

[Impala-ASF-CR] IMPALA-12269: Codegen cache false negative because of function names hash

2023-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20168 ) Change subject: IMPALA-12269: Codegen cache false negative because of function names hash .. IMPALA-12269: Codegen cache false negative

[Impala-ASF-CR] IMPALA-12269: Codegen cache false negative because of function names hash

2023-07-07 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20168 Change subject: IMPALA-12269: Codegen cache false negative because of function names hash .. IMPALA-12269: Codegen cache false negative

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-07-06 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multipl

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-07-04 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multipl

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-07-04 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multiple

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-07-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. Patch Set 9: (7 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-12263: Build with C++ Avro library when USE AVRO CPP is true

2023-07-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20156 ) Change subject: IMPALA-12263: Build with C++ Avro library when USE_AVRO_CPP is true .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12263: Build with C++ Avro library when USE AVRO CPP is true

2023-07-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20156 ) Change subject: IMPALA-12263: Build with C++ Avro library when USE_AVRO_CPP is true .. Patch Set 1: (1 comment) Looks good, thanks.

[Impala-ASF-CR] IMPALA-12260: Crash if '--asm module dir' is set

2023-07-03 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20155 Change subject: IMPALA-12260: Crash if '--asm_module_dir' is set .. IMPALA-12260: Crash if '--asm_module_dir' is set If Impala is start

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-06-30 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multiple

[Impala-ASF-CR] IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table

2023-06-29 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19881 ) Change subject: IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table .. Patch Set 11: Code-Re

[Impala-ASF-CR] IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted

2023-06-29 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18999 ) Change subject: IMPALA-10753: Incorrect length when multiple CHAR(N) values are inserted .. IMPALA-10753: Incorrect length when multiple

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

2023-06-29 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 ) Change subject: IMPALA-11949: Make backend AVRO C++ library available .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-12238: RandomNestedDataGenerator should take a seed argument

2023-06-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20136 ) Change subject: IMPALA-12238: RandomNestedDataGenerator should take a seed argument .. Patch Set 1: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-12238: RandomNestedDataGenerator should take a seed argument

2023-06-28 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20136 ) Change subject: IMPALA-12238: RandomNestedDataGenerator should take a seed argument .. IMPALA-12238: RandomNestedDataGenerator

[Impala-ASF-CR] IMPALA-12238: RandomNestedDataGenerator should take a seed argument

2023-06-28 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20136 Change subject: IMPALA-12238: RandomNestedDataGenerator should take a seed argument .. IMPALA-12238: RandomNestedDataGenerator should t

[Impala-ASF-CR] WIP: Implement reading DELTA BINARY PACKED columns in Parquet

2023-06-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20041 ) Change subject: WIP: Implement reading DELTA_BINARY_PACKED columns in Parquet .. Patch Set 3: (15 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table

2023-06-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19881 ) Change subject: IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table .. Patch Set 8: Code-Rev

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile event if the query failed in planning

2023-06-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile event if the query failed in planning .. Patch Set 4: (1 comment) htt

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-06-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 14: Code-Revie

[Impala-ASF-CR] IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table

2023-06-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19881 ) Change subject: IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table .. Patch Set 7: (6 comm

[Impala-ASF-CR] WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-06-22 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20108 Change subject: WIP: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. WIP: IMPALA-12159: Suppo

[Impala-ASF-CR] IMPALA-12148: Bump timeouts for TestAsyncDDLTiming::test ctas()

2023-06-21 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20030 ) Change subject: IMPALA-12148: Bump timeouts for TestAsyncDDLTiming::test_ctas() .. Patch Set 1: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-11949: Make backend AVRO C++ library available

2023-06-21 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20097 ) Change subject: IMPALA-11949: Make backend AVRO C++ library available .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-06-20 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 13: (7 commen

[Impala-ASF-CR] IMPALA-12171: Optimize delimited output

2023-06-20 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19894 ) Change subject: IMPALA-12171: Optimize delimited output .. Patch Set 10: Code-Review+1 Thanks. It's ok for me after fixing the test fa

[Impala-ASF-CR] IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table

2023-06-16 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19881 ) Change subject: IMPALA-10173: Allow implicit casts between numeric and string types when inserting into table .. Patch Set 5: (32 com

[Impala-ASF-CR] IMPALA-11459: Use new LLVM Pass Manager

2023-06-15 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20014 ) Change subject: IMPALA-11459: Use new LLVM Pass Manager .. Patch Set 8: Code-Review+1 Thanks Michael, looks good. -- To view, visit

[Impala-ASF-CR] IMPALA-12114: Pull in fix for THRIFT-5705 and add test

2023-06-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19962 ) Change subject: IMPALA-12114: Pull in fix for THRIFT-5705 and add test .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-12142: Decrease default fetch size to 8192 in impala-shell

2023-06-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19965 ) Change subject: IMPALA-12142: Decrease default fetch_size to 8192 in impala-shell .. Patch Set 2: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-12142: Decrease default fetch size to 8192 in impala-shell

2023-06-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19965 ) Change subject: IMPALA-12142: Decrease default fetch_size to 8192 in impala-shell .. Patch Set 2: Code-Review+1 Thanks, looks good.

[Impala-ASF-CR] IMPALA-12142: Decrease default fetch size to 8192 in impala-shell

2023-06-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19965 ) Change subject: IMPALA-12142: Decrease default fetch_size to 8192 in impala-shell .. Patch Set 1: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-12114: Pull in fix for THRIFT-5705 and add test

2023-06-01 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19962 ) Change subject: IMPALA-12114: Pull in fix for THRIFT-5705 and add test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-8253: Parquet delta encoding and decoding.

2023-05-22 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12621 ) Change subject: IMPALA-8253: Parquet delta encoding and decoding. .. Patch Set 20: (7 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-8253: Parquet delta encoding and decoding.

2023-05-22 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/12621 ) Change subject: IMPALA-8253: Parquet delta encoding and decoding. .. IMPALA-8253: Parquet delta encoding and decoding. Implemented an e

[Impala-ASF-CR] IMPALA-12147: Allow collections of fixed length types as non-passthrough children of unions

2023-05-19 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19903 ) Change subject: IMPALA-12147: Allow collections of fixed length types as non-passthrough children of unions .. IMPALA-12147: Allow colle

[Impala-ASF-CR] IMPALA-12147: Allow collections of fixed length types as non-passthrough children of unions

2023-05-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19903 Change subject: IMPALA-12147: Allow collections of fixed length types as non-passthrough children of unions .. IMPALA-12147: Allow coll

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-05-18 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 10: (8 commen

[Impala-ASF-CR] IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list

2023-05-18 Thread Daniel Becker (Code Review)
Daniel Becker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19660 ) Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list .. IMPALA-12019: Support ORDER

[Impala-ASF-CR] IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list

2023-05-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/19660 ) Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list .. IMPALA-12019: Support ORDER BY for ar

[Impala-ASF-CR] IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list

2023-05-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/19660 ) Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list .. IMPALA-12019: Support ORDER BY for ar

[Impala-ASF-CR] IMPALA-10173: Allow implicit casts from numerics to STRING when inserting into table

2023-05-16 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19881 ) Change subject: IMPALA-10173: Allow implicit casts from numerics to STRING when inserting into table .. Patch Set 3: (41 comments) T

[Impala-ASF-CR] IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list

2023-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/19660 ) Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list .. IMPALA-12019: Support ORDER BY for ar

[Impala-ASF-CR] IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list

2023-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/19660 ) Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list .. IMPALA-12019: Support ORDER BY for ar

[Impala-ASF-CR] IMPALA-12138: Optimize HS2 result vector allocations

2023-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19879 ) Change subject: IMPALA-12138: Optimize HS2 result vector allocations .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-12138: Optimize HS2 result vector allocations

2023-05-15 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19879 ) Change subject: IMPALA-12138: Optimize HS2 result vector allocations .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-05-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 9: (7 comment

[Impala-ASF-CR] IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list

2023-05-12 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/19660 ) Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list .. IMPALA-12019: Support ORDER BY for arr

[Impala-ASF-CR] IMPALA-6433: Add read support for PageHeaderV2

2023-05-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 ) Change subject: IMPALA-6433: Add read support for PageHeaderV2 .. Patch Set 16: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6433: Add read support for PageHeaderV2

2023-05-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 ) Change subject: IMPALA-6433: Add read support for PageHeaderV2 .. Patch Set 13: -Code-Review (3 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-12035: Impala accepts very big numbers but fails to store them correctly

2023-05-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19856 ) Change subject: IMPALA-12035: Impala accepts very big numbers but fails to store them correctly .. Patch Set 5: (1 comment) http://g

[Impala-ASF-CR] IMPALA-12035: Impala accepts very big numbers but fails to store them correctly

2023-05-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/19856 ) Change subject: IMPALA-12035: Impala accepts very big numbers but fails to store them correctly .. IMPALA-12035: Impala accepts very big

[Impala-ASF-CR] IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list

2023-05-11 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/19660 ) Change subject: IMPALA-12019: Support ORDER BY for arrays of fixed length types in select list .. IMPALA-12019: Support ORDER BY for arr

[Impala-ASF-CR] IMPALA-12119: rename FORCE INLINE to avoid name collision

2023-05-10 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 ) Change subject: IMPALA-12119: rename FORCE_INLINE to avoid name collision .. Patch Set 6: Code-Review+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-12035: impala-shell accepts very big numbers but fails to store them correctly

2023-05-10 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19856 ) Change subject: IMPALA-12035: impala-shell accepts very big numbers but fails to store them correctly .. IMPALA-12035: impala-shell acce

[Impala-ASF-CR] IMPALA-12117: Use separate cache dirs for shell pip installs

2023-05-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19813 ) Change subject: IMPALA-12117: Use separate cache dirs for shell pip installs .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-12035: impala-shell accepts very big numbers but fails to store them correctly

2023-05-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19856 Change subject: IMPALA-12035: impala-shell accepts very big numbers but fails to store them correctly .. IMPALA-12035: impala-shell acc

[Impala-ASF-CR] IMPALA-12042: Fix invalid casts in set operations calculation

2023-05-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19790 ) Change subject: IMPALA-12042: Fix invalid casts in set operations calculation .. Patch Set 5: Code-Review+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-12122: use isb instead of yield on arm64

2023-05-09 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19861 ) Change subject: IMPALA-12122: use isb instead of yield on arm64 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19861

[Impala-ASF-CR] IMPALA-12035: impala-shell accepts very big numbers but fails to store them correctly

2023-05-09 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19856 ) Change subject: IMPALA-12035: impala-shell accepts very big numbers but fails to store them correctly .. IMPALA-12035: impala-shell acce

[Impala-ASF-CR] IMPALA-12042: Fix invalid casts in set operations calculation

2023-05-05 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19790 ) Change subject: IMPALA-12042: Fix invalid casts in set operations calculation .. Patch Set 4: (2 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion

2023-05-05 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 ) Change subject: IMPALA-12111: Speed up DATE to STRING conversion .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6433: Add read support for PageHeaderV2

2023-05-05 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 ) Change subject: IMPALA-6433: Add read support for PageHeaderV2 .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-12042: Invalid casts in set operations calculation

2023-05-05 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19790 ) Change subject: IMPALA-12042: Invalid casts in set operations calculation .. Patch Set 3: (22 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] aarch64: define FORCE INLINE once

2023-05-05 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19839 ) Change subject: aarch64: define FORCE_INLINE once .. Patch Set 1: Thanks @sebpop for fixing this. Could you open a Jira ticket for thi

[Impala-ASF-CR] IMPALA-6433: Add read support for PageHeaderV2

2023-05-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 ) Change subject: IMPALA-6433: Add read support for PageHeaderV2 .. Patch Set 12: Code-Review+1 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo

2023-05-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19720 ) Change subject: IMPALA-12055: Use jquery.min.js from local repo .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[native-toolchain-CR] Update README about env setup

2023-05-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 ) Change subject: Update README about env setup .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/19750 T

[Impala-ASF-CR] IMPALA-6433: Add read support for PageHeaderV2

2023-05-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 ) Change subject: IMPALA-6433: Add read support for PageHeaderV2 .. Patch Set 11: (8 comments) http://gerrit.cloudera.org:8080/#/c/1979

[Impala-ASF-CR](asf-site) IMPALA-12055: Use jquery.min.js from local repo

2023-05-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19720 ) Change subject: IMPALA-12055: Use jquery.min.js from local repo .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[native-toolchain-CR] Update README about env setup

2023-05-04 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19750 ) Change subject: Update README about env setup .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/19750/3/README.md File

[Impala-ASF-CR] IMPALA-12102: Avoid memory leaks in the handling of JNI exceptions

2023-05-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19810 ) Change subject: IMPALA-12102: Avoid memory leaks in the handling of JNI exceptions .. Patch Set 3: Code-Review+1 (1 comment) Thanks,

[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion

2023-05-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 ) Change subject: IMPALA-12111: Speed up DATE to STRING conversion .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-12111: Speed up DATE to STRING conversion

2023-05-03 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19829 ) Change subject: IMPALA-12111: Speed up DATE to STRING conversion .. Patch Set 2: Code-Review+1 (1 comment) Looks good, thanks. http:

[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2

2023-05-02 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 ) Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2 .. Patch Set 4: Code-Review+1 -- To

[Impala-ASF-CR] IMPALA-12102: This patch avoids memory leaks due to the large number of JNI exceptions thrown

2023-04-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19810 ) Change subject: IMPALA-12102: This patch avoids memory leaks due to the large number of JNI exceptions thrown .. Patch Set 2: (1 comm

[Impala-ASF-CR] IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2

2023-04-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19787 ) Change subject: IMPALA-12084: IM under unloaded db should not send full db updates in catalog-v2 .. Patch Set 3: (1 comment) Thanks,

[Impala-ASF-CR] IMPALA-12102: This patch avoids memory leaks due to the large number of JNI exceptions thrown

2023-04-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19810 ) Change subject: IMPALA-12102: This patch avoids memory leaks due to the large number of JNI exceptions thrown .. Patch Set 2: (3 comm

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-04-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 7: (10 commen

[Impala-ASF-CR] IMPALA-12099: Catalogd throw NPE when refreshing a partitioned table

2023-04-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19804 ) Change subject: IMPALA-12099: Catalogd throw NPE when refreshing a partitioned table .. Patch Set 1: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8253: Parquet delta encoding and decoding.

2023-04-26 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12621 ) Change subject: IMPALA-8253: Parquet delta encoding and decoding. .. Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-8253: Parquet delta encoding and decoding.

2023-04-26 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/12621 ) Change subject: IMPALA-8253: Parquet delta encoding and decoding. .. IMPALA-8253: Parquet delta encoding and decoding. Implemented an e

[Impala-ASF-CR] IMPALA-6433: Add read support for PageHeaderV2

2023-04-25 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19793 ) Change subject: IMPALA-6433: Add read support for PageHeaderV2 .. Patch Set 8: (26 comments) Thanks Csaba, great work. http://gerrit

[Impala-ASF-CR] IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero

2023-04-25 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19792 ) Change subject: IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero

2023-04-25 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19792 ) Change subject: IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero .. IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero BitUtil::

[Impala-ASF-CR] IMPALA-12042: Invalid casts in set operations calculation

2023-04-24 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19790 ) Change subject: IMPALA-12042: Invalid casts in set operations calculation .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero

2023-04-24 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19792 Change subject: IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero .. IMPALA-12086: Fix BitUtil::CountLeadingZeros for zero BitUtil:

<    1   2   3   4   5   6   7   8   9   10   >