Re: [Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-05 Thread Manaswini Maharana
udera.org:8080/settings>. > Gerrit-Project: Impala-ASF > Gerrit-Branch: master > Gerrit-MessageType: comment > Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e > Gerrit-Change-Number: 8923 > Gerrit-PatchSet: 6 > Gerrit-Owner: Manaswini Maharana > Gerrit-Reviewe

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-04 Thread Manaswini Maharana (Code Review)
Manaswini Maharana has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. Patch Set 5: Jenkin tests- pre-review-test

[Impala-ASF-CR] IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode

2018-01-03 Thread Manaswini Maharana (Code Review)
Manaswini Maharana has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/8923 ) Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode .. IMPALA-6296: Avoid crash caused by DCHECK in

[Impala-ASF-CR] In order to fix IMPALA-6296, have added a condition check to ensure 'emit perf map ' evaluates to true before the dependent object(perf map lock ) is asserted using DCHECK.

2017-12-29 Thread Manaswini Maharana (Code Review)
Manaswini Maharana has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8923 Change subject: In order to fix IMPALA-6296, have added a condition check to ensure 'emit_perf_map_' evaluates to true before the dependent object(perf_map_lock_) is asserted us