[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/9632 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Abandoned Conflict with https://gerrit.cloudera.org/#/c/9633/ -- To view,

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9632 Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. IMPALA-6652: Rename label of MemTracker for early RPCs This

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9606 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 1: Clean cherry-pick. Did some

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9606 to review the following change. Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write()

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-09 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9527 to look at the new patch set (#5). Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9527 to look at the new patch set (#4). Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-08 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9527 to look at the new patch set (#3). Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 1: (9 comments)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-07 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9527 to look at the new patch set (#2). Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 1: FWIW, I am also working on some new

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9527 ) Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9527 Change subject: IMPALA-6609: Fix ownership of class members in KrpcDataStreamRecvr .. IMPALA-6609: Fix ownership of class members in

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9519 ) Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. Patch Set 2: Code-Review+2 Please do some basic sanity tests

[Impala-ASF-CR] IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9519 ) Change subject: IMPALA-6477: rpc-mgr-kerberized-test fails on CentOS 6.4 .. Patch Set 1: (2 comments) So, thrift-server-test didn't need

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 13: Code-Review+1 I will let

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 6: Code-Review+2 Rebased and reverted bumping the memory limit in

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-04 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#6). Change subject: IMPALA-2567: Enable KRPC by default

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-04 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#5). Change subject: IMPALA-2567: Enable KRPC by default

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 11: (2 comments)

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 4: Hold off from merging until the builds are in better shape. -- To

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#4). Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567:

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9461 ) Change subject: IMPALA-2567: Enable KRPC by default .. Patch Set 2: (3 comments) The existing jenkins jobs to test with KRPC enabled

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-03-02 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9461 to look at the new patch set (#3). Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567:

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-03-01 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9446 to look at the new patch set (#5). Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() ..

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-02-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-02-28 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9446 to look at the new patch set (#4). Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() ..

[Impala-ASF-CR] IMPALA-6585: increase test low mem limit q21 limit

2018-02-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9449 ) Change subject: IMPALA-6585: increase test_low_mem_limit_q21 limit .. Patch Set 1: FWIW, IMPALA-2567 is blocked by this. -- To view,

[Impala-ASF-CR] IMPALA-2567: Enable KRPC by default

2018-02-28 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9461 Change subject: IMPALA-2567: Enable KRPC by default .. IMPALA-2567: Enable KRPC by default This change enables the switch to use KRPC by

[Impala-ASF-CR] IMPALA-6565: Fix some bugs in KprcDataStreamRecvr

2018-02-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9439 ) Change subject: IMPALA-6565: Fix some bugs in KprcDataStreamRecvr .. Patch Set 4: More infrastructure issue. IMPALA-6394. HDFS block

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-02-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6565: Fix some bugs in KprcDataStreamRecvr

2018-02-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9439 ) Change subject: IMPALA-6565: Fix some bugs in KprcDataStreamRecvr .. Patch Set 4: GVO failed due to flaky infrastructure (IMPALA-6593)

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 ) Change subject: IMPALA-2990: Add a warning message during cancellation .. Patch Set 2: GVO failed due to IMPALA-6394 -- To view, visit

[Impala-ASF-CR] IMPALA-6512: Maintenace thread period should respect FLAGS datastream sender timeout ms

2018-02-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9447 ) Change subject: IMPALA-6512: Maintenace thread period should respect FLAGS_datastream_sender_timeout_ms .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6512: Maintenace thread period should respect FLAGS datastream sender timeout ms

2018-02-26 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9447 to look at the new patch set (#2). Change subject: IMPALA-6512: Maintenace thread period should respect FLAGS_datastream_sender_timeout_ms

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-02-26 Thread Michael Ho (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9446 to look at the new patch set (#2). Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. IMPALA-6554: Fix

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-02-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9446 ) Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. Patch Set 1: (2 comments) Responding to questions first. Will update

[Impala-ASF-CR] IMPALA-6565: Fix some bugs in KprcDataStreamRecvr

2018-02-25 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9439 to look at the new patch set (#4). Change subject: IMPALA-6565: Fix some bugs in KprcDataStreamRecvr ..

[Impala-ASF-CR] IMPALA-6577: avoid slow Status constructor on expiration thread

2018-02-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9443 ) Change subject: IMPALA-6577: avoid slow Status constructor on expiration thread .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-6512: Maintenace thread period should respect FLAGS datastream sender timeout ms

2018-02-24 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9447 Change subject: IMPALA-6512: Maintenace thread period should respect FLAGS_datastream_sender_timeout_ms .. IMPALA-6512: Maintenace thread

[Impala-ASF-CR] IMPALA-6554: Fix a race in DequeueDeferredRpc()

2018-02-24 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9446 Change subject: IMPALA-6554: Fix a race in DequeueDeferredRpc() .. IMPALA-6554: Fix a race in DequeueDeferredRpc() Previously,

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-24 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9439 to look at the new patch set (#3). Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9439 ) Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc() .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9439 ) Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc() .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-23 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9439 to look at the new patch set (#2). Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc() ..

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9413 ) Change subject: IMPALA-2990: Add a warning message during cancellation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-23 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9413 to look at the new patch set (#2). Change subject: IMPALA-2990: Add a warning message during cancellation

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9439 ) Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc() .. Patch Set 1: Pushing this fix out to unbreak the build for

[Impala-ASF-CR] IMPALA-6565: Fix dropped status in DequeueDeferredRpc()

2018-02-23 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9439 Change subject: IMPALA-6565: Fix dropped status in DequeueDeferredRpc() .. IMPALA-6565: Fix dropped status in DequeueDeferredRpc() The

[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters

2018-02-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 ) Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters .. Patch Set 2: Code-Review+2

[Impala-ASF-CR] IMPALA-6432: Default rpc negotiation timeout ms may cause queries to fail on large clusters

2018-02-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9434 ) Change subject: IMPALA-6432: Default rpc_negotiation_timeout_ms may cause queries to fail on large clusters .. Patch Set 2: Code-Review+1

[Impala-ASF-CR] IMPALA-2990: Add a warning message during cancellation

2018-02-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9413 Change subject: IMPALA-2990: Add a warning message during cancellation .. IMPALA-2990: Add a warning message during cancellation Until

[Impala-ASF-CR] KUDU-2305: Fix local variable usage to handle 2GB messages

2018-02-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9407 ) Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4874: Increase maximum KRPC message size

2018-02-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 ) Change subject: IMPALA-4874: Increase maximum KRPC message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 17: Code-Review+2 (3 comments)

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: GVO failed due to infrastructure issue (IMPALA-6394)

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 15: Code-Review+2 (5 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 8: Code-Review+2 Carry Tim's +2

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-19 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#8). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Clean application of the original patch. -- To

[Impala-ASF-CR] KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9361 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Patch Set 1: Clean application of the

[Impala-ASF-CR] KUDU-2218. tls socket: properly handle temporary socket errors in Writev

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9361 ) Change subject: KUDU-2218. tls_socket: properly handle temporary socket errors in Writev .. Removed reviewer Kudu Jenkins. -- To

[Impala-ASF-CR] [security] test and fixes for TLS socket EINTR issues

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9360 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 1: Clean application of the original patch. -- To

[Impala-ASF-CR] [security] test and fixes for TLS socket EINTR issues

2018-02-19 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9360 to review the following change. Change subject: [security] test and fixes for TLS socket EINTR issues

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9359 to review the following change. Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() ..

[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2018-02-19 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 11: (10 comments)

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 11: (4 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-18 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#7). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-17 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#7). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 6: Yes, we will do appropriate tuning

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 6: Code-Review+2 Carry Tim's +2 -- To

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#6). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#6). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#5). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#5). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6269: Expose KRPC metrics on debug webpage

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 ) Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-16 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#4). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-16 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9282 to look at the new patch set (#4). Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9344 ) Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

2018-02-15 Thread Michael Ho (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9344 to look at the new patch set (#3). Change subject: IMPALA-5518: Allocate KrpcDataStreamRecvr RowBatch tuples from BufferPool

<    3   4   5   6   7   8   9   10   11   >