[Impala-ASF-CR] IMPALA-8834: Short-circuit partition key scan

2020-04-21 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13993 to look at the new patch set (#16). Change subject: IMPALA-8834: Short-circuit partition key scan .

[Impala-ASF-CR] IMPALA-9645 Port LLVM codegen to adapt aarch64

2020-04-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15718 ) Change subject: IMPALA-9645 Port LLVM codegen to adapt aarch64 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15718

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

2020-04-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 ) Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64 .. Patch Set 4: (4 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-9683: distcc ubuntu 18.04 support

2020-04-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15772 Change subject: IMPALA-9683: distcc ubuntu 18.04 support .. IMPALA-9683: distcc ubuntu 18.04 support This allows distcc server bootstra

[Impala-ASF-CR] IMPALA-8834: Short-circuit partition key scan

2020-04-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13993 ) Change subject: IMPALA-8834: Short-circuit partition key scan .. Patch Set 15: Haven't addressed comments yet, was just fixing test fa

[Impala-ASF-CR] IMPALA-8834: Short-circuit partition key scan

2020-04-21 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13993 to look at the new patch set (#15). Change subject: IMPALA-8834: Short-circuit partition key scan .

[Impala-ASF-CR] IMPALA-9646: clean up README

2020-04-20 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15719 to look at the new patch set (#3). Change subject: IMPALA-9646: clean up README ..

[Impala-ASF-CR] IMPALA-9646: clean up README

2020-04-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15719 ) Change subject: IMPALA-9646: clean up README .. Patch Set 3: Carry +2. I'm going to manually verify after the automatic checks finish,

[Impala-ASF-CR] IMPALA-9646: clean up README

2020-04-20 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15719 to look at the new patch set (#2). Change subject: IMPALA-9646: clean up README ..

[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image

2020-04-20 Thread Tim Armstrong (Code Review)
Hello Anurag Mantripragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15765 to look at the new patch set (#2). Change subject: IMPALA-9574: support ubuntu 18.04 base image .

[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image

2020-04-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 ) Change subject: IMPALA-9574: support ubuntu 18.04 base image .. Patch Set 1: You're right, I didn't squash this. -- To view, visit h

[Impala-ASF-CR] IMPALA-9646: clean up README

2020-04-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15719 ) Change subject: IMPALA-9646: clean up README .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15719/1/README-build.md

[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image

2020-04-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15765 Change subject: IMPALA-9574: support ubuntu 18.04 base image .. IMPALA-9574: support ubuntu 18.04 base image Automatically detect if we

[Impala-ASF-CR] IMPALA-9679: Remove some jars from Docker images

2020-04-20 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15753 to look at the new patch set (#5). Change subject: IMPALA-9679: Remove some jars from Docker images .. IMP

[Impala-ASF-CR] IMPALA-8834: Short-circuit partition key scan

2020-04-20 Thread Tim Armstrong (Code Review)
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13993 to look at the new patch set (#14). Change subject: IMPALA-8834: Short-circuit partition key scan .

[Impala-ASF-CR] IMPALA-8834: Short-circuit partition key scan

2020-04-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed Michael Ho from this change. ( http://gerrit.cloudera.org:8080/13993 ) Change subject: IMPALA-8834: Short-circuit partition key scan .. Removed reviewer Michael Ho. -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-8834: Short-circuit partition key scan

2020-04-20 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13993 to look at the new patch set (#13). Change subject: IMPALA-8834: Short-circuit partition key scan .

[Impala-ASF-CR] IMPALA-9666 Correct a log message in TestImpalaShellInteractive

2020-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15751 ) Change subject: IMPALA-9666 Correct a log message in TestImpalaShellInteractive .. Patch Set 1: Code-Review+2 THanks for fixing this

[Impala-ASF-CR] IMPALA-3926: part 2: avoid setting LD LIBRARY PATH

2020-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14494 ) Change subject: IMPALA-3926: part 2: avoid setting LD_LIBRARY_PATH .. Patch Set 16: I finally got back to this and fixed up the patch

[Impala-ASF-CR] IMPALA-3926: part 2: avoid setting LD LIBRARY PATH

2020-04-17 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14494 to look at the new patch set (#16). Change subject: IMPALA-3926: part 2: avoid setting LD_LIBRARY_PATH ..

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 7: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15700 ) Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node .. IMPALA-9596: deflake test_tpch_mem_limit_single_node T

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: (1 comment) Looks liek there a

[Impala-ASF-CR] IMPALA-9616 [DOC]: Document spill to disk startup options

2020-04-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 [DOC]: Document spill to disk startup options .. Patch Set 4: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-9616 [DOC]: Document spill to disk startup options

2020-04-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 [DOC]: Document spill to disk startup options .. IMPALA-9616 [DOC]: Document spill to disk startup

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-15 Thread Tim Armstrong (Code Review)
Hello Norbert Luksa, Daniel Becker, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15700 to look at the new patch set (#4). Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node ..

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 ) Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node .. Patch Set 3: Code-Review+2 Fixed the test failures, it was bac

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-15 Thread Tim Armstrong (Code Review)
Hello Norbert Luksa, Daniel Becker, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15700 to look at the new patch set (#3). Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node ..

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 ) Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node .. Patch Set 2: This looks like a legit failure in a backend test

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: THis is waiting for a +2 from m

[Impala-ASF-CR] IMPALA-9616

2020-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 .. Patch Set 3: (1 comment) Looks good to me aside from the commit message. http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9422: Re-visit and improve join node and builder's counters

2020-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15663 ) Change subject: IMPALA-9422: Re-visit and improve join node and builder's counters .. Patch Set 2: Code-Review+2 (1 comment) http://

[Impala-ASF-CR] IMPALA-9616

2020-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 .. Patch Set 3: SOrry for the delay, I need to take another look at this -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15700 ) Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-14 Thread Tim Armstrong (Code Review)
Hello Norbert Luksa, Daniel Becker, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15700 to look at the new patch set (#2). Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node ..

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15715 ) Change subject: IMPALA-9643: fix runtime filter race for mt_dop .. IMPALA-9643: fix runtime filter race for mt_dop This patch

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15715 ) Change subject: IMPALA-9643: fix runtime filter race for mt_dop .. Patch Set 8: I started an exhaustive test run earlier. I'll run pre

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15715 to look at the new patch set (#7). Change subject: IMPALA-9643: fix runtime filter race for mt_dop

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15715 ) Change subject: IMPALA-9643: fix runtime filter race for mt_dop .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15715 ) Change subject: IMPALA-9643: fix runtime filter race for mt_dop .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/1571

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15715 to look at the new patch set (#6). Change subject: IMPALA-9643: fix runtime filter race for mt_dop

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15715 ) Change subject: IMPALA-9643: fix runtime filter race for mt_dop .. Patch Set 4: That's a good point, I'll see if I can rework this so

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15715 ) Change subject: IMPALA-9643: fix runtime filter race for mt_dop .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15715

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15715 to look at the new patch set (#5). Change subject: IMPALA-9643: fix runtime filter race for mt_dop

[Impala-ASF-CR] IMPALA-9646: clean up README

2020-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15719 Change subject: IMPALA-9646: clean up README .. IMPALA-9646: clean up README Misc improvements to get the README up-to-date and direct

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15715 to look at the new patch set (#4). Change subject: IMPALA-9643: fix runtime filter race for mt_dop

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-13 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15715 to look at the new patch set (#3). Change subject: IMPALA-9643: fix runtime filter race for mt_dop

[Impala-ASF-CR] IMPALA-9644: Set core file size 0 in docker entrypoint script

2020-04-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15717 ) Change subject: IMPALA-9644: Set core file size 0 in docker entrypoint script .. Patch Set 2: thanks for the contribution! -- To vie

[Impala-ASF-CR] IMPALA-9644: Set core file size 0 in docker entrypoint script

2020-04-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15717 ) Change subject: IMPALA-9644: Set core file size 0 in docker entrypoint script .. Patch Set 1: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-11 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15715 to look at the new patch set (#2). Change subject: IMPALA-9643: fix runtime filter race for mt_dop

[Impala-ASF-CR] IMPALA-9643: fix runtime filter race for mt dop

2020-04-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15715 Change subject: IMPALA-9643: fix runtime filter race for mt_dop .. IMPALA-9643: fix runtime filter race for mt_dop The fix is to set th

[Impala-ASF-CR] IMPALA-9176: shared null-aware anti-join build

2020-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15612 ) Change subject: IMPALA-9176: shared null-aware anti-join build .. Patch Set 12: Code-Review+1 carry -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Differ

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 22: Rebasing this patch which the verify job was running prevented it ge

[Impala-ASF-CR] IMPALA-9596: deflake test tpch mem limit single node

2020-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15700 Change subject: IMPALA-9596: deflake test_tpch_mem_limit_single_node .. IMPALA-9596: deflake test_tpch_mem_limit_single_node This chang

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/153

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-9176: shared null-aware anti-join build

2020-04-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15612 ) Change subject: IMPALA-9176: shared null-aware anti-join build .. Patch Set 12: (10 comments) http://gerrit.cloudera.org:8080/#/c/156

[Impala-ASF-CR] IMPALA-9176: shared null-aware anti-join build

2020-04-09 Thread Tim Armstrong (Code Review)
Hello Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15612 to look at the new patch set (#11). Change subject: IMPALA-9176: shared null-aware anti-join build ...

[Impala-ASF-CR] IMPALA-9616

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/15692/1//COMMIT_MSG Commit Message: htt

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 7: Looks like IMPALA-9596 -- To view,

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 7: Looks like a flaky test, I'll file a

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: Yeah that could be worth doing, it seems relatively safe

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 3: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15687 to look at the new patch set (#8). Change subject: IMPALA-9618: fix some usability issues with dev env ..

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15687 to look at the new patch set (#7). Change subject: IMPALA-9618: fix some usability issues with dev env ..

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 1: Code-Review+2 LGTM once the minor things are

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 5: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: I think we can probably live with a 10-15% regression fo

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 4: (1 comment) LGTM aside from a minor

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 11: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 10: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 3: (5 comments) Thanks for adding the t

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 20: (2 comments) OK, I'm pretty much ready to +2, just had a minor requ

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: Agree it would be good to sanity check at least one larg

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 2: I should've asked first time, but wer

[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15586 ) Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. IMPALA-9565 Remove unused included file mm_malloc

[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15586 ) Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. Patch Set 9: Thanks for the contribution! -- To view,

[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15586 ) Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. Patch Set 8: Verified+1 Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 1: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-9611: fix hang when cancelling join builder

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15672 ) Change subject: IMPALA-9611: fix hang when cancelling join builder .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-9611: fix hang when cancelling join builder

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15672 ) Change subject: IMPALA-9611: fix hang when cancelling join builder .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-9611: fix hang when cancelling join builder

2020-04-07 Thread Tim Armstrong (Code Review)
Hello Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15672 to look at the new patch set (#2). Change subject: IMPALA-9611: fix hang when cancelling join builder

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15586 ) Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. Patch Set 7: Looks like there's an equivalent change in

[Impala-ASF-CR] IMPALA-9565 Remove unused included file mm malloc.h on ARM

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15586 ) Change subject: IMPALA-9565 Remove unused included file mm_malloc.h on ARM .. Patch Set 7: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-9176: shared null-aware anti-join build

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/15612 ) Change subject: IMPALA-9176: shared null-aware anti-join build .. IMPALA-9176: shared null-aware anti-join build This switches null-awa

[Impala-ASF-CR] IMPALA-9422: Re-visit and improve join node and builder's counters

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15663 ) Change subject: IMPALA-9422: Re-visit and improve join node and builder's counters .. Patch Set 1: (4 comments) The concept makes se

[Impala-ASF-CR] IMPALA-9611: fix hang when cancelling join builder

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15672 Change subject: IMPALA-9611: fix hang when cancelling join builder .. IMPALA-9611: fix hang when cancelling join builder The error coul

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. IMPALA-9545 Decide cacheline size of aarch64 ARM64's L3 cachel

[Impala-ASF-CR] IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt

2020-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15527 ) Change subject: IMPALA-9543 Reduce duplicate code in thrift CMakeLists.txt .. Patch Set 14: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-9545 Decide cacheline size of aarch64

2020-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/1 ) Change subject: IMPALA-9545 Decide cacheline size of aarch64 .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: I need to take another pass ove

[native-toolchain-CR] Build Python with bzip2

2020-04-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15636 ) Change subject: Build Python with bzip2 .. Build Python with bzip2 Change-Id: Iee6e0b68aa9c5973fdcd0e2d7b97b91276ba4304 Review

[native-toolchain-CR] Build Python with bzip2

2020-04-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15636 ) Change subject: Build Python with bzip2 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15636 To unsubsc

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/15624/6/inf

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8

[native-toolchain-CR] Build Python with bzip2

2020-04-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15636 ) Change subject: Build Python with bzip2 .. Patch Set 2: Did you successfully build this? Feel free to send me a pointer to a build ou

<    8   9   10   11   12   13   14   15   16   17   >