[native-toolchain-CR] IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download

2020-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16823 ) Change subject: IMPALA-9985/IMPALA-10011: Update supported platforms, fix Maven download .. Patch Set 2: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-9865: part 1: basic profile log parser

2020-12-07 Thread Tim Armstrong (Code Review)
Hello Riza Suminto, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16821 to look at the new patch set (#4). Change subject: IMPALA-9865: part 1: basic profile log parser

[Impala-ASF-CR] IMPALA-9865: part 1: basic profile log parser

2020-12-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16821 ) Change subject: IMPALA-9865: part 1: basic profile log parser .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16821/

[Impala-ASF-CR] IMPALA-9865: part 1: basic profile log parser

2020-12-07 Thread Tim Armstrong (Code Review)
Hello Riza Suminto, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16821 to look at the new patch set (#3). Change subject: IMPALA-9865: part 1: basic profile log parser

[Impala-ASF-CR] IMPALA-9936: Only send invalidations in DDL responses to LocalCatalog coordinators

2020-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16435 ) Change subject: IMPALA-9936: Only send invalidations in DDL responses to LocalCatalog coordinators .. Patch Set 4: Code-Review+2 (1 c

[Impala-ASF-CR] IMPALA-9865: part 1: basic profile log parser

2020-12-04 Thread Tim Armstrong (Code Review)
Hello Riza Suminto, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16821 to look at the new patch set (#2). Change subject: IMPALA-9865: part 1: basic profile log parser .

[Impala-ASF-CR] IMPALA-9865: part 1: basic profile log parser

2020-12-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16821 Change subject: IMPALA-9865: part 1: basic profile log parser .. IMPALA-9865: part 1: basic profile log parser This adds a utility that

[Impala-ASF-CR] IMPALA-10366: skip test runtime profile aggregated for EC

2020-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16799 ) Change subject: IMPALA-10366: skip test_runtime_profile_aggregated for EC .. IMPALA-10366: skip test_runtime_profile_aggregated

[Impala-ASF-CR] IMPALA-10366: skip test runtime profile aggregated for EC

2020-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16799 Change subject: IMPALA-10366: skip test_runtime_profile_aggregated for EC .. IMPALA-10366: skip test_runtime_profile_aggregated for EC

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 10: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] [WIP] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2020-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: [WIP] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set

[Impala-ASF-CR] IMPALA-9355: TestExchangeMemUsage.test exchange mem usage scaling doesn't hit the memory limit

2020-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16791 ) Change subject: IMPALA-9355: TestExchangeMemUsage.test_exchange_mem_usage_scaling doesn't hit the memory limit .. Patch Set 1: Code-R

[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.

2020-11-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16778 ) Change subject: Fix for startup crash in scheduler-benchmark. .. Fix for startup crash in scheduler-benchmark. Updated schedul

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 18: Code-Review+2 The test was just too sho

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-25 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#18). Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ..

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 17: Looks like I missed updating a test -

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 9: Code-Review+2 (4 comments) Looks g

[Impala-ASF-CR] IMPALA-10216: make TestWriteErrorBlacklist deterministic

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16782 Change subject: IMPALA-10216: make TestWriteErrorBlacklist deterministic .. IMPALA-10216: make TestWriteErrorBlacklist deterministic Th

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 17: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-24 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#17). Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ..

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-24 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#16). Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ..

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 16: Code-Review+2 Carry +2 -- To view, vi

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 15: (4 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#1). ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default

[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default

2020-11-24 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16775 to look at the new patch set (#3). Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .

[Impala-ASF-CR] IMPALA-10351,IMPALA-9812: enable mt dop for DML by default

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16775 ) Change subject: IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default .. IMPALA-10351,IMPALA-9812: enable mt_dop for DML by default

[Impala-ASF-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16780 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. Patch Set 1: I already did this here - https://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-10330: Bump toolchain build id for new Kudu

2020-11-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16735 ) Change subject: IMPALA-10330: Bump toolchain build id for new Kudu .. IMPALA-10330: Bump toolchain build id for new Kudu Chang

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. IMPALA-10288: Implement DESCRIBE HISTORY for Ice

[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit

2020-11-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-10333: Fix utf-8 test failures when impala-shell using older thrift versions

2020-11-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16767 ) Change subject: IMPALA-10333: Fix utf-8 test failures when impala-shell using older thrift versions .. Patch Set 1: Code-Review+2 --

[Impala-ASF-CR] IMPALA-10312: bump timeout in test ddl queries are closed

2020-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16762 Change subject: IMPALA-10312: bump timeout in test_ddl_queries_are_closed .. IMPALA-10312: bump timeout in test_ddl_queries_are_closed

[Impala-ASF-CR] IMPALA-9050: fix TestScanRangeLengths params

2020-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16761 Change subject: IMPALA-9050: fix TestScanRangeLengths params .. IMPALA-9050: fix TestScanRangeLengths params This test is only relevant

[Impala-ASF-CR] IMPALA-4238: make TestClientSsl more robust

2020-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16760 Change subject: IMPALA-4238: make TestClientSsl more robust .. IMPALA-4238: make TestClientSsl more robust This changes the test to wai

[Impala-ASF-CR] IMPALA-10156: test unmatched schema should use unique database

2020-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16758 Change subject: IMPALA-10156: test_unmatched_schema should use unique_database .. IMPALA-10156: test_unmatched_schema should use unique_

[Impala-ASF-CR] IMPALA-10325 Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2020-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325 Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 12: (

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8990: Fix flakiness in test set request pool

2020-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16749 ) Change subject: IMPALA-8990: Fix flakiness in test_set_request_pool .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16748 Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test .. IMPALA-9121: try to avoid ASAN error in hdfs-util-test I coul

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. IMPALA-10189: addendum: improve comment Change-Id: I81c77c26fe60812

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-10189: addendum: improve comment .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/16557 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 2: Hit IMPALA-10316. Going to override since it's so trivial. -

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. IMPALA-10340: Cannot set up KDC from scratch IMPALA-9361 added

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 1: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Makes sense, thanks for taking the initiative to improve

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10276: thread-safe access to RuntimeProfile::counter map

2020-11-17 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16739 to look at the new patch set (#3). Change subject: IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_ ...

[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16724 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. IMPALA-10330 Fix build error on aarch64 platform Recently,

[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. Patch Set 1: Tests passed on the other commit, so I'll merge --

[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7523: increase hbase assignment timeout

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16740 Change subject: IMPALA-7523: increase hbase assignment timeout .. IMPALA-7523: increase hbase assignment timeout Try to avoid flakiness

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10323: use snprintf instead of lexical cast to cast to string

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16719 ) Change subject: IMPALA-10323: use snprintf instead of lexical_cast to cast to string .. Patch Set 1: We also have a relatively low up

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 7: Code-Review+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 ) Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .. Patch Set 6: Ping on this review -- To view, visit http

[Impala-ASF-CR] IMPALA-10330: Bump toolchain build id for new Kudu

2020-11-17 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16735 to look at the new patch set (#2). Change subject: IMPALA-10330: Bump toolchain build id for new Kudu .. I

[Impala-ASF-CR] IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16736 ) Change subject: IMPALA-10305 (part 2): Sync Kudu's FIPS compliant changes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerr

[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. Patch Set 1: https://gerrit.cloudera.org/#/c/16735/ -- To view,

[Impala-ASF-CR] IMPALA-10330: Bump toolchain build id

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16735 Change subject: IMPALA-10330: Bump toolchain build id .. IMPALA-10330: Bump toolchain build id Change-Id: I1d351720bb5322a7ae3c038256f5

[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. Patch Set 1: Build is 62-ab817885e4. I guess we should check that

[Impala-ASF-CR] IMPALA-10323: use snprintf instead of lexical cast to cast to string

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16719 ) Change subject: IMPALA-10323: use snprintf instead of lexical_cast to cast to string .. Patch Set 1: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 2: (4 comments) I have some serious concerns abou

[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. Patch Set 1: I'll do a test build before merging. -- To view, vi

[native-toolchain-CR] IMPALA-10330 Fix build error on aarch64 platform

2020-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16724 ) Change subject: IMPALA-10330 Fix build error on aarch64 platform .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-13 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#15). Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ..

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 12: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-13 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#14). Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ..

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-12 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16057 to look at the new patch set (#13). Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator ..

[Impala-ASF-CR] IMPALA-9382: part 2/3: aggregate profiles sent to coordinator

2020-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16057 ) Change subject: IMPALA-9382: part 2/3: aggregate profiles sent to coordinator .. Patch Set 12: (9 comments) Address the code comments

[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.

2020-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16714 ) Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral. .. IMPALA-10320: Specify expression selectivity f

[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.

2020-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16714 ) Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral. .. Patch Set 1: Code-Review+2 This seems like a no brain

[Impala-ASF-CR] IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows

2020-11-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16712 ) Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 6912987

2020-11-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16701 ) Change subject: Bump up CDP_BUILD_NUMBER to 6912987 .. Bump up CDP_BUILD_NUMBER to 6912987 This change bumps up the CDP_BUILD_

[Impala-ASF-CR] IMPALA-6671: Skip locked tables from topic updates

2020-11-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16549 ) Change subject: IMPALA-6671: Skip locked tables from topic updates .. Patch Set 10: (7 comments) Looking pretty good... http://gerri

[Impala-ASF-CR] IMPALA-6861: Fix OpenSSL initialization

2020-11-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16704 ) Change subject: IMPALA-6861: Fix OpenSSL initialization .. Patch Set 1: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.c

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 6912987

2020-11-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16701 ) Change subject: Bump up CDP_BUILD_NUMBER to 6912987 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 6912987

2020-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16701 ) Change subject: Bump up CDP_BUILD_NUMBER to 6912987 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[Impala-ASF-CR] IMPALA-10305: Sync Kudu's FIPS compliant changes

2020-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16684 ) Change subject: IMPALA-10305: Sync Kudu's FIPS compliant changes .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3816: Codegen perf critical loops in Sorter

2020-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 ) Change subject: IMPALA-3816: Codegen perf critical loops in Sorter .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-6671: Skip locked tables from topic updates

2020-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16549 ) Change subject: IMPALA-6671: Skip locked tables from topic updates .. Patch Set 10: I took a quick look over the changes and I think t

[native-toolchain-CR] IMPALA-10058: Use commit hash as version for Kudu java artifacts

2020-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16685 ) Change subject: IMPALA-10058: Use commit hash as version for Kudu java artifacts .. Patch Set 1: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] Replace some TODOs with specific JIRA references

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11392 ) Change subject: Replace some TODOs with specific JIRA references .. Abandoned Cleaning up some old CRs -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-3825: Distribute Runtime Filtering Aggregation

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11055 ) Change subject: IMPALA-3825: Distribute Runtime Filtering Aggregation .. Abandoned Cleaning up some old CRs -- To view, visit http://gerrit.clo

[Impala-ASF-CR] WIP IMPALA-10305: Sync Kudu security code change for FIPS

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16684 ) Change subject: WIP IMPALA-10305: Sync Kudu security code change for FIPS .. Patch Set 2: Is this still a WIP? I can review once it's

[Impala-ASF-CR] IMPALA-10185 Use bool stats for selectivity calculations.

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16462 ) Change subject: IMPALA-10185 Use bool stats for selectivity calculations. .. Patch Set 2: I'm ready to +2 after the minor code cleanup

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-11-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 ) Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .. Patch Set 5: Updated the commit message as requested. Sh

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-11-02 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16622 to look at the new patch set (#6). Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .

[Impala-ASF-CR] IMPALA-10058: Use commit hash as version for Kudu java artifacts

2020-10-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16686 ) Change subject: IMPALA-10058: Use commit hash as version for Kudu java artifacts .. Patch Set 1: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] WIP: IMPALA-9773: Temporal (ASOF) query support for Kudu tables

2020-10-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13342 ) Change subject: WIP: IMPALA-9773: Temporal (ASOF) query support for Kudu tables .. Patch Set 6: (1 comment) Cool! left a couple of no

[Impala-ASF-CR] WIP: IMPALA-9773: Temporal (ASOF) query support for Kudu tables

2020-10-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed Nong Li from this change. ( http://gerrit.cloudera.org:8080/13342 ) Change subject: WIP: IMPALA-9773: Temporal (ASOF) query support for Kudu tables .. Removed reviewer Nong Li. -- To view, visit http:

[Impala-ASF-CR] IMPALA-10295: fix analytic limit pushdown with no predicates

2020-10-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16663 ) Change subject: IMPALA-10295: fix analytic limit pushdown with no predicates .. Patch Set 4: Code-Review+1 carry +1 -- To view, visi

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-10-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 3: (1 comment) THis is really cool! I had a

[Impala-ASF-CR] IMPALA-10304: Fix log level and format for pytests

2020-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16679 ) Change subject: IMPALA-10304: Fix log level and format for pytests .. Patch Set 1: Code-Review+2 Thank you for debugging and fixing th

[Impala-ASF-CR] IMPALA-10295: fix analytic limit pushdown with no predicates

2020-10-29 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16663 to look at the new patch set (#4). Change subject: IMPALA-10295: fix analytic limit pushdown with no predicates ...

[Impala-ASF-CR] IMPALA-10295: fix analytic limit pushdown with no predicates

2020-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16663 ) Change subject: IMPALA-10295: fix analytic limit pushdown with no predicates .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-10294: Improvement to test skew reporting in runtime profile

2020-10-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16662 ) Change subject: IMPALA-10294: Improvement to test_skew_reporting_in_runtime_profile .. Patch Set 2: Code-Review+2 -- To view, visit

<    1   2   3   4   5   6   7   8   9   10   >