[Impala-ASF-CR] IMPALA-9929: Subquery error should throw AnalysisException

2020-07-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16212 ) Change subject: IMPALA-9929: Subquery error should throw AnalysisException .. Patch Set 2: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8125: Add query option to limit number of hdfs writer instances

2020-07-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16204 ) Change subject: IMPALA-8125: Add query option to limit number of hdfs writer instances .. Patch Set 3: Code-Review+1 (1 comment) htt

[Impala-ASF-CR] IMPALA-9979: part 1: factor out Top-N heap.

2020-07-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16223 ) Change subject: IMPALA-9979: part 1: factor out Top-N heap. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16223/3/b

[Impala-ASF-CR] IMPALA-9987: Improve logging around HTTP connections

2020-07-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16230 ) Change subject: IMPALA-9987: Improve logging around HTTP connections .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6692: Trigger sort node run before hitting memory limit.

2020-07-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15963 ) Change subject: IMPALA-6692: Trigger sort node run before hitting memory limit. .. Patch Set 19: The dockerised tests have memory-base

[Impala-ASF-CR] IMPALA-9979: part 1: factor out Top-N heap.

2020-07-21 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16223 to look at the new patch set (#3). Change subject: IMPALA-9979: part 1: factor out Top-N heap. .. IMPALA-9979: part 1

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-07-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 1: (1 comment) I think we should have enough cov

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. IMPALA-9980: Remove jersey* jars from maven exclusion

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 8: (15 comments) It's obviously a big change but I'

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: I think it would be better to just include jers

[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions

2020-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 1: (1 comment) What was the test gap? Why didn't

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9953: Shell should continue fetching even when 0 rows are returned

2020-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16222 ) Change subject: IMPALA-9953: Shell should continue fetching even when 0 rows are returned .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce)

2020-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 ) Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) .. Patch Set 5: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce)

2020-07-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 ) Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) .. Patch Set 4: (1 comment) http://g

[Impala-ASF-CR] IMPALA-9929: Subquery error should throw AnalysisException

2020-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16212 ) Change subject: IMPALA-9929: Subquery error should throw AnalysisException .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce)

2020-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 ) Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) .. Patch Set 3: Code-Review+1 (1 comm

[Impala-ASF-CR] IMPALA-9903: Reduce Kudu openTable calls per query

2020-07-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16120 ) Change subject: IMPALA-9903: Reduce Kudu openTable calls per query .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce)

2020-07-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16208 ) Change subject: IMPALA-7655: Implement codegen for conditional functions (if, isnull, coalesce) .. Patch Set 1: (3 comments) I'll wa

[Impala-ASF-CR] IMPALA-9833: Bump timeout in TestQueryStates.test error query state

2020-07-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16205 ) Change subject: IMPALA-9833: Bump timeout in TestQueryStates.test_error_query_state .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8125: Add query option to limit number of hdfs writer instances

2020-07-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16204 ) Change subject: IMPALA-8125: Add query option to limit number of hdfs writer instances .. Patch Set 1: (6 comments) I had some initi

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

2020-07-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16195 ) Change subject: Bump up CDP_BUILD_NUMBER to 4493826 .. Bump up CDP_BUILD_NUMBER to 4493826 This change bumps up the CDP_BUILD_

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

2020-07-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 ) Change subject: Bump up CDP_BUILD_NUMBER to 4493826 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[Impala-ASF-CR] IMPALA-9956: inline hot functions in Sorter

2020-07-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16202 Change subject: IMPALA-9956: inline hot functions in Sorter .. IMPALA-9956: inline hot functions in Sorter Add some compiler hints to f

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16180 ) Change subject: IMPALA-1270: add distinct aggregation to semi joins .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16180 ) Change subject: IMPALA-1270: add distinct aggregation to semi joins .. Patch Set 11: Code-Review+1 carry +1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16180 to look at the new patch set (#11). Change subject: IMPALA-1270: add distinct aggregation to semi joins .

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16180 to look at the new patch set (#10). Change subject: IMPALA-1270: add distinct aggregation to semi joins .

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16180 ) Change subject: IMPALA-1270: add distinct aggregation to semi joins .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16180 to look at the new patch set (#9). Change subject: IMPALA-1270: add distinct aggregation to semi joins ..

[Impala-ASF-CR] WIP

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16198 Change subject: WIP .. WIP Change-Id: I2c6b1a1237f057eb5f700bc652f27ace0595320a --- M testdata/workloads/functional-planner/queries/Pl

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16180 ) Change subject: IMPALA-1270: add distinct aggregation to semi joins .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16180 ) Change subject: IMPALA-1270: add distinct aggregation to semi joins .. Patch Set 8: The one query with a plan change was faster in sin

[Impala-ASF-CR] IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16180 to look at the new patch set (#8). Change subject: IMPALA-1270: add distinct aggregation to semi joins ..

[Impala-ASF-CR] WIP: IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16180 to look at the new patch set (#7). Change subject: WIP: IMPALA-1270: add distinct aggregation to semi joins .

[Impala-ASF-CR] WIP: IMPALA-1270: add distinct aggregation to semi joins

2020-07-14 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, David Rorke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16180 to look at the new patch set (#6). Change subject: WIP: IMPALA-1270: add distinct aggregation to semi joins

[Impala-ASF-CR] IMPALA-9478: Profiles should indicate if custom UDFs are being used

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16188 ) Change subject: IMPALA-9478: Profiles should indicate if custom UDFs are being used .. Patch Set 1: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] WIP: IMPALA-9951: put sort before exchange in analytic plans

2020-07-14 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16186 to look at the new patch set (#5). Change subject: WIP: IMPALA-9951: put sort before exchange in analytic plans .

[Impala-ASF-CR] Bump up CDP BUILD NUMBER to 4493826

2020-07-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16195 ) Change subject: Bump up CDP_BUILD_NUMBER to 4493826 .. Patch Set 2: Code-Review+2 Thanks for fixing this -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 17: Verified+1 Code-Review+2 The next patch was verified, verify

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. IMPALA-9917: grouping() and grouping_id() support Impleme

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. IMPALA-9898: generate grouping set plans Integrates the parsing an

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 18: Verified+1 Code-Review+2 This just failed because o

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, Thomas Tauber-Marshall, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#17). Change subject: IMPALA-9898: generate grouping s

[Impala-ASF-CR] WIP: IMPALA-9951: put sort before exchange in analytic plans

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16186 to look at the new patch set (#4). Change subject: WIP: IMPALA-9951: put sort before exchange in analytic plans .

[Impala-ASF-CR] HACK - put sort before exchange in analytic plans

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16186 Change subject: HACK - put sort before exchange in analytic plans .. HACK - put sort before exchange in analytic plans It is enabled by

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 16: Code-Review+2 carry +2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 17: Code-Review+2 carry +2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, Thomas Tauber-Marshall, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#16). Change subject: IMPALA-9898: generate grouping s

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 15: Code-Review+2 (2 comments) carry +2 http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#16). Change subject: IMPALA-9917: grouping() and grouping_id() support ..

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, Thomas Tauber-Marshall, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#15). Change subject: IMPALA-9898: generate grouping s

[Impala-ASF-CR] IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16171 to look at the new patch set (#7). Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT ..

[Impala-ASF-CR] IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16171 ) Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT .. Patch Set 7: Code-Review+2 rebase -- To view, visit htt

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#14). Change subject: IMPALA-9898: generate grouping set plans ...

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#15). Change subject: IMPALA-9917: grouping() and grouping_id() support ...

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 15: Code-Review+1 rebased, carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 14: Code-Review+1 rebased, carry +1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16171 ) Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16171 ) Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT .. Patch Set 6: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT

2020-07-13 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16171 to look at the new patch set (#6). Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT .

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-9924: handle single subquery in or predicate .. IMPALA-9924: handle single subquery in or predicate Thi

[Impala-ASF-CR] IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT

2020-07-12 Thread Tim Armstrong (Code Review)
Hello Shant Hovsepian, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16171 to look at the new patch set (#5). Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT .

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 14: Code-Review+1 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-9924: handle single subquery in or predicate .. Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, Zoltan Borok-Nagy, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16152 to look at the new patch set (#13). Change subject: IMPALA-9924: handle single subquery in or predicate .

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-9924: handle single subquery in or predicate .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-9924: handle single subquery in or predicate .. Patch Set 12: There were a couple of code changes in StmtRewrit

[Impala-ASF-CR] IMPALA-3127: Support incremental metadata updates in partition level

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16159 ) Change subject: IMPALA-3127: Support incremental metadata updates in partition level .. Patch Set 1: I took a first pass over it and

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-9924: handle single subquery in or predicate .. Patch Set 12: I found some issues with certain expr types and s

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-9924: handle single subquery in or predicate .. Patch Set 12: This does need another review pass. -- To view,

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, Zoltan Borok-Nagy, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16152 to look at the new patch set (#12). Change subject: IMPALA-9924: handle single subquery in or predicate .

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-10 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, Zoltan Borok-Nagy, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16152 to look at the new patch set (#11). Change subject: IMPALA-9924: handle single subquery in or predicate .

[Impala-ASF-CR] IMPALA-9940: add missing kudu protobuf deps

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16164 ) Change subject: IMPALA-9940: add missing kudu protobuf deps .. IMPALA-9940: add missing kudu protobuf deps Parts of Impala hav

[Impala-ASF-CR] IMPALA-9940: add missing kudu protobuf deps

2020-07-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16164 Change subject: IMPALA-9940: add missing kudu protobuf deps .. IMPALA-9940: add missing kudu protobuf deps Parts of Impala have transit

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-9924: handle single subquery in or predicate .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-9924: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, Zoltan Borok-Nagy, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16152 to look at the new patch set (#10). Change subject: IMPALA-9924: handle single subquery in or predicate .

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] WIP

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16163 to look at the new patch set (#2). Change subject: WIP .. WIP Change-Id: Iee4b92722fb513aacdeb7245f398f6e

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 9: Code-Review+1 carry -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, Zoltan Borok-Nagy, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16152 to look at the new patch set (#9). Change subject: IMPALA-5226: handle single subquery in or predicate ..

[Impala-ASF-CR] WIP

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16163 Change subject: WIP .. WIP Change-Id: Iee4b92722fb513aacdeb7245f398f6e1891b6bde --- M fe/src/main/java/org/apache/impala/analysis/StmtR

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#14). Change subject: IMPALA-9917: grouping() and grouping_id() support ...

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16140 to look at the new patch set (#13). Change subject: IMPALA-9917: grouping() and grouping_id() support ...

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#13). Change subject: IMPALA-9898: generate grouping set plans ...

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16128 ) Change subject: IMPALA-9898: generate grouping set plans .. Patch Set 11: (4 comments) Addressed the comments. Some good points about

[Impala-ASF-CR] IMPALA-9898: generate grouping set plans

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Quanlong Huang, Fang-Yu Rao, Qifan Chen, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16128 to look at the new patch set (#12). Change subject: IMPALA-9898: generate grouping set plans ...

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 7: (7 comments) > Thanks for adding this rewrite (I

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16152 to look at the new patch set (#8). Change subject: IMPALA-5226: handle single subquery in or predicate ..

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 7: Exhaustive tests passed (except for the tests/infr

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 7: Code-Review+1 carry +1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16152 to look at the new patch set (#7). Change subject: IMPALA-5226: handle single subquery in or predicate ..

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/1

<    3   4   5   6   7   8   9   10   11   12   >