[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-09 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9238 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 2: I manually triggered a gerrit-verify-dryrun-external.

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-07 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9238 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 1: @Tim, I've fixed the compiling error on centos 6.4. W

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-07 Thread Xianda Ke (Code Review)
Xianda Ke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9238 Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. IMPALA-6219: Use AES-GCM for spill-to-disk encryption AES-GCM can b

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-03 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 14: Hi Sailesh, I've fixed the clang-tidy issue. And th

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-03 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#14). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-02-03 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#13). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-31 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 11: fix merge conflict & slight change (move a #include

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-31 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#11). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-30 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 10: Thank you for the review. I'll fix the merge conflic

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-30 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 10: (1 comment) > (1 comment) Yes. It could be false i

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-29 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#10). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 9: Thank Tim a lot for the review. @Sailesh, would you

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#9). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#8). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-22 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#7). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-21 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 6: (4 comments) > Patch Set 6: Published edit on patch

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-21 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#6). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-21 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#5). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-17 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 4: Hi folks, Would you please help review when you are a

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-17 Thread Xianda Ke (Code Review)
Xianda Ke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9032 Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. IMPALA-6219: Use AES-GCM for spill-to-disk encryption AES-GCM can b

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

2018-01-05 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8861 ) Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be a perfo

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

2018-01-04 Thread Xianda Ke (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8861 to look at the new patch set (#4). Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

2017-12-28 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8861 ) Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be a perfo

[Impala-ASF-CR] IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and is secure when used with a different nonce/IV for every message. However it can be

2017-12-27 Thread Xianda Ke (Code Review)
Hello Sailesh Mukil, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8861 to look at the new patch set (#3). Change subject: IMPALA-6128: Add support for AES-CTR encryption when spilling to disk CFB mode is a stream cipher and

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow CFB mode is stream cipher and is secure when use different nonce/IV for every message. However it would be a performance

2017-12-24 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8861 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow CFB mode is stream cipher and is secure when use different nonce/IV for every message. However it would be a performance bottlen

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow CFB mode is stream cipher and is secure when use different nonce/IV for every message. However it would be a performance

2017-12-18 Thread Xianda Ke (Code Review)
Xianda Ke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8861 Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow CFB mode is stream cipher and is secure when use different nonce/IV for every message. However it would be a performance bottlen

[Impala-ASF-CR] IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow"

2017-11-20 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8597 ) Change subject: IMPALA-6220: Revert "IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow" .. Patch Set 1: Code-Review+1 > Assi

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-18 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 6: (1 comment) Thank Sailesh for review. fixe

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-18 Thread Xianda Ke (Code Review)
Hello Jim Apple, Mike Yoder, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8510 to look at the new patch set (#6). Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow ...

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-18 Thread Xianda Ke (Code Review)
Hello Jim Apple, Mike Yoder, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8510 to look at the new patch set (#5). Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow ...

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-16 Thread Xianda Ke (Code Review)
Hello Jim Apple, Mike Yoder, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8510 to look at the new patch set (#4). Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow ...

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-16 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 2: > Thanks for doing this. It seems reasonabl

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-16 Thread Xianda Ke (Code Review)
Hello Jim Apple, Mike Yoder, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8510 to look at the new patch set (#3). Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow ...