[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Rahul Shivu Mahadev (Code Review)
Hello Thomas Marshall, Jim Apple, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10560 to look at the new patch set (#2). Change subject: Fix Indents from IMPALA-4970

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: > Thanks for your contribution! > > One nit about the commit mess

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10560 To

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: We hadn't really opened up commits yet, but this one seems safe. I'm gues

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: > We hadn't really opened up commits yet, but this one seems safe. > I'm

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Thanks! Sorry to be pedantic -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-ver

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Pretty sure this was an OOM due to https://issues.apache.org/jira/browse

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 2: Verified+1 It's a whitespace-only change and it compiled. -- To view, v

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: Fix Indents from IMPALA-4970 .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/10560 To unsubscribe, visit http://g

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

[Impala-ASF-CR] Fix Indents from IMPALA-4970

2018-06-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 .. Patch Set 3: Verified+1 > It's a whitespace-only change and it compiled. Thanks for t

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10560 Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Fix Indents from IMPALA-4970 fi

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: Code-Review+2 -- To v

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: Has anyone told you

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Rahul Shivu Mahadev (Code Review)
Rahul Shivu Mahadev has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: > Has anyone tol

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: Same info, but its her

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-06-01 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: Thanks for your contributi