[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 9: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 9: (6 comments) Looks good to me! http://gerrit.clouder

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/17306

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread fifteencai (Code Review)
fifteencai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 11: Thanks a lot to Quanlong and Qifan !!! I have reworde

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 11: (2 comments) Looks good! http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-13 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 11: Build Failed https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 12: Code-Review+1 Looks good! -- To view, visit http://

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 13: (7 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 13: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 14: (4 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 14: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 15: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-14 Thread fifteencai (Code Review)
fifteencai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 15: Resolved assert problem in newly added unit tests.

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 15: Code-Review+1 (5 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-15 Thread fifteencai (Code Review)
fifteencai has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query option This is a new way

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 16: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 16: Code-Review+1 LGTM. Give +1 first in case others

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-20 Thread fifteencai (Code Review)
fifteencai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 16: Hi, Can we merge this patch now? -- To view, visit

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-20 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 16: Code-Review+2 > Hi, Can we merge this patch now?

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 17: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 17: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. IMPALA-10445: Adjust NDV's scale with query optio

[Impala-ASF-CR] IMPALA-10445: Adjust NDV's scale with query option

2021-04-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 ) Change subject: IMPALA-10445: Adjust NDV's scale with query option .. Patch Set 17: Verified+1 -- To view, visit http://gerri