[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 27: Oh, looks like you ran the verify job without 'd

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 26: Verified+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. IMPALA-10496: SAML implementation in Impala The bulk of

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 26: Code-Review+2 (1 comment) Looks good, just one

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 25: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 26: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 25: (11 comments) http://gerrit.cloudera.org:8080/#/c/1683

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 25: (16 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-17 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#25). Change subject: IMPALA-10496: SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 24: Code-Review+1 (1 comment) Patch looks good to me.

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 24: (10 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 24: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 24: (13 comments) http://gerrit.cloudera.org:8080/#/c/1683

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 24: (16 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-16 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#24). Change subject: IMPALA-10496: SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-16 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 23: (14 comments) I mostly have some minor suggestions

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 23: Verified+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 22: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 23: PS 22 is a one line fix for the ldap test failures intr

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 23: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 22: (37 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-10 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#22). Change subject: IMPALA-10496: SAML implementation in Impala ..

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 21: Verified-1 Build failed: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 20: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 21: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. Patch Set 20: (37 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10496: SAML implementation in Impala

2021-02-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#20). ( http://gerrit.cloudera.org:8080/16833 ) Change subject: IMPALA-10496: SAML implementation in Impala .. IMPALA-10496: SAML implementation in Impala The bulk of the SAML2 rela