[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. IMPALA-11628: Switch to reload4j, update slf4j Switches from

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 3: Code-Review+2 This makes sense to me. I think this appr

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Removed Code-Review-2 by Joe McDonnell -- To view, visit http://gerrit.cloudera.org:8080/19102 To unsubscribe, v

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 3: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 2: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 3: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-07 Thread Michael Smith (Code Review)
Hello Riza Suminto, Yida Wu, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19102 to look at the new patch set (#3). Change subject: IMPALA-11628: Switch to reload4j, update slf4j ...

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-07 Thread Michael Smith (Code Review)
Hello Riza Suminto, Yida Wu, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19102 to look at the new patch set (#2). Change subject: IMPALA-11628: Switch to reload4j, update slf4j ...

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Yeah, that's the direction I'm heading down. Ban log4j:

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: -Code-Review Removing my vote following Joe's comment.

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: I think we would end up wanting to add log4j to banned

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: (I'm only -2ing so no one gets tempted to click submit.

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Code-Review-2 When I build locally, log4j is still pres

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Code-Review+2 Looks good. Thank you for taking care of t

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: > Patch Set 1: Code-Review+1 > > LGTM! > Just curious a

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Code-Review+1 LGTM! Just curious about the version, saw 1.7.3

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19102 Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. IMPALA-11628: Switch to reload4j, update slf4j Switch from log4j 1.x