[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8574 Change subject: IMPALA-5936: operator '%' overflows on large decimals .. IMPALA-5936: operator '%' overflows on large decimals Suppo

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 1: (2 comments) Makes perfect sense to me. Taras sh

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 1: (2 comments) Thanks! http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8574 to look at the new patch set (#2). Change subject: IMPALA-5936: operator '%' overflows on large decimals

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 2: Code-Review+1 Taras, please do the +2 review on this

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-21 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8574 to look at the new patch set (#3). Change subject: IMPALA-5936: operator '%' overflows on large decimals .

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 3: (2 comments) Thanks. http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 3: Code-Review+2 Looks good! -- To view, visit

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-28 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 3: Thanks! Could someone run the verification?

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 4: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. Patch Set 4: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-5936: operator '%' overflows on large decimals

2017-11-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8574 ) Change subject: IMPALA-5936: operator '%' overflows on large decimals .. IMPALA-5936: operator '%' overflows on large de