[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-12-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 4: (9 comments) Refactor looks fine

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-12-02 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 4: Pre-review tests passed: https://jenkins.im

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 4: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 4: (1 comment) Cleaned up the API a bit. Reba

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#4). Change subject: IMPALA-7842: Make query fragments available for unit testing

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 3: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#3). Change subject: IMPALA-7842: Make query fragments available for unit testing ..

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 3: Rebased on latest master. Bharath, can you

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 2: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 2: (2 comments) Thanks, Phil, for the review.

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-13 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#2). Change subject: IMPALA-7842: Make query fragments available for unit testing ..

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 1: (2 comments) Structure seems fine to m

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 1: Build Successful https://jenkins

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-11 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11920 Change subject: IMPALA-7842: Make query fragments available for unit testing .. IMPALA-7842: Make query fragments available for unit testi

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-11 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 1: Dry-run tests passed: https://jenkins.impal