[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. IMPALA-7905: Hive keywords not quoted for iden

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 13: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 13: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 13: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: (1 comment) Addressed the code review comment.

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#12). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-22 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Code-Review+2 (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-22 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Pre-review tests now pass again. Please go ahead

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-21 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Looks like some e-to-e test "golden" files need u

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-21 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#11). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 10: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 10: Rebased on latest master. Added a few minor outpu

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-19 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#10). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 9: Looks like there are some failed tests. P

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 9: Verified-1 Build failed: https://jenkins

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 9: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 9: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 8: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 8: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 7: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 7: (2 comments) Addressed recent review comments. h

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#8). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers ..

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#7). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers ..

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: Rebased on latest master to resolve merge conflict

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: Code-Review+2 (3 comments) http://gerrit

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-26 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#6). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers ..

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 5: (6 comments) Few minor comments, lgtm ot

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 5: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-16 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#5). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers ..

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 4: Build Failed https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 3: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 3: (2 comments) Addressed review comments. Rebased o

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#4). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#3). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 2: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-13 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#2). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: Paul, I think you need to rebase this. -- To vi

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: (2 comments) Just couple nits, but it looks good

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: Pre-commit tests ran: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: This one is just a nuisance fix. Can you take a lo

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12009 Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. IMPALA-7905: Hive keywords not quoted for identifiers Impala oft