[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admiss

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 6: Verified+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 6: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 6: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 6: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 5: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 5: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 5: One more fix to remove an 'inline' which ge

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 4: Verified-1 Build failed: https://jen

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 4: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 4: Code-Review+2 -- To view, visit htt

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 3: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 3: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) Thanks Bikram, see patch set

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) looks good, just a few nits

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: Code-Review+1 I'll let Bikram take it to +2.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 2: (4 comments) Thanks Tim. I made fixes in p

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 1: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13078 ) Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. Patch Set 1: (5 comments) Looks good overall. I think Bi

[Impala-ASF-CR] IMPALA-8446: Create a unit test for Admission Controller.

2019-04-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13078 Change subject: IMPALA-8446: Create a unit test for Admission Controller. .. IMPALA-8446: Create a unit test for Admission Controller.