[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-08-30 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#24). Change subject: IMPALA-8571: harden QueryEventHook execution ..

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 24: Build Failed https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-08-30 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#25). Change subject: IMPALA-8571: harden QueryEventHook execution ..

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-08-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 25: Build Successful https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-16 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 25: I'll take a deeper look at this today. Thanks for

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 25: (9 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#26). Change subject: IMPALA-8571: harden QueryEventHook execution ..

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 26: (5 comments) Addressed some nits; still need to look i

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#27). Change subject: IMPALA-8571: harden QueryEventHook execution ..

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 26: (1 comment) Missed a nit... http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 26: Build Successful https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-09-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 27: Build Failed https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-03 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 27: Ok, I've come up with a simpler timeout-monitor impleme

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#28). Change subject: IMPALA-8571: harden QueryEventHook execution ..

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (1 comment) I've implemented a simpler approach as sug

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: Build Successful https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (1 comment) added some detail to the comment that need

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (25 comments) Hi Radford. As Bharath and Fredy have di

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-17 Thread radford nguyen (Code Review)
radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (6 comments) > Patch Set 28: > > (25 comments) > > Hi

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 29: Build Successful https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-17 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#29). Change subject: IMPALA-8571: harden QueryEventHook execution ..

[Impala-ASF-CR] IMPALA-8571: harden QueryEventHook execution

2019-10-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571: harden QueryEventHook execution .. Patch Set 28: (5 comments) Just a few replies to your useful comment