[Impala-ASF-CR] Update .gitignore with VSCode artifacts

2020-01-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Update .gitignore with VSCode artifacts Added .vscode/ dire

[Impala-ASF-CR] Update .gitignore with VSCode artifacts

2020-01-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] Update .gitignore with VSCode artifacts

2020-01-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-ve

[Impala-ASF-CR] Update .gitignore with VSCode artifacts

2020-01-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] Update .gitignore with VSCode artifacts

2020-01-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] Update .gitignore with VSCode artifacts

2020-01-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] Update .gitignore with VSCode artifacts

2020-01-17 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15061 Change subject: Update .gitignore with VSCode artifacts .. Update .gitignore with VSCode artifacts Added .vscode/ directory to .git

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14858 To

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Update gitignore files This adds in a handful of files that I had on my loca

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5318/

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14858

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.org:8080/14858 T

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-chec

[Impala-ASF-CR] Update gitignore files

2019-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14858 Change subject: Update gitignore files .. Update gitignore files This adds in a handful of files that I had on my local machine Change

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsub

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Update .gitignore A few unversioned artifacts crept in over time without correspo

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3367/ DRY

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscrib

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 4: (3 comments) I added the requested files. I don't think it really makes sense for m

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3366/ DRY

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11787 to look at the new patch set (#4). Change subject: Update .gitignore .

[Impala-ASF-CR] Update .gitignore

2018-10-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/11787/3/.giti

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+1 Thanks! I've found a few more additions, many around the use of Eclipse.

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+1 Thanks for doing this! LGTM. -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/11

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Hello Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11787 to look at the new patch set (#3). Change subject: Update .gitignore .. Update .gitignore A few unversioned artifa

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 2: I think I addressed the ones you mentioned. I don't use some of those IDEs - intell

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Hello Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11787 to look at the new patch set (#2). Change subject: Update .gitignore .. Update .gitignore A few unversioned artifa

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 1: We need to ignore more. These are files that I think should also be ignored. $IMPALA

[Impala-ASF-CR] Update .gitignore

2018-10-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11787 Change subject: Update .gitignore .. Update .gitignore A few unversioned artifacts crept in over time without corresponding .gitignore