[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-22 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#2). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 4: Hmm. I've been thinking about it and since

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 2: Code-Review+2 Thanks for the clean up.

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 7: Had a chat with Paul

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-12-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 ) Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer .. Patch Set 3: Code-Review+1 Fredy, could you +2 when you

[Impala-ASF-CR] IMPALA-7914: Base class for statement-like AST nodes

2018-12-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base class for statement-like AST nodes .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7939: Fix issue where CTE is categorized as DML statement

2018-12-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12052 ) Change subject: IMPALA-7939: Fix issue where CTE is categorized as DML statement .. Patch Set 6: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-7945: Fix test hdfs timeout.py on python 2.6

2018-12-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12059 ) Change subject: IMPALA-7945: Fix test_hdfs_timeout.py on python 2.6 .. Patch Set 1: Phil, does it help to use a more powerful

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 10: Code-Review+1 (3 comments) The code flow

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 3: That looks related to your change.

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 5: Code-Review+2 (2 comments)

[Impala-ASF-CR] Remove Python 2.4 workarounds in start-impala-cluster.py

2018-12-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12100 ) Change subject: Remove Python 2.4 workarounds in start-impala-cluster.py .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12096 ) Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. IMPALA-7989: Revert

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12105 Change subject: IMPALA-7864: Deflake test_replan_limit .. IMPALA-7864: Deflake test_replan_limit - Doubles the number of

[Impala-ASF-CR] IMPALA-7992: Revert "Symbolize stacktraces in debug builds."

2018-12-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12115 ) Change subject: IMPALA-7992: Revert "Symbolize stacktraces in debug builds." .. Patch Set 2: Code-Review+2 (1 comment) Tim, I

[Impala-ASF-CR] IMPALA-7992: Revert "Symbolize stacktraces in debug builds."

2018-12-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12115 ) Change subject: IMPALA-7992: Revert "Symbolize stacktraces in debug builds." .. IMPALA-7992: Revert "Symbolize

[Impala-ASF-CR] IMPALA-7992: Revert "Symbolize stacktraces in debug builds."

2018-12-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12115 ) Change subject: IMPALA-7992: Revert "Symbolize stacktraces in debug builds." .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7992: Revert "Symbolize stacktraces in debug builds."

2018-12-20 Thread Bharath Vissapragada (Code Review)
Hello Philip Zeyliger, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12115 to look at the new patch set (#2). Change subject: IMPALA-7992: Revert "Symbolize stacktraces in debug builds."

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 5: (6 comments) Few minor comments, lgtm

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: (7 comments)

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 16: This seems to be the problem. 22:55:24 ]

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 15: Code-Review+2 Carrying +2. -- To view, visit

[Impala-ASF-CR] IMPALA-7970 : Add support for automatic invalidates by polling metastore events

2018-12-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for automatic invalidates by polling metastore events .. Patch Set 8: (46 comments)

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-7992: Reduce iterations for test decimal fuzz.

2018-12-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12126 ) Change subject: IMPALA-7992: Reduce iterations for test_decimal_fuzz. .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8016: Fix lifecycle of classloader for UDFs.

2018-12-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12125 ) Change subject: IMPALA-8016: Fix lifecycle of classloader for UDFs. .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 4: (9 comments) Minor comments. Core of the

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py"

2018-12-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12096 Change subject: IMPALA-7989: Revert "Remove Python 2.4 workarounds in start-impala-cluster.py" .. IMPALA-7989: Revert "Remove

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Bharath Vissapragada (Code Review)
Hello Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12105 to look at the new patch set (#2). Change subject: IMPALA-7864: Deflake test_replan_limit ..

[Impala-ASF-CR] IMPALA-7864: Deflake test replan limit

2018-12-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12105 ) Change subject: IMPALA-7864: Deflake test_replan_limit .. Patch Set 2: Code-Review+2 Removed debug logging. Carrying +2. --

[Impala-ASF-CR] Revert "Symbolize stacktraces in debug builds."

2018-12-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12115 Change subject: Revert "Symbolize stacktraces in debug builds." .. Revert "Symbolize stacktraces in debug builds." This reverts

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7978: [DOCS] Clarify the memory requirements

2018-12-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12081 ) Change subject: IMPALA-7978: [DOCS] Clarify the memory requirements .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-29 Thread Bharath Vissapragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11926 to look at the new patch set (#3). Change subject: Add a handy tool to collapse threads in pstacks

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 ) Change subject: Add a handy tool to collapse threads in pstacks .. Patch Set 3: Looks like RAT doesn't work with non-Apache

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 ) Change subject: Add a handy tool to collapse threads in pstacks .. Patch Set 3: Code-Review+2 Carrying +2. (RAT check passes

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 7: Code-Review+2 I think the overall idea makes sense to me.

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 6: (2 comments) I fixed the tests

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 6: Reviewers, please hold off until

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11926 ) Change subject: Add a handy tool to collapse threads in pstacks .. Patch Set 2: Reached out to Mark Callaghan via email. He

[Impala-ASF-CR] Add a handy tool to collapse threads in pstacks

2018-11-29 Thread Bharath Vissapragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11926 to look at the new patch set (#2). Change subject: Add a handy tool to collapse threads in pstacks

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 6: (1 comment) Any reviews on this

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 3: Gabor, it is not clear from

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 10: Tim, I can take a look at this one. -- To

[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes

2018-12-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12018 ) Change subject: IMPALA-7914: Base interface for statement-like AST nodes .. Patch Set 2: Code-Review+2 (4 comments) Nice

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 5: I think you missed a few comments outside

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#7) to the change originally created by piotr.findei...@gmail.com. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: (1 comment) Rebased. Core and

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-12-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Make query fragments available for unit testing .. Patch Set 4: (9 comments) Refactor looks fine

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-30 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7842: Expose physical plan for unit testing

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 ) Change subject: IMPALA-7842: Expose physical plan for unit testing .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-05 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 7: Code-Review-1 (2 comments) Tim,

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 4: I did a quick pass on the

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#9) to the change originally created by piotr.findei...@gmail.com. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 4: Oh wait, I just saw the thread

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 4: The build seems to be hung for

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#8) to the change originally created by piotr.findei...@gmail.com. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 9: Tim/Paul: Mind taking another

[Impala-ASF-CR] IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11890 ) Change subject: IMPALA-7821: Refactor ExprRewriteRulesTest for easier debugging .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 9: It looks like there are a few genuine test failures here.

[Impala-ASF-CR] IMPALA-7659: Populate NULL count while computing column stats

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Populate NULL count while computing column stats .. Patch Set 9: Code-Review+2 Carrying +2. --

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 11: (7 comments) The code looks fine to

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 3: Looks like this slipped

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7659: Simplify expression to collect NULLs count

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Simplify expression to collect NULLs count .. Patch Set 5: Thanks, Piotr for getting back. I'll

[Impala-ASF-CR] IMPALA-7839: Remove code duplication for getting a unique catalog object name

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11928 ) Change subject: IMPALA-7839: Remove code duplication for getting a unique catalog object name .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7881: Visualize AST for easier debugging

2018-11-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11980 ) Change subject: IMPALA-7881: Visualize AST for easier debugging .. Patch Set 2: Pretty cool, thanks for doing this. -- To

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. Patch Set 2: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions()

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11641 ) Change subject: IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions() .. Patch Set 1: Can this be abandoned

[Impala-ASF-CR] IMPALA-7541. Avoid initializing Metrics for IncompleteTables

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/11393 ) Change subject: IMPALA-7541. Avoid initializing Metrics for IncompleteTables .. Abandoned Todd, abandoning for now, doesn't look like

[Impala-ASF-CR] IMPALA-7409. CatalogObjectVersionSet should not allow duplicates

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/11151 ) Change subject: IMPALA-7409. CatalogObjectVersionSet should not allow duplicates .. Abandoned Abandoning for now, feel free to reopen.

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 17: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: Code-Review+2 (3 comments)

[Impala-ASF-CR] [PROTOTYPE] IMPALA-5872: Test case builder for query planner

2019-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12221 Change subject: [PROTOTYPE] IMPALA-5872: Test case builder for query planner .. [PROTOTYPE] IMPALA-5872: Test case builder for

[Impala-ASF-CR] [PROTOTYPE] IMPALA-5872: Test case builder for query planner

2019-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: [PROTOTYPE] IMPALA-5872: Test case builder for query planner .. Patch Set 1: The following example exports a

[Impala-ASF-CR] IMPALA-8021: Add estimated cardinality to EXPLAIN output

2019-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12136 ) Change subject: IMPALA-8021: Add estimated cardinality to EXPLAIN output .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 9: Looks like there are some failed tests.

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 19: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 18: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7867 (Part 4): Collection cleanup in catalog

2019-01-09 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12131 ) Change subject: IMPALA-7867 (Part 4): Collection cleanup in catalog .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2019-01-03 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 14: Code-Review+2 (8 comments) just a

[Impala-ASF-CR] IMPALA-3819: Clarify stale block metadata warning message

2018-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11433 Change subject: IMPALA-3819: Clarify stale block metadata warning message .. IMPALA-3819: Clarify stale block metadata warning

[Impala-ASF-CR] IMPALA-3819: Clarify stale block metadata warning message

2018-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11433 ) Change subject: IMPALA-3819: Clarify stale block metadata warning message .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata .. Patch Set 4: Code-Review+2

<    1   2   3   4   5   6   7   8   9   10   >