[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-18 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 8: (3 comments)

[Impala-ASF-CR] IMPALA-8034: Improve planner tests

2019-01-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12145 Change subject: IMPALA-8034: Improve planner tests .. IMPALA-8034: Improve planner tests The FE PlannerTest cases are good, but often

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-21 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#11). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-21 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12248 Change subject: IMPALA-8095: Detailed expression cardinality tests .. IMPALA-8095: Detailed expression cardinality tests Cardinality is

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-21 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Looks like some e-to-e test "golden" files need

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#12). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 2: Rebased on latest master. A catalog_.close() line

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11915 to look at the new patch set (#3). Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: (1 comment) Addressed the code review comment.

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11953 to look at the new patch set (#3). Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 2: Rebased on latest master to resolve

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#3). Change subject: IMPALA-8095: Detailed expression cardinality tests ..

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12143 to look at the new patch set (#2). Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 2: Rebased on latest master. Resolved check style

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 3: (1 comment) Addressed review comment.

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 1: Hi Bharath, this one should be a simple one; please

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 8: Hi Bharath, Fredy gave this a +1. Can you take a

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 22: (3 comments) Thanks much

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 2: (3 comments) Minor suggestions, otherwise looks pretty

[Impala-ASF-CR] IMPALA-7929. Impala query on HBASE table failing with InternalException.

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 ) Change subject: IMPALA-7929. Impala query on HBASE table failing with InternalException. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#4). Change subject: IMPALA-8095: Detailed expression cardinality tests

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 4: Fixed check style issues. -- To view, visit

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12144 to look at the new patch set (#3). Change subject: IMPALA-8041, Part 2: Refactor SELECT list

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 2: (6 comments) Thanks Fredy for the review. Addressed your

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 8: Code-Review+1 LGTM -- To view,

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12192 to look at the new patch set (#3). Change subject: IMPALA-8058: Fallback for HBase key scan range estimation

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-17 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 21: (32 comments) Very nice

[Impala-ASF-CR] [PROTOTYPE] IMPALA-5872: Test case builder for query planner

2019-01-17 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: [PROTOTYPE] IMPALA-5872: Test case builder for query planner .. Patch Set 1: (8 comments) Very nice. Far simpler than

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-19 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#10). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 10: Rebased on latest master. Added a few minor

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-10 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#10). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-10 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 9: Fixed the build issue; it resulted from an earlier fix in response

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-12 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#11). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-12 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 4: (10 comments) Revised based on review comments.

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-12-12 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11995 ) Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer .. Patch Set 3: Thanks much for the reviews. Rebased on latest

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-12 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12016 ) Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code .. Patch Set 3: Failure seems to be in one of the Python tests:

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-12 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Greg Rahn, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11955 to look at the new patch set (#5). Change subject: IMPALA-7844: HAVING clause cannot support ordinals

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-13 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#2). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-12-13 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11995 to look at the new patch set (#4). Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 8: Rebased on latest master. Added a

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-13 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#12). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-12-13 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#8) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file ..

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Paul Rogers (Code Review)
Paul Rogers has removed Tim Armstrong from this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Removed reviewer Tim Armstrong. -- To view, visit

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 16: Bharath, thanks for kicking off the build. Noticed the

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-21 Thread Paul Rogers (Code Review)
Paul Rogers has removed Fredy Wijaya from this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Removed reviewer Fredy Wijaya. -- To view, visit

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-26 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#17). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 17: (1 comment) Bharath, thanks for the reviews. Going to

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-26 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#18). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-8016: Fix lifecycle of classloader for UDFs.

2018-12-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12125 ) Change subject: IMPALA-8016: Fix lifecycle of classloader for UDFs. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 18: The pre-commit tests passed; this is ready for another

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-26 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#6). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-7867 (Part 3): ArrayList cleanup in planner

2018-12-15 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12094 Change subject: IMPALA-7867 (Part 3): ArrayList cleanup in planner .. IMPALA-7867 (Part 3): ArrayList cleanup in planner Continues the

[Impala-ASF-CR] IMPALA-7867 (Part 3): ArrayList cleanup in planner

2018-12-15 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12094 ) Change subject: IMPALA-7867 (Part 3): ArrayList cleanup in planner .. Patch Set 2: Pre-review tests passed:

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 12: (14 comments) Coming along nicely. A few more

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2018-12-13 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11953 to look at the new patch set (#2). Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-13 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12079 Change subject: IMPALA-7968, Part 1: JSON serialization framework .. IMPALA-7968, Part 1: JSON serialization framework Provides a set of

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2018-12-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 2: Rebased on latest master -- To view,

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 5: Rebased on latest master. Pre-review tests pass:

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-16 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#5). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-16 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#14). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-16 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#15). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Greg Rahn, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11955 to look at the new patch set (#6). Change subject: IMPALA-7844: HAVING clause cannot support ordinals

[Impala-ASF-CR] IMPALA-7844: HAVING clause cannot support ordinals

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11955 ) Change subject: IMPALA-7844: HAVING clause cannot support ordinals .. Patch Set 5: (3 comments) Thanks for the additional comments.

[Impala-ASF-CR] IMPALA-7915: Wrap SQL parser to avoid redundant code

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12016 to look at the new patch set (#4). Change subject: IMPALA-7915: Wrap SQL parser to avoid redundant code

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#12). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 13: Seeing a pre-review test failure; need to investigate.

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: Thanks much for making the changes: the code is

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11881 to look at the new patch set (#11). Change subject: IMPALA-7807: Analysis test fixture

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-14 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#13). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 11: (6 comments) Thanks for the reviews. Addressed comments and

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 4: > To what extent is this the Jackson streaming API?

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#4). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 3: (2 comments) Addressed review comments. Rebased

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#2). Change subject: IMPALA-7968, Part 1: JSON serialization framework ..

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#4). Change subject: IMPALA-7968, Part 1: JSON serialization framework

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 3: (19 comments)

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12079 to look at the new patch set (#3). Change subject: IMPALA-7968, Part 1: JSON serialization framework

[Impala-ASF-CR] IMPALA-7807: Analysis test fixture

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11881 ) Change subject: IMPALA-7807: Analysis test fixture .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-7795: Implement REFRESH AUTHORIZATION statement

2018-12-14 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11888 ) Change subject: IMPALA-7795: Implement REFRESH AUTHORIZATION statement .. Patch Set 13: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-12-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 11: (3 comments) Made requested changes. However, the

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-12-14 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#3). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: Pre-commit tests ran:

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 5: Bharath, Fredy: this patch introduces some significant

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12009 Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. IMPALA-7905: Hive keywords not quoted for identifiers Impala

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Patch Set 5: Pre-commit tests passed:

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 1: This one is just a nuisance fix. Can you take a

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file .. Patch Set 7: Cleaned up the unit tests a bit

[Impala-ASF-CR] IMPALA-7047. Refreshing partitions should not make an RPC per file

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11227 ) Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file ..

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11993 ) Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test .. Patch Set 3: Tim, thanks for the review

[Impala-ASF-CR] IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

2018-11-28 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11993 to look at the new patch set (#3). Change subject: IMPALA-7895: Incorrect expected results for spillable-buffer-sizing.test

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12007 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. Abandoned Wrong branch -- To view, visit http://gerrit.cloudera.org:8080/12007

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. IMPALA-7902: NumericLiteral fixes, refactoring The work to clean up the

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-29 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12007 Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. IMPALA-7902: NumericLiteral fixes, refactoring The work to clean up

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12001 ) Change subject: IMPALA-7902: NumericLiteral fixes, refactoring .. IMPALA-7902: NumericLiteral fixes, refactoring The work to clean up the

[Impala-ASF-CR] IMPALA-7842: Make query fragments available for unit testing

2018-11-30 Thread Paul Rogers (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11920 to look at the new patch set (#3). Change subject: IMPALA-7842: Make query fragments available for unit testing

[Impala-ASF-CR] IMPALA-7881 (Part 2): Visualize AST for easier debugging

2018-11-30 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12015 Change subject: IMPALA-7881 (Part 2): Visualize AST for easier debugging .. IMPALA-7881 (Part 2): Visualize AST for easier debugging The

[Impala-ASF-CR] IMPALA-7902: NumericLiteral fixes, refactoring

2018-11-30 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12001 to look at the new patch set (#6). Change subject: IMPALA-7902: NumericLiteral fixes, refactoring

[Impala-ASF-CR] IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

2018-11-29 Thread Paul Rogers (Code Review)
Hello Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11995 to look at the new patch set (#2). Change subject: IMPALA-7867 (Part 2): ArrayList cleanup in analyzer

<    1   2   3   4   5   >