[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

2019-02-15 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 11: Code-Review+2 LGTM. -- To vie

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-16 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12438 Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. IMPALA-8181: Abbreviate row counts in EXPLAIN A recent fix added node ca

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-16 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 5: This should be a simple one: just cleaning up EXPLAIN form

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-17 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12437 Change subject: IMPALA-8185: Abstract out real/mock file system operations .. IMPALA-8185: Abstract out real/mock file system operations

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-17 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12437 ) Change subject: IMPALA-8185: Abstract out real/mock file system operations .. Patch Set 1: Bharath, this is the code we discussed that a

[Impala-ASF-CR] IMPALA-7917 (Part 1): Decouple Sentry from Impala

2019-02-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12020 ) Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala .. Patch Set 12: Code-Review+2 (1 comment) Looks great! http://gerri

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-19 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12438 to look at the new patch set (#6). Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 5: (2 comments) Addressed comments. Found one more cardinali

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 2: (6 comments) Addressed review comments and

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. IMPALA-7450.

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 6: Passed pre-review tests after latest changes: https://jen

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12438 ) Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN .. Patch Set 7: Rebased on latest master. -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. IMPALA-7450.

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12438 to look at the new patch set (#7). Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. IMPALA-7450.

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] Logging current database context when logging analyzing queries.

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 1: Code-Review+2 (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. IMPALA-7450.

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. IMPALA-7450.

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 6: Fixed typo and rebase on master (again). -

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12437 to look at the new patch set (#2). Change subject: IMPALA-8185: Abstract out real/mock file system operations ...

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12437 ) Change subject: IMPALA-8185: Abstract out real/mock file system operations .. Patch Set 2: Rebased on master and fix style nagger warnin

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12437 to look at the new patch set (#3). Change subject: IMPALA-8185: Abstract out real/mock file system operations ...

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12437 to look at the new patch set (#4). Change subject: IMPALA-8185: Abstract out real/mock file system operations ...

[Impala-ASF-CR] IMPALA-8181: Abbreviate row counts in EXPLAIN

2019-02-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12438 to look at the new patch set (#8). Change subject: IMPALA-8181: Abbreviate row counts in EXPLAIN

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-20 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12437 to look at the new patch set (#5). Change subject: IMPALA-8185: Abstract out real/mock file system operations ..

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-20 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12437 ) Change subject: IMPALA-8185: Abstract out real/mock file system operations .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2019-02-21 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Abandoned Lower priority, not worth keeping this open for many m

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2019-02-21 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Abandoned Was meant to help with testing, but moving away from that effort. -

[Impala-ASF-CR] IMPALA-7781: Clean up expr rewriter predicates

2019-02-21 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11875 Change subject: IMPALA-7781: Clean up expr rewriter predicates .. IMPALA-7781: Clean up expr rewriter predicates The expression rewriter

[Impala-ASF-CR] IMPALA-7781: Clean up expr rewriter predicates

2019-02-21 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11875 ) Change subject: IMPALA-7781: Clean up expr rewriter predicates .. Abandoned Draft -- To view, visit http://gerrit.cloudera.org:8080/11875 To unsub

[Impala-ASF-CR] IMPALA-6900: Fix the min version invariant for invalidate metadata

2019-02-21 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12547 ) Change subject: IMPALA-6900: Fix the min version invariant for invalidate metadata .. Patch Set 3: Code-Review+2 LGTM -- To view, vis

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-21 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12427 to look at the new patch set (#4). Change subject: IMPALA-7560: Improve selectivity estimate for != .

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-21 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12427 to look at the new patch set (#5). Change subject: IMPALA-7560: Improve selectivity estimate for != .

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-21 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-7560: Improve selectivity estimate for != .. Patch Set 5: (2 comments) Rebased on master, again (twice). Address

[Impala-ASF-CR] IMPALA-7560: Improve selectivity estimate for !=

2019-02-21 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-7560: Improve selectivity estimate for != .. Abandoned Too risky to do now. Will revisit as part of a new patch later. -- T

[Impala-ASF-CR] IMPALA-8069: Crash in impala::Sorter::Run::Run

2019-02-22 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12562 to look at the new patch set (#2). Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run .. IMPALA-8069:

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-02-22 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 3: (7 comments) First-pass review. Sorry, was started on

[Impala-ASF-CR] IMPALA-8069: Crash in impala::Sorter::Run::Run

2019-02-25 Thread Paul Rogers (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12562 to look at the new patch set (#3). Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run ..

[Impala-ASF-CR] IMPALA-8069: Crash in impala::Sorter::Run::Run

2019-02-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12562 ) Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run .. Patch Set 3: (2 comments) Addressed review comments. Rerunning pre-re

[Impala-ASF-CR] IMPALA-7975 : Improve supportability of the automatic invalidate feature

2019-02-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12549 ) Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature .. Patch Set 4: Code-Review+1 (2 comments) LG

[Impala-ASF-CR] IMPALA-8069: Crash in impala::Sorter::Run::Run

2019-02-25 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12562 to look at the new patch set (#4). Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run

[Impala-ASF-CR] IMPALA-8243: Fix racy access to nonPartFieldSchemas

2019-02-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12572 ) Change subject: IMPALA-8243: Fix racy access to nonPartFieldSchemas_ .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-7975 : Improve supportability of the automatic invalidate feature

2019-02-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12549 ) Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature .. Patch Set 5: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-7645: Add a query option to set the default table file format

2019-02-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12568 ) Change subject: IMPALA-7645: Add a query option to set the default table file format .. Patch Set 6: Can the file format be set in the

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-02-25 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 7: Took a quick spin over the files. I really like how yo

[Impala-ASF-CR] IMPALA-8069: Crash in impala::Sorter::Run::Run

2019-02-25 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12562 to look at the new patch set (#5). Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run

[Impala-ASF-CR] IMPALA-8069: Crash in impala::Sorter::Run::Run

2019-02-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12562 ) Change subject: IMPALA-8069: Crash in impala::Sorter::Run::Run .. Patch Set 5: Passes pre-review tests: https://jenkins.impala.io/job/pr

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 2: (17 comments) Quick initial review. Mor

[Impala-ASF-CR] IMPALA-7975 : Improve supportability of the automatic invalidate feature

2019-02-26 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12549 ) Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature .. Patch Set 8: Code-Review+2 LGTM -- To vie

[Impala-ASF-CR] IMPALA-7972 Detect self-events to avoid unnecessary invalidates

2019-02-27 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 ) Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates .. Patch Set 4: (7 comments) Identified one more potent

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-02-27 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12437 to look at the new patch set (#6). Change subject: IMPALA-8185: Abstract out real/mock file system operations ..

[Impala-ASF-CR] IMPALA-8182: Add single-node plan to PlanCtx

2019-02-27 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12436 ) Change subject: IMPALA-8182: Add single-node plan to PlanCtx .. Abandoned Will do as part of an actual test later. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8266 : Event filtering logic may not filter all the events

2019-02-28 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12641 ) Change subject: IMPALA-8266 : Event filtering logic may not filter all the events .. Patch Set 1: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-03-01 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Abandoned Not a priority at the moment. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-03-01 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Abandoned Not a priority at the moment. -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8156: Add format options to the EXPLAIN statement

2019-03-01 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12340 ) Change subject: IMPALA-8156: Add format options to the EXPLAIN statement .. Abandoned Not a priority at the moment. -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

2019-03-01 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12265 ) Change subject: IMPALA-8106: Cleanup of literal expression nodes .. Abandoned Not a priority at the moment. -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8185: Abstract out real/mock file system operations

2019-03-01 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12437 ) Change subject: IMPALA-8185: Abstract out real/mock file system operations .. Abandoned Can live without it. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-04 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12535 Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. IMPALA-8014: Incorrect FK/PK cardinality estimation Impala uses tw

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: Passed pre-review tests: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8258: Realistic star-schema tables

2019-03-04 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12628 Change subject: IMPALA-8258: Realistic star-schema tables .. IMPALA-8258: Realistic star-schema tables The tables in the `functional` db

[Impala-ASF-CR] IMPALA-8258: Realistic star-schema tables

2019-03-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12628 ) Change subject: IMPALA-8258: Realistic star-schema tables .. Patch Set 4: Passed pre-review tests: https://jenkins.impala.io/job/pre-rev

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/125

[Impala-ASF-CR] IMPALA-8258: Realistic star-schema tables

2019-03-04 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12628 to look at the new patch set (#5). Change subject: IMPALA-8258: Realistic star-schema tables

[Impala-ASF-CR] IMPALA-8014: Incorrect FK/PK cardinality estimation

2019-03-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Incorrect FK/PK cardinality estimation .. Patch Set 4: Here are two references to get you started: https:/

[Impala-ASF-CR] IMPALA-8266 : Event filtering logic may not filter all the events

2019-03-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12641 ) Change subject: IMPALA-8266 : Event filtering logic may not filter all the events .. Patch Set 2: Code-Review+2 LGTM -- To view, visi

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-06 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 11: Code-Review+2 Very nicely done! -- To view, visit h

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 5: Code-Review+1 Code looks good. Would like Bharath to d

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-07 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 9: Code-Review+1 Really like how this turned out. Very clean. W

[Impala-ASF-CR] IMPALA-8014: Revise FK/PK cardinality estimation

2019-03-08 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12535 to look at the new patch set (#5). Change subject: IMPALA-8014: Revise FK/PK cardinality estimation ..

[Impala-ASF-CR] IMPALA-8014: Revise FK/PK cardinality estimation

2019-03-08 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12535 ) Change subject: IMPALA-8014: Revise FK/PK cardinality estimation .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12535

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-03-11 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 8: Code-Review+1 The code looks good. I'm not super fam

[Impala-ASF-CR] IMPALA-8133: [DOCS] Review and update Known Issues for 3.2

2019-03-11 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12718 ) Change subject: IMPALA-8133: [DOCS] Review and update Known Issues for 3.2 .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7718: [DOCS] Additional info in the extended EXPLAIN output

2019-03-13 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12732 ) Change subject: IMPALA-7718: [DOCS] Additional info in the extended EXPLAIN output .. Patch Set 4: Code-Review+2 LGTM -- To view, vis

[Impala-ASF-CR] IMPALA-7971: Add support for insert events in event processor.

2019-04-02 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12889 ) Change subject: IMPALA-7971: Add support for insert events in event processor. .. Patch Set 5: Code-Review+1 The code here is OK. Discus

[Impala-ASF-CR] IMPALA-4865: Reject Expr Rewrite When Appropriate

2019-04-04 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12814 ) Change subject: IMPALA-4865: Reject Expr Rewrite When Appropriate .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/1281

<    1   2   3   4   5