[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 4: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-ger

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4411 Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Make gen_build_version.py resilient to a failing git re

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4352 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. IMPALA-4091: Fix backend unit to log in logs/be_tests. 1. Many backend unit tests did not f

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServ

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. IMPALA-4008: don't bake in hash table and hash join pointers This fixes some of the c

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4326 To unsubscribe

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

2016-09-13 Thread Anonymous Coward (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4309 to look at the new patch set (#4). Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start.

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

2016-09-13 Thread Anonymous Coward (Code Review)
davy...@163.com has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 3: We have developed a configuration management system through which command

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: > > I'd like you to run the small suite of cluster tests, but you > can't > > yet

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogSer

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. Patch Set 4: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4352 To unsubscribe,

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-13 Thread Alex Behm (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4352 to look at the new patch set (#4). Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. IMPALA-

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4361/6/be/.impala.doxy File be/.impala.doxy: Line

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: > I'd like you to run the small suite of cluster tests, but you can't > yet until

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. IMPALA-4122: qgen: fix bitrotted cluster unit tests There's a small set of pytest-style tests

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4404 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. IMPALA-4118: extract encryption utils from BufferedBlockMgr As groundwork for IMPALA-4118, extract e

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Matthew Jacobs (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4175 to look at the new patch set (#4). Change subject: IMPALA-3718: Support subset of functional-query for Kudu

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 4: Code-Review+2 Fixed the commit msg, carrying the +2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-4110: Apache RAT script on Impala tarballs.

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4110: Apache RAT script on Impala tarballs. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4405 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 14: (25 comments) Here's a first set of comments, mostly focused on phjn.h. I need to go back

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4348/8/testdata/bin/check-

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4175/3//COMMIT_MSG Commit Mes

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 6: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4326 To uns

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4348/8/testdata/bin/chec

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4326 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4348/8/testd

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. Patch Set 3: Code-Review+1 Thanks for fixing this. -- To view, visit http://gerrit.cloudera.org:8080/43

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServ

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. Patch Set 3: (3 comments) > (3 comments) > > Looks good to me. > > Can we please separate the tool integr

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#6). Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. IMPALA-4110: Clean up issues found by Apache RAT. The script and support files are in another patch: https://gerr

[Impala-ASF-CR] IMPALA-4110: Apache RAT script on Impala tarballs.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4110: Apache RAT script on Impala tarballs. .. Patch Set 1: Separated from https://gerrit.cloudera.org/#/c/4361/ following a request by Alex. -- To view, v

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#5). Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. IMPALA-4110: Clean up issues found by Apache RAT. The script and support files are in another patch: https://gerr

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. .. IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. While I'm here, fix as many of the warnings as possibl

[Impala-ASF-CR] IMPALA-3491: Use unique db in test scanners.py and test aggregation.py

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4339 To

[Impala-ASF-CR] IMPALA-3491: Use unique db in test scanners.py and test aggregation.py

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py .. IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py Tes

[Impala-ASF-CR] IMPALA-4110: Apache RAT script on Impala tarballs.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4405 Change subject: IMPALA-4110: Apache RAT script on Impala tarballs. .. IMPALA-4110: Apache RAT script on Impala tarballs. Apache RAT is a too

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServ

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 14: (31 comments) Some comments and questions. http://gerrit.cloudera.org:8080/#/c/3873/14/be

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServ

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/CatalogServ

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() To improve

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4125 To uns

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog/

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 2: Code-Review+1 > My thought with xfail was that I wanted them to show up as xfail so > w

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/4326/4/be/src/exec/hash-table.h Fi

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4326 to look at the new patch set (#5). Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. IM

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 2: > (8 comments) > > Thanks for the feedback. > > My thought with xfail was that I

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4348 T

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. .. Patch Set 3: (3 comments) Looks good to me. Can we please separate the tool integration from the fixes in

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4404 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. IMPALA-3718: Support subset of functional-query for Kudu Adds initial support for the functional-query

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 18: I carried the +2 and pushed to asf. Thanks, Zoltan. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-3973: add position and occurrence to instr() .. IMPALA-3973: add position and occurrence to instr() Change-Id: Ie9648de458d243306fa14adc5e7f7002

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) I think we should avoid both forms of id inconsistency: Different tables with the same id, or the

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4094 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 1: (8 comments) Thanks for the feedback. My thought with xfail was that I wanted them to

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 17: Dan, could you please +2 again? I added the missing test case and I also had to rebase to a

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. Patch Set 5: Code-Review+1 Thanks for the review. Patch set 5 adds an ASF license notice to a file that p

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4404/4/tests/comparison/tests/te

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Michael Brown (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4404 to look at the new patch set (#5). Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. IMPALA-412

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/4326/4/be/src/exec/hash-table.h File b

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: I'd like you to run the small suite of cluster tests, but you can't yet until you rebase

[Impala-ASF-CR] IMPALA-4122: qgen: fix bitrotted cluster unit tests

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4404 Change subject: IMPALA-4122: qgen: fix bitrotted cluster unit tests .. IMPALA-4122: qgen: fix bitrotted cluster unit tests There's a sma

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4326/3/be/src/exec/hash-table.h Fi

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 4: Code-Review+1 Carry Michael's +1 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-13 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4326 to look at the new patch set (#4). Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. IM

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4094 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3873: Add QueryStateAccessor

2016-09-13 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-3873: Add QueryStateAccessor .. Abandoned No time to work on this. Will pick up when I've implemented Marcel's suggestions as a comparison. -- To view, visit h

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 4: Somehow Lars' earlier comments got deleted. Reproducing from my email: Patch Set

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h File

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4318/2/community.html File community

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Jim Apple (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4318 to look at the new patch set (#4). Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. ...

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Jim Apple (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4318 to look at the new patch set (#3). Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. ...

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4011/3/tests/comparison/cluster.py

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#4). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options back in

[Impala-ASF-CR] IMPALA-3491: Use unique db in test scanners.py and test aggregation.py

2016-09-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4339 To unsu

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-09-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 10: Code-Review+2 Rebased Carrying Alex's +2. Thanks Alex, Matt and Brock

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4011/3/tests/comparison/cluster.py File t

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4011/2//COMMIT_MSG Commit Message

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4318/2/community.html File comm

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#3). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options back in

[Impala-ASF-CR] IMPALA-3491: Use unique db in test scanners.py and test aggregation.py

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3491: Use unique db in test_scanners.py and test_aggregation.py .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4339 To un

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4348 T

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#8). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh We used to incl

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#7). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh We used to incl

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4348/6/testdata/bin/che

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h F

[Impala-ASF-CR] IMPALA-3980: Re-enable Hive as a target database for the Random Query Generator

2016-09-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: Re-enable Hive as a target database for the Random Query Generator .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4011/2//COMMIT

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 16: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4318/2/community.html File community

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-13 Thread Zoltan Ivanfi (Code Review)
Hello Lars Volker, Matthew Jacobs, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4094 to look at the new patch set (#16). Change subject: IMPALA-3973: add position and occurrence to instr()